Skip to content

Add release notes for LLDB inline diagnostics #116841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

adrian-prantl
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@DavidSpickett DavidSpickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@adrian-prantl adrian-prantl merged commit 3e552ed into llvm:main Nov 19, 2024
7 of 8 checks passed
@DavidSpickett
Copy link
Collaborator

I know I'm the one who asked you to release note this, but somehow I forgot about it and got this today:

(lldb) expression *(char[4])b
                   ˄˜˜˜˜˜˜˜˜
                   ╰─ error: C-style cast from 'int *' to 'char[4]' is not allowed

I was quite shocked to see the sort of diagnostics I expect from rustc, but in lldb. This is a great feature @adrian-prantl !

Definitely falls into the category of things users didn't know needed to be improved, but it's clearly an improvement once it's done.

@adrian-prantl
Copy link
Collaborator Author

Also want to make sure @PortalPete sees this, who wrote the original prototype for this and came up with the design!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants