Skip to content

[libc++] Mark charconv test as unsupported under msan #116933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

ldionne
Copy link
Member

@ldionne ldionne commented Nov 20, 2024

No description provided.

@ldionne ldionne requested a review from a team as a code owner November 20, 2024 06:55
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Nov 20, 2024
@ldionne
Copy link
Member Author

ldionne commented Nov 20, 2024

This seems to have started happening recently, probably around the time we landed hand-in-hand. Any clues @michaelrj-google @mordante ?

@llvmbot
Copy link
Member

llvmbot commented Nov 20, 2024

@llvm/pr-subscribers-libcxx

Author: Louis Dionne (ldionne)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/116933.diff

1 Files Affected:

  • (modified) libcxx/test/std/utilities/charconv/charconv.msvc/test.pass.cpp (+3)
diff --git a/libcxx/test/std/utilities/charconv/charconv.msvc/test.pass.cpp b/libcxx/test/std/utilities/charconv/charconv.msvc/test.pass.cpp
index c294a40ce71ce5..9279511e46b114 100644
--- a/libcxx/test/std/utilities/charconv/charconv.msvc/test.pass.cpp
+++ b/libcxx/test/std/utilities/charconv/charconv.msvc/test.pass.cpp
@@ -11,6 +11,9 @@
 // TODO Investigate why this fails
 // UNSUPPORTED: windows
 
+// This test times out under msan
+// UNSUPPORTED: msan
+
 // to_chars requires functions in the dylib that have not been introduced in older
 // versions of the dylib on macOS.
 // XFAIL: availability-fp_to_chars-missing

@frederick-vs-ja
Copy link
Contributor

frederick-vs-ja commented Nov 20, 2024

Copy link
Contributor

@michaelrj-google michaelrj-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with disabling this for now, though I'm not sure why it would be so slow under msan. I'll look into this when I get a chance.

@ldionne ldionne merged commit a9882bd into llvm:main Nov 22, 2024
63 of 64 checks passed
@ldionne ldionne deleted the review/unsupport-msan branch November 22, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants