Skip to content

[LLVM] Update ARM maintainers #117002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 25, 2024
Merged

[LLVM] Update ARM maintainers #117002

merged 5 commits into from
Nov 25, 2024

Conversation

nikic
Copy link
Contributor

@nikic nikic commented Nov 20, 2024

@rengolin You are currently listed as the maintainer for the ARM backend, but I think nowadays you mostly work on the MLIR side and aren't active in the ARM backend anymore, right?

I'd like to nominate @davemgreen as the new maintainer for ARM.

Copy link
Member

@rengolin rengolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes! It has been a while. Happy with the change, thanks!

@davemgreen
Copy link
Collaborator

Cool. Hmm... I'm not sure if it is very useful to have just me in the list, I'm just trying to help. In reality a lot of people have been helping out with the Arm backend for a long time and it would be a shame if we disrupted that. I would consider putting "Arms compiler team" as the first member on the list, but I can see that's not always very useful to people. I would suggest adding @ostannard for the assembly/disassembly, as he knows a lot more about that area than me. @eefriedman has done a lot of work over the years, I'm not sure if he would want the be on the list. We should find someone who looks after target parser too. The arm abi I would add @smithp35 to but that seems to be a separate section. @nasherm mentioned he was interested recently too.

Can we expand this a little to something like this, although maybe the "Arm's Compiler Team" could do with a better explanation.

#### ARM backend

Arm's Compiler Team \
David Green  [email protected] (email), [davemgreen](https://github.com/davemgreen) (GitHub) \
Oliver Stannard  [email protected] (email), [ostannard](https://github.com/ostannard) (GitHub) \
Nashe Mncube  [email protected] (email), [nasherm](https://github.com/nasherm) (GitHub)

Copy link
Collaborator

@ostannard ostannard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @davemgreen is a good choice for this. I'd also be happy to put my name down as a second maintainer.

@nasherm
Copy link
Contributor

nasherm commented Nov 21, 2024

I also agree @davemgreen is a good choice. I'm happy to be on this list as a tertiary maintainer.

@nikic
Copy link
Contributor Author

nikic commented Nov 21, 2024

@davemgreen Thanks for the response! I should have probably linked to https://llvm.org/docs/DeveloperPolicy.html#maintainers to clarify what the expectations for maintainers are.

I would consider putting "Arms compiler team" as the first member on the list, but I can see that's not always very useful to people.

The most important requirement here is really that there is some way to contact maintainers -- I think we could add something like "Arms compiler team" if there is at least a group email address (though a pingable team on GitHub would be ideal).

I would suggest adding @ostannard for the assembly/disassembly, as he knows a lot more about that area than me. @eefriedman has done a lot of work over the years, I'm not sure if he would want the be on the list. We should find someone who looks after target parser too. The arm abi I would add @smithp35 to but that seems to be a separate section. @nasherm mentioned he was interested recently too.

Happy to add additional people here, and we can also split this up further, no need to limit to a generic "ARM backend" category. Could do something like this:

#### ARM backend

David Green \
[email protected] (email), [davemgreen](https://github.com/davemgreen) (GitHub)

#### ARM backend - assembler/disassembler

Oliver Stannard \
[email protected] (email), [ostannard](https://github.com/ostannard) (GitHub)

#### ARM backend - ABI

Peter Smith \
[email protected] (email), [smithp35](https://github.com/smithp35) (GitHub)

etc.

Related to this @asl you are currently listed as the maintainer for ARM EABI at https://github.com/llvm/llvm-project/blob/main/llvm/Maintainers.md#arm-eabi. Is that still up to date?

@asl
Copy link
Collaborator

asl commented Nov 21, 2024

Related to this @asl you are currently listed as the maintainer for ARM EABI at https://github.com/llvm/llvm-project/blob/main/llvm/Maintainers.md#arm-eabi. Is that still up to date?

I think ARM EABI support is done for many years as of now. And given that these days we are having ARM compiler team contributing, it seems natural to move everything ARM-related to them :)

@davemgreen
Copy link
Collaborator

The most important requirement here is really that there is some way to contact maintainers -- I think we could add something like "Arms compiler team" if there is at least a group email address (though a pingable team on GitHub would be ideal).

Yeah I agree, I was thinking of something like the old PowerPC group from phabricator, but I don't know of a suitable alias or how well it works in practice. I would just want to encourage everyone to get involved and help out, not feeling like they have to leave it to others.

Could do something like this:

Sounds good. In fear of adding too many to the list, @stuij also offered to help with early architecture support and global-isel, which is an area that could do with the attention so would be good to add. I would also like to add Peter for ABI (as a whole, not EABI). I'm not sure how best it is to structure, something like this might be OK for now if it is acceptable, we can always change it later. If this isn't the best (I don't know how it renders) then either one big section or several should be OK.

David Green \
[email protected] (email), [davemgreen](https://github.com/davemgreen) (GitHub) \
Oliver Stannard (Especially assembly/dissassembly) \
[email protected] (email), [ostannard](https://github.com/ostannard) (GitHub) \
Nashe Mncube \
[email protected] (email), [nasherm](https://github.com/nasherm) (GitHub) \
Peter Smith (Anything ABI) \
[email protected] (email), [smithp35](https://github.com/smithp35) (GitHub) \
Ties Stuij (GlobalISel and early arch support) \
[email protected] (email), [stuij](https://github.com/stuij) (GitHub) \

@nikic nikic changed the title [LLVM] Update ARM maintainer [LLVM] Update ARM maintainers Nov 22, 2024
@nikic nikic requested review from asl, stuij and smithp35 November 22, 2024 09:02
@nikic
Copy link
Contributor Author

nikic commented Nov 22, 2024

@davemgreen Thanks, I updated the PR with your suggested list. I like the more compact format you suggested.

Copy link
Collaborator

@davemgreen davemgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM

Copy link
Collaborator

@smithp35 smithp35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

Copy link
Member

@stuij stuij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@nasherm nasherm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikic nikic merged commit 06cb5c9 into llvm:main Nov 25, 2024
6 of 8 checks passed
@nikic nikic deleted the arm-maintainer branch November 25, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants