Skip to content

[JITLink][LoongArch] Add support for R_LARCH_CALL36 relocation #117127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2024
Merged

[JITLink][LoongArch] Add support for R_LARCH_CALL36 relocation #117127

merged 1 commit into from
Nov 22, 2024

Conversation

wangleiat
Copy link
Contributor

This relocation is used for function calls with medium code model.

@wangleiat
[𝘀𝗽𝗿] initial version
2b901e6 
Created using spr 1.3.5-bogner
SixWeining
SixWeining approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@SixWeining SixWeining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Without this patch:

$ lli --code-model=medium hello.ll
JIT session error: Unsupported loongarch relocation:110: R_LARCH_CALL36
lli: Failed to materialize symbols: { (main, { main }) }

lhames
lhames approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@lhames lhames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @wangleiat!

@wangleiat wangleiat merged commit ca9f358 into main Nov 22, 2024
9 checks passed
@wangleiat wangleiat deleted the users/wangleiat/spr/jitlinkloongarch-add-support-for-r_larch_call36-relocation branch November 22, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lhames lhames lhames approved these changes

@SixWeining SixWeining SixWeining approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wangleiat @lhames @SixWeining