Rename operator[].pass.cpp to subscript_operator.pass.cpp

[vannem-sj]

This filename includes non FAT32 legal characters, and has caused a few issues with glob tools that don't escape brackets properly.

[github-actions]

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

[llvmbot]

@llvm/pr-subscribers-libcxx

Author: None (vannem-sj)

Changes

This filename includes non FAT32 legal characters, and has caused a few issues with glob tools that don't escape brackets properly.

---

Full diff: https://github.com/llvm/llvm-project/pull/117216.diff

1 Files Affected:

• (renamed) libcxx/test/std/time/time.cal/time.cal.weekday/time.cal.weekday.members/subscript_operator.pass.cpp ()

diff --git a/libcxx/test/std/time/time.cal/time.cal.weekday/time.cal.weekday.members/operator[].pass.cpp b/libcxx/test/std/time/time.cal/time.cal.weekday/time.cal.weekday.members/subscript_operator.pass.cpp
similarity index 100%
rename from libcxx/test/std/time/time.cal/time.cal.weekday/time.cal.weekday.members/operator[].pass.cpp
rename to libcxx/test/std/time/time.cal/time.cal.weekday/time.cal.weekday.members/subscript_operator.pass.cpp

[github-actions]

⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo.
Please turn off Keep my email addresses private setting in your account.
See LLVM Discourse for more information.

[github-actions]

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:

git-clang-format --diff a3e2f0acdf5ee452c8eb177b56f476b432539e08 dd123ad83ee572c336a0d723f6f283bebe30d1bc --extensions cpp -- libcxx/test/std/time/time.cal/time.cal.weekday/time.cal.weekday.members/subscript_operator.pass.cpp

View the diff from clang-format here.

diff --git a/libcxx/test/std/time/time.cal/time.cal.weekday/time.cal.weekday.members/subscript_operator.pass.cpp b/libcxx/test/std/time/time.cal/time.cal.weekday/time.cal.weekday.members/subscript_operator.pass.cpp
index 1900f00ba7..b2a1146c4a 100644
--- a/libcxx/test/std/time/time.cal/time.cal.weekday/time.cal.weekday.members/subscript_operator.pass.cpp
+++ b/libcxx/test/std/time/time.cal/time.cal.weekday/time.cal.weekday.members/subscript_operator.pass.cpp
@@ -13,7 +13,6 @@
 //   constexpr weekday_indexed operator[](unsigned index) const noexcept;
 //   constexpr weekday_last    operator[](last_spec)      const noexcept;
 
-
 #include <chrono>
 #include <cassert>
 #include <type_traits>
@@ -22,39 +21,36 @@
 #include "test_macros.h"
 #include "../../euclidian.h"
 
-int main(int, char**)
-{
-    using weekday         = std::chrono::weekday;
-    using weekday_last    = std::chrono::weekday_last;
-    using weekday_indexed = std::chrono::weekday_indexed;
+int main(int, char**) {
+  using weekday         = std::chrono::weekday;
+  using weekday_last    = std::chrono::weekday_last;
+  using weekday_indexed = std::chrono::weekday_indexed;
 
-    constexpr weekday Sunday = std::chrono::Sunday;
+  constexpr weekday Sunday = std::chrono::Sunday;
 
-    ASSERT_NOEXCEPT(                           std::declval<weekday>()[1U]);
-    ASSERT_SAME_TYPE(weekday_indexed, decltype(std::declval<weekday>()[1U]));
+  ASSERT_NOEXCEPT(std::declval<weekday>()[1U]);
+  ASSERT_SAME_TYPE(weekday_indexed, decltype(std::declval<weekday>()[1U]));
 
-    ASSERT_NOEXCEPT(                           std::declval<weekday>()[std::chrono::last]);
-    ASSERT_SAME_TYPE(weekday_last,    decltype(std::declval<weekday>()[std::chrono::last]));
+  ASSERT_NOEXCEPT(std::declval<weekday>()[std::chrono::last]);
+  ASSERT_SAME_TYPE(weekday_last, decltype(std::declval<weekday>()[std::chrono::last]));
 
-    static_assert(Sunday[2].weekday() == Sunday, "");
-    static_assert(Sunday[2].index  () == 2, "");
+  static_assert(Sunday[2].weekday() == Sunday, "");
+  static_assert(Sunday[2].index() == 2, "");
 
-    for (unsigned i = 0; i <= 6; ++i)
-    {
-        weekday wd(i);
-        weekday_last wdl = wd[std::chrono::last];
-        assert(wdl.weekday() == wd);
-        assert(wdl.ok());
-    }
+  for (unsigned i = 0; i <= 6; ++i) {
+    weekday wd(i);
+    weekday_last wdl = wd[std::chrono::last];
+    assert(wdl.weekday() == wd);
+    assert(wdl.ok());
+  }
 
-    for (unsigned i = 0; i <= 6; ++i)
-        for (unsigned j = 1; j <= 5; ++j)
-    {
-        weekday wd(i);
-        weekday_indexed wdi = wd[j];
-        assert(wdi.weekday() == wd);
-        assert(wdi.index() == j);
-        assert(wdi.ok());
+  for (unsigned i = 0; i <= 6; ++i)
+    for (unsigned j = 1; j <= 5; ++j) {
+      weekday wd(i);
+      weekday_indexed wdi = wd[j];
+      assert(wdi.weekday() == wd);
+      assert(wdi.index() == j);
+      assert(wdi.ok());
     }
 
   return 0;

[ldionne]

LGTM, but please address the Github email address issue before we commit this!

[vannem-sj]

I believe I've fixed my email address (it shows in my local git log), but I'm not sure where to see that in the Github UI.

[ldionne]

Thanks!

[github-actions]

@vannem-sj Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!