Skip to content

[libc] Deprecate LLVM_ENABLE_PROJECTS in favor of LLVM_ENABLE_RUNTIMES. #117265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2024
Merged

[libc] Deprecate LLVM_ENABLE_PROJECTS in favor of LLVM_ENABLE_RUNTIMES. #117265

merged 1 commit into from
Dec 2, 2024

Conversation

nickdesaulniers
Copy link
Member

We plan to make this a hard error in the LLVM 21 release.

Link: #78479

@nickdesaulniers
deprecate LLVM_ENABLE_PROJECTS in favor of LLVM_ENABLE_RUNTIMES
1194df9 
We plan to make this a hard error in the LLVM 21 release.

Link: llvm#78479
@lntue lntue changed the title deprecate LLVM_ENABLE_PROJECTS in favor of LLVM_ENABLE_RUNTIMES [libc] Deprecate LLVM_ENABLE_PROJECTS in favor of LLVM_ENABLE_RUNTIMES. Nov 22, 2024
jhuber6
jhuber6 approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@jhuber6 jhuber6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

nickdesaulniers added a commit to nickdesaulniers/llvm-zorg that referenced this pull request Dec 2, 2024
@nickdesaulniers
libc: make all builds LLVM_ENABLE_RUNTIMES
fb1d6fd 
No longer will any CI builds use LLVM_ENABLE_PROJECTS, which is deprecated as
of llvm/llvm-project#117265.

libc-x86_64-debian-dbg-runtimes-build can be offlined as a result of this
change.

Buildbots will probably need their CMakeCache.txt reset after this.
@nickdesaulniers nickdesaulniers mentioned this pull request Dec 2, 2024
Merged
@nickdesaulniers nickdesaulniers merged commit 5f881b7 into llvm:main Dec 2, 2024
9 checks passed
@nickdesaulniers nickdesaulniers deleted the no_enable_projects branch December 2, 2024 22:48
@llvm-ci
Copy link
Collaborator

llvm-ci commented Dec 3, 2024

LLVM Buildbot has detected a new failure on builder clang-ppc64-aix running on aix-ppc64 while building llvm at step 3 "clean-build-dir".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/64/builds/1606

Here is the relevant piece of the build log for the reference 
Step 3 (clean-build-dir) failure: Delete failed. (failure) (timed out)
Step 6 (test-build-unified-tree-check-all) failure: test (failure)
******************** TEST 'Clang :: ClangScanDeps/verbose.test' FAILED ********************
Exit Code: 1

Command Output (stderr):
--
RUN: at line 1: rm -rf /home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/build/tools/clang/test/ClangScanDeps/Output/verbose.test.tmp
+ rm -rf /home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/build/tools/clang/test/ClangScanDeps/Output/verbose.test.tmp
RUN: at line 2: split-file /home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/llvm-project/clang/test/ClangScanDeps/verbose.test /home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/build/tools/clang/test/ClangScanDeps/Output/verbose.test.tmp
+ split-file /home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/llvm-project/clang/test/ClangScanDeps/verbose.test /home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/build/tools/clang/test/ClangScanDeps/Output/verbose.test.tmp
RUN: at line 3: sed -e "s|DIR|/home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/build/tools/clang/test/ClangScanDeps/Output/verbose.test.tmp|g" /home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/build/tools/clang/test/ClangScanDeps/Output/verbose.test.tmp/cdb.json.in > /home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/build/tools/clang/test/ClangScanDeps/Output/verbose.test.tmp/cdb.json
+ sed -e 's|DIR|/home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/build/tools/clang/test/ClangScanDeps/Output/verbose.test.tmp|g' /home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/build/tools/clang/test/ClangScanDeps/Output/verbose.test.tmp/cdb.json.in
RUN: at line 5: /home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/build/bin/clang-scan-deps -compilation-database /home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/build/tools/clang/test/ClangScanDeps/Output/verbose.test.tmp/cdb.json -v -o /home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/build/tools/clang/test/ClangScanDeps/Output/verbose.test.tmp/result.json 2>&1 | /home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/build/bin/FileCheck /home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/llvm-project/clang/test/ClangScanDeps/verbose.test
+ /home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/build/bin/clang-scan-deps -compilation-database /home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/build/tools/clang/test/ClangScanDeps/Output/verbose.test.tmp/cdb.json -v -o /home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/build/tools/clang/test/ClangScanDeps/Output/verbose.test.tmp/result.json
+ /home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/build/bin/FileCheck /home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/llvm-project/clang/test/ClangScanDeps/verbose.test
/home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/llvm-project/clang/test/ClangScanDeps/verbose.test:6:11: error: CHECK: expected string not found in input
// CHECK: *** Virtual File System Stats:
          ^
<stdin>:1:1: note: scanning from here
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
^
<stdin>:1:8: note: possible intended match here
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace.
       ^

Input file: <stdin>
Check file: /home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/llvm-project/clang/test/ClangScanDeps/verbose.test

-dump-input=help explains the following input dump.

Input was:
<<<<<<
           1: PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace. 
check:6'0     X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
check:6'1            ?                                                                                                     possible intended match
>>>>>>

--

********************

@nickdesaulniers nickdesaulniers mentioned this pull request Dec 3, 2024
Merged
@nickdesaulniers
Copy link
Member Author

It sounds like we might need to rethink this for the gpu build's host utilities.

#117220 (review)

nickdesaulniers added a commit to nickdesaulniers/llvm-zorg that referenced this pull request Dec 3, 2024
@nickdesaulniers
libc: make all builds LLVM_ENABLE_RUNTIMES
f088255 
No longer will any CI builds use LLVM_ENABLE_PROJECTS, which is deprecated as
of llvm/llvm-project#117265.

libc-x86_64-debian-dbg-runtimes-build can be offlined as a result of this
change.

Buildbots will probably need their CMakeCache.txt reset after this.
nickdesaulniers added a commit to nickdesaulniers/llvm-zorg that referenced this pull request Dec 10, 2024
@nickdesaulniers
libc: make all builds LLVM_ENABLE_RUNTIMES
c0ace11 
No longer will any CI builds use LLVM_ENABLE_PROJECTS, which is deprecated as
of llvm/llvm-project#117265.

libc-x86_64-debian-dbg-runtimes-build can be offlined as a result of this
change.

Buildbots will probably need their CMakeCache.txt reset after this.
nickdesaulniers added a commit to llvm/llvm-zorg that referenced this pull request Dec 12, 2024
@nickdesaulniers
libc: make all builds LLVM_ENABLE_RUNTIMES (#325)
6deafd3 
No longer will any CI builds use LLVM_ENABLE_PROJECTS, which is
deprecated as of llvm/llvm-project#117265.

Buildbots will probably need their CMakeCache.txt reset after this.

Link: llvm/llvm-project#78479
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrhosek petrhosek petrhosek approved these changes

@SchrodingerZhu SchrodingerZhu SchrodingerZhu approved these changes

@jhuber6 jhuber6 jhuber6 approved these changes

@michaelrj-google michaelrj-google michaelrj-google approved these changes

@lntue lntue Awaiting requested review from lntue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nickdesaulniers @llvm-ci @petrhosek @SchrodingerZhu @jhuber6 @michaelrj-google