[clang] Add a common definition of isPointerLikeType for lifetime analysis #117315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
clang
|
@llvm/pr-subscribers-clang Author: Utkarsh Saxena (usx95) ChangesFull diff: https://github.com/llvm/llvm-project/pull/117315.diff 1 Files Affected:
diff --git a/clang/lib/Sema/CheckExprLifetime.cpp b/clang/lib/Sema/CheckExprLifetime.cpp
index 8886e5e307ddf8..64dc4794b6235a 100644
--- a/clang/lib/Sema/CheckExprLifetime.cpp
+++ b/clang/lib/Sema/CheckExprLifetime.cpp
@@ -253,9 +253,12 @@ static void visitLocalsRetainedByReferenceBinding(IndirectLocalPath &Path,
LocalVisitor Visit);
template <typename T> static bool isRecordWithAttr(QualType Type) {
- if (auto *RD = Type->getAsCXXRecordDecl())
- return RD->hasAttr<T>();
- return false;
+ auto *RD = Type->getAsCXXRecordDecl();
+ if (!RD)
+ return false;
+ if (auto *CTSD = dyn_cast<ClassTemplateSpecializationDecl>(RD))
+ RD = CTSD->getSpecializedTemplate()->getTemplatedDecl();
+ return RD->hasAttr<T>();
}
// Decl::isInStdNamespace will return false for iterators in some STL
|
hokein
reviewed
Nov 25, 2024
hokein
reviewed
Nov 28, 2024
clang/include/clang/Sema/Sema.h
Outdated
| @@ -1763,6 +1763,18 @@ class Sema final : public SemaBase { | |||
| /// Add [[gsl::Pointer]] attributes for std:: types. | |||
| void inferGslPointerAttribute(TypedefNameDecl *TD); | |||
|
|
|||
| template <typename T> static bool isRecordWithAttr(QualType Type) { | |||
There was a problem hiding this comment.
I'd avoid expose this function if possible (as it seems only be used in CheckExprLifetime.cpp and isPointerLikeType). How about?
- we just keep the
isPointerLikeTypedeclaration in Sema.h - define
isPointerLikeTypeinCheckExprLifetime.cpp - the
isRecordWithAttrcan still be inCheckExprLifetime.cpp.
I think it is fine as CheckExprLifetime.cpp is a part of Sema library.
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
hokein
approved these changes
Nov 28, 2024
clang/include/clang/Sema/Sema.h
Outdated
| @@ -1763,6 +1763,8 @@ class Sema final : public SemaBase { | |||
| /// Add [[gsl::Pointer]] attributes for std:: types. | |||
| void inferGslPointerAttribute(TypedefNameDecl *TD); | |||
|
|
|||
| static bool isPointerLikeType(QualType QT); | |||
There was a problem hiding this comment.
nit: please add some comments for this API. I think it is worth clarifying that it is only used for the lifetime analysis (to avoid misuse).
There was a problem hiding this comment.
Added comments. Also moved to CheckExprLifetime.h.
I guess that is better to avoid wrong usages.
There was a problem hiding this comment.
Oh, nice! Moving to checkExprLifetime.h makes more sense.
|
The PR description needs to update as well. |
usx95
changed the title
hokein
approved these changes
Nov 28, 2024
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/171/builds/11264 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also checks for annotation for template specializations which sometimes may not have the annotation attached.