[lldb] Fix DW_OP_piece-O3 test on AArch64 Windows #117336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-backend-aarch64 @llvm/pr-subscribers-lldb Author: Ilia Kuklin (kuilpd) ChangesMaking a breakpoint on a line causes an error on aarch64-pc-windows. This patch changes the test so that a breakpoint can be made on a function name. Full diff: https://github.com/llvm/llvm-project/pull/117336.diff 1 Files Affected:
diff --git a/lldb/test/Shell/SymbolFile/DWARF/DW_OP_piece-O3.c b/lldb/test/Shell/SymbolFile/DWARF/DW_OP_piece-O3.c
index 77ea81f30395f0..75cd4e6a913b9c 100644
--- a/lldb/test/Shell/SymbolFile/DWARF/DW_OP_piece-O3.c
+++ b/lldb/test/Shell/SymbolFile/DWARF/DW_OP_piece-O3.c
@@ -7,7 +7,7 @@
// RUN: %clang_host -O3 -gdwarf %s -o %t
// RUN: %lldb %t \
-// RUN: -o "b 25" \
+// RUN: -o "b done" \
// RUN: -o "r" \
// RUN: -o "p/x array[2]" \
// RUN: -b | FileCheck %s
@@ -17,10 +17,10 @@
static char array[5] = {0, 1, 2, 3, 4};
-void func() __attribute__((noinline));
-void func() { ++array[2]; };
+int done() __attribute__((noinline));
+int done() { return array[2]; };
int main(void) {
- func();
- return 0;
+ ++array[2];
+ return done();
}
|
|
@llvm/pr-subscribers-platform-windows Author: Ilia Kuklin (kuilpd) ChangesMaking a breakpoint on a line causes an error on aarch64-pc-windows. This patch changes the test so that a breakpoint can be made on a function name. Full diff: https://github.com/llvm/llvm-project/pull/117336.diff 1 Files Affected:
diff --git a/lldb/test/Shell/SymbolFile/DWARF/DW_OP_piece-O3.c b/lldb/test/Shell/SymbolFile/DWARF/DW_OP_piece-O3.c
index 77ea81f30395f0..75cd4e6a913b9c 100644
--- a/lldb/test/Shell/SymbolFile/DWARF/DW_OP_piece-O3.c
+++ b/lldb/test/Shell/SymbolFile/DWARF/DW_OP_piece-O3.c
@@ -7,7 +7,7 @@
// RUN: %clang_host -O3 -gdwarf %s -o %t
// RUN: %lldb %t \
-// RUN: -o "b 25" \
+// RUN: -o "b done" \
// RUN: -o "r" \
// RUN: -o "p/x array[2]" \
// RUN: -b | FileCheck %s
@@ -17,10 +17,10 @@
static char array[5] = {0, 1, 2, 3, 4};
-void func() __attribute__((noinline));
-void func() { ++array[2]; };
+int done() __attribute__((noinline));
+int done() { return array[2]; };
int main(void) {
- func();
- return 0;
+ ++array[2];
+ return done();
}
|
kuilpd
added a commit
that referenced
this pull request
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making a breakpoint on a line causes an error on aarch64-pc-windows. This patch changes the test so that a breakpoint can be made on a function name.
#117168