[AIX] Fix AIX BuildBot failure as AIX linker doesn't support version script. #117342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-clang Author: Daniel Chen (DanielCChen) ChangesAIX BuildBot failed due to #116556 as AIX linker does not support version script. This PR is on behalf of [email protected] Full diff: https://github.com/llvm/llvm-project/pull/117342.diff 1 Files Affected:
diff --git a/clang/tools/clang-shlib/CMakeLists.txt b/clang/tools/clang-shlib/CMakeLists.txt
index 31484ec49c7739..2d97347ea7f828 100644
--- a/clang/tools/clang-shlib/CMakeLists.txt
+++ b/clang/tools/clang-shlib/CMakeLists.txt
@@ -48,11 +48,13 @@ add_clang_library(clang-cpp
${_OBJECTS}
LINK_LIBS
${_DEPS})
+# AIX linker does not support version script
+if (NOT ${CMAKE_SYSTEM_NAME} MATCHES "AIX")
+ configure_file(simple_version_script.map.in simple_version_script.map)
-configure_file(simple_version_script.map.in simple_version_script.map)
-
-if (CMAKE_SYSTEM_NAME STREQUAL "Linux")
- target_link_options(clang-cpp PRIVATE LINKER:--version-script,${CMAKE_CURRENT_BINARY_DIR}/simple_version_script.map)
+ if (CMAKE_SYSTEM_NAME STREQUAL "Linux")
+ target_link_options(clang-cpp PRIVATE LINKER:--version-script,${CMAKE_CURRENT_BINARY_DIR}/simple_version_script.map)
+ endif()
endif()
# Optimize function calls for default visibility definitions to avoid PLT and
|
|
|
||
| configure_file(simple_version_script.map.in simple_version_script.map) | ||
|
|
||
| if (CMAKE_SYSTEM_NAME STREQUAL "Linux") |
There was a problem hiding this comment.
This implies NOT ${CMAKE_SYSTEM_NAME} MATCHES "AIX", hence the target_link_options is already unreachable.
There was a problem hiding this comment.
You are right, @aaronpuchert! With commit eaa0a21 the AIX build problem is fixed already so the change in #117342 does not make sense any more. I created PR Revert "[AIX] Fix AIX BuildBot failure as AIX linker doesn't support version script.".
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/64/builds/1515 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AIX BuildBot failed due to #116556 as AIX linker does not support version script.
This PR is to fix the failure
This PR is on behalf of [email protected]