[nfc][mlir][scf]: Define scf.for lower/upper bounds can be also negative or zero #117534
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AviadCo
force-pushed
the
scf/make-for-clear
branch
from
10a850a to
8e49c01
Compare
|
@llvm/pr-subscribers-mlir-scf Author: Aviad Cohen (AviadCo) ChangesPer the discussion here: #116748 (comment) , this commit properly declare that lower and upper bounds can be also negative or zero. Full diff: https://github.com/llvm/llvm-project/pull/117534.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Dialect/SCF/IR/SCFOps.td b/mlir/include/mlir/Dialect/SCF/IR/SCFOps.td
index 361f8e0cf79ec6..64fa2df2431c71 100644
--- a/mlir/include/mlir/Dialect/SCF/IR/SCFOps.td
+++ b/mlir/include/mlir/Dialect/SCF/IR/SCFOps.td
@@ -153,9 +153,10 @@ def ForOp : SCF_Op<"for",
operation defines an SSA value for its induction variable. It has one
region capturing the loop body. The induction variable is represented as an
argument of this region. This SSA value is a signless integer or index.
- The step is a value of same type but required to be positive. The lower and
- upper bounds specify a half-open range: the range includes the lower bound
- but does not include the upper bound.
+ The step is a value of same type but required to be positive, the lower and
+ upper bounds can be also negative or zero. The lower and upper bounds specify
+ a half-open range: the range includes the lower bound but does not include
+ the upper bound.
The body region must contain exactly one block that terminates with
`scf.yield`. Calling ForOp::build will create such a region and insert
|
|
@llvm/pr-subscribers-mlir Author: Aviad Cohen (AviadCo) ChangesPer the discussion here: #116748 (comment) , this commit properly declare that lower and upper bounds can be also negative or zero. Full diff: https://github.com/llvm/llvm-project/pull/117534.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Dialect/SCF/IR/SCFOps.td b/mlir/include/mlir/Dialect/SCF/IR/SCFOps.td
index 361f8e0cf79ec6..64fa2df2431c71 100644
--- a/mlir/include/mlir/Dialect/SCF/IR/SCFOps.td
+++ b/mlir/include/mlir/Dialect/SCF/IR/SCFOps.td
@@ -153,9 +153,10 @@ def ForOp : SCF_Op<"for",
operation defines an SSA value for its induction variable. It has one
region capturing the loop body. The induction variable is represented as an
argument of this region. This SSA value is a signless integer or index.
- The step is a value of same type but required to be positive. The lower and
- upper bounds specify a half-open range: the range includes the lower bound
- but does not include the upper bound.
+ The step is a value of same type but required to be positive, the lower and
+ upper bounds can be also negative or zero. The lower and upper bounds specify
+ a half-open range: the range includes the lower bound but does not include
+ the upper bound.
The body region must contain exactly one block that terminates with
`scf.yield`. Calling ForOp::build will create such a region and insert
|
AviadCo
changed the title
ThomasRaoux
reviewed
Nov 25, 2024
…ive or zero Per the discussion here: llvm#116748 (comment) , this commit properly declare that lower and upper bounds can be also negative or zero.
AviadCo
force-pushed
the
scf/make-for-clear
branch
from
8e49c01 to
b5b2499
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the discussion here: #116748 (comment) , this commit properly declare that lower and upper bounds can be also negative or zero.