Skip to content

[clang-format] fix: add missing default_extensions values to git-clang-format #117730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

lumirlumir
Copy link
Contributor

@lumirlumir lumirlumir commented Nov 26, 2024

Hello,

Although the properties listed in the code below are used as supported file extensions, some of these extensions do not exist in git-clang-format as default_extensions. This causes inconsistency when using git-clang-format with clang-format.

Therefore, I added the missing supported default extensions to git-clang-format.

"supported:\n"
" CSharp: .cs\n"
" Java: .java\n"
" JavaScript: .mjs .js .ts\n"
" Json: .json\n"
" Objective-C: .m .mm\n"
" Proto: .proto .protodevel\n"
" TableGen: .td\n"
" TextProto: .txtpb .textpb .pb.txt .textproto .asciipb\n"
" Verilog: .sv .svh .v .vh"),

Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@llvmbot
Copy link
Member

llvmbot commented Nov 26, 2024

@llvm/pr-subscribers-clang-format

Author: 루밀LuMir (lumirlumir)

Changes

Hello,

Although the properties listed in the code below are used as supported file extensions, some of these extensions do not exist in git-clang-format. This causes inconsistency when using git-clang-format with clang-format.

Therefore, I added the missing supported default extensions to git-clang-format.

"supported:\n"
" CSharp: .cs\n"
" Java: .java\n"
" JavaScript: .mjs .js .ts\n"
" Json: .json\n"
" Objective-C: .m .mm\n"
" Proto: .proto .protodevel\n"
" TableGen: .td\n"
" TextProto: .txtpb .textpb .pb.txt .textproto .asciipb\n"
" Verilog: .sv .svh .v .vh"),


Full diff: https://github.com/llvm/llvm-project/pull/117730.diff

1 Files Affected:

  • (modified) clang/tools/clang-format/git-clang-format (+4-2)
diff --git a/clang/tools/clang-format/git-clang-format b/clang/tools/clang-format/git-clang-format
index bacbd8de245666..6a2a2a22ec5c2b 100755
--- a/clang/tools/clang-format/git-clang-format
+++ b/clang/tools/clang-format/git-clang-format
@@ -94,11 +94,13 @@ def main():
       # Other languages that clang-format supports
       'proto', 'protodevel',  # Protocol Buffers
       'java',  # Java
-      'js',  # JavaScript
+      'mjs', 'js',  # JavaScript
       'ts',  # TypeScript
       'cs',  # C Sharp
       'json',  # Json
-      'sv', 'svh', 'v', 'vh', # Verilog
+      'sv', 'svh', 'v', 'vh',  # Verilog
+      'td',  # TableGen
+      'txtpb', 'textpb', 'pb.txt', 'textproto', 'asciipb',  # TextProto
       ])
 
   p = argparse.ArgumentParser(

@owenca owenca merged commit 6c7b988 into llvm:main Nov 27, 2024
10 checks passed
Copy link

@lumirlumir Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

@lumirlumir lumirlumir deleted the patch-1 branch November 27, 2024 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants