[compiler-rt] Fix detecting _Float16 support for secondary targets #117813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
compnerd
approved these changes
Nov 27, 2024
DimitryAndric
approved these changes
Nov 27, 2024
|
@arichardson are you a committer? If not, ping me and I will merge this. |
DimitryAndric
deleted the
users/arichardson/spr/compiler-rt-fix-detecting-_float16-support-for-secondary-targets
branch
etcwilde
pushed a commit
to etcwilde/llvm-project
that referenced
this pull request
Apr 4, 2025
…lvm#117813) It turns out we were not passing -m32 to the check_c_source_compiles() invocation since CMAKE_REQUIRE_FLAGS needs to be string separated list and we were passing a ;-separated CMake list which appears to be parsed by CMake as 'ignore all arguments beyond the first'. Fix this by transforming the list to a command line first. With this change, Clang 17 no longer claims to support _Float16 for i386. (cherry picked from commit a4c8ef0)
etcwilde
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Apr 7, 2025
[compiler-rt] Fix detecting _Float16 support for secondary targets (llvm#117813)
devincoughlin
pushed a commit
to swiftlang/llvm-project
that referenced
this pull request
Apr 21, 2025
…lvm#117813) It turns out we were not passing -m32 to the check_c_source_compiles() invocation since CMAKE_REQUIRE_FLAGS needs to be string separated list and we were passing a ;-separated CMake list which appears to be parsed by CMake as 'ignore all arguments beyond the first'. Fix this by transforming the list to a command line first. With this change, Clang 17 no longer claims to support _Float16 for i386. (cherry picked from commit a4c8ef0) (cherry picked from commit 8b57579)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out we were not passing -m32 to the check_c_source_compiles()
invocation since CMAKE_REQUIRE_FLAGS needs to be string separated list and
we were passing a ;-separated CMake list which appears to be parsed by
CMake as 'ignore all arguments beyond the first'.
Fix this by transforming the list to a command line first.
With this change, Clang 17 no longer claims to support _Float16 for i386.