[RISCV] Update matchSplatAsGather to convert vectors if they have different sizes #117878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
|
I think the title needs updated, this is just modifying the matchSplatAsGather combine right? |
lukel97
reviewed
Nov 27, 2024
mikhailramalho
changed the title
topperc
reviewed
Nov 27, 2024
lukel97
reviewed
Nov 28, 2024
This patch changes matchSplatAsGather to use vrgather no only when we see an EXTRACT_VECTOR_ELT but also for RISCVISD::VMV_X_S.
Signed-off-by: Mikhail R. Gadelha <[email protected]>
Signed-off-by: Mikhail R. Gadelha <[email protected]>
Signed-off-by: Mikhail R. Gadelha <[email protected]>
Signed-off-by: Mikhail R. Gadelha <[email protected]>
Signed-off-by: Mikhail R. Gadelha <[email protected]>
topperc
reviewed
Dec 2, 2024
Signed-off-by: Mikhail R. Gadelha <[email protected]>
…e other is fixed Signed-off-by: Mikhail R. Gadelha <[email protected]>
mikhailramalho
force-pushed
the
riscv-match
branch
from
f50860a to
09e4d3e
Compare
lukel97
reviewed
Dec 3, 2024
Signed-off-by: Mikhail R. Gadelha <[email protected]>
Signed-off-by: Mikhail R. Gadelha <[email protected]>
|
ping @topperc I think I addressed your comments, could you take another look? |
mikhailramalho
added a commit
to mikhailramalho/llvm-project
that referenced
this pull request
Dec 5, 2024
…it is in-bounds This a follow up to llvm#117878 and allows the usage of vrgather if the index we are accessing in VT is a constant and within bounds. This patch replaces the previous behavior of bailing out if the length of the search vector was greater than the vector of elements we are searching for. Since matchSplatAsGather works on EXTRACT_VECTOR_ELT, and we know the index where the element is being extracted from, we can use safely use vrgather.
mikhailramalho
added a commit
to mikhailramalho/llvm-project
that referenced
this pull request
Jan 16, 2025
…it is in-bounds This a follow up to llvm#117878 and allows the usage of vrgather if the index we are accessing in VT is a constant and within bounds. This patch replaces the previous behavior of bailing out if the length of the search vector was greater than the vector of elements we are searching for. Since matchSplatAsGather works on EXTRACT_VECTOR_ELT, and we know the index where the element is being extracted from, we can use safely use vrgather.
preames
pushed a commit
that referenced
this pull request
Jan 21, 2025
…in-bounds (#118873) This is a follow-up to #117878 and allows the usage of vrgather if the index we are accessing in VT is constant and within bounds. This patch replaces the previous behavior of bailing out if the length of the search vector is greater than the vector of elements we are searching for. Since matchSplatAsGather works on EXTRACT_VECTOR_ELT, and we know the index from which the element is extracted, we only need to check if we are doing an insert from a larger vector into a smaller one, in which we do an extract instead. Co-authored-by: Luke Lau [email protected] Co-authored-by: Philip Reames [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the
matchSplatAsGatherfunction so we can handle vectors of different sizes. The goal is to improve the code gen for@llvm.experimental.vector.matchon RISCV.Currently, we use a scalar extract and splat instead of
vrgather, and the patch changes that.