[llvm-debuginfo-analyzer] Remove superfluous link components. #118052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As 'LLVM_TARGETS_TO_BUILD' control which targets are enabled, the lines: AllTargetsDescs AllTargetsDisassemblers AllTargetsInfos are redundant.
CarlosAlbertoEnciso
requested review from
nico,
jmorse,
SLTozer,
OCHyams and
pogo59
|
@llvm/pr-subscribers-debuginfo Author: Carlos Alberto Enciso (CarlosAlbertoEnciso) ChangesAs 'LLVM_TARGETS_TO_BUILD' control which targets are enabled, the lines: AllTargetsDescs are redundant. Full diff: https://github.com/llvm/llvm-project/pull/118052.diff 1 Files Affected:
diff --git a/llvm/unittests/DebugInfo/LogicalView/CMakeLists.txt b/llvm/unittests/DebugInfo/LogicalView/CMakeLists.txt
index 921453ccef6fd7..42a4b72229483c 100644
--- a/llvm/unittests/DebugInfo/LogicalView/CMakeLists.txt
+++ b/llvm/unittests/DebugInfo/LogicalView/CMakeLists.txt
@@ -1,8 +1,5 @@
set(LLVM_LINK_COMPONENTS
${LLVM_TARGETS_TO_BUILD}
- AllTargetsDescs
- AllTargetsDisassemblers
- AllTargetsInfos
AsmPrinter
DebugInfoDWARF
DebugInfoLogicalView
|
|
@llvm/pr-subscribers-llvm-binary-utilities Author: Carlos Alberto Enciso (CarlosAlbertoEnciso) ChangesAs 'LLVM_TARGETS_TO_BUILD' control which targets are enabled, the lines: AllTargetsDescs are redundant. Full diff: https://github.com/llvm/llvm-project/pull/118052.diff 1 Files Affected:
diff --git a/llvm/unittests/DebugInfo/LogicalView/CMakeLists.txt b/llvm/unittests/DebugInfo/LogicalView/CMakeLists.txt
index 921453ccef6fd7..42a4b72229483c 100644
--- a/llvm/unittests/DebugInfo/LogicalView/CMakeLists.txt
+++ b/llvm/unittests/DebugInfo/LogicalView/CMakeLists.txt
@@ -1,8 +1,5 @@
set(LLVM_LINK_COMPONENTS
${LLVM_TARGETS_TO_BUILD}
- AllTargetsDescs
- AllTargetsDisassemblers
- AllTargetsInfos
AsmPrinter
DebugInfoDWARF
DebugInfoLogicalView
|
CarlosAlbertoEnciso
added
the
skip-precommit-approval
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/64/builds/1581 Here is the relevant piece of the build log for the reference |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As 'LLVM_TARGETS_TO_BUILD' control which targets are enabled, the lines:
AllTargetsDescs
AllTargetsDisassemblers
AllTargetsInfos
are redundant.