Skip to content

[lld] Convert CODE_OWNERS.txt to Maintainers.md #118084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

DavidSpickett
Copy link
Collaborator

@DavidSpickett DavidSpickett commented Nov 29, 2024

To align with https://llvm.org/docs/DeveloperPolicy.html#maintainers

I've moved the file and changed it to markdown to match llvm/'s file.

To align with https://llvm.org/docs/DeveloperPolicy.html#maintainers

No format changes, I just want each sub-project to have a
`Maintainers.*` file so they are easy to find.
@llvmbot llvmbot added the lld label Nov 29, 2024
@llvmbot
Copy link
Member

llvmbot commented Nov 29, 2024

@llvm/pr-subscribers-lld

Author: David Spickett (DavidSpickett)

Changes

To align with https://llvm.org/docs/DeveloperPolicy.html#maintainers

No format changes, I just want each sub-project to have a Maintainers.* file so they are easy to find.


Full diff: https://github.com/llvm/llvm-project/pull/118084.diff

2 Files Affected:

  • (renamed) lld/Maintainers.txt ()
  • (modified) llvm/Maintainers.md (+1-1)
diff --git a/lld/CODE_OWNERS.TXT b/lld/Maintainers.txt
similarity index 100%
rename from lld/CODE_OWNERS.TXT
rename to lld/Maintainers.txt
diff --git a/llvm/Maintainers.md b/llvm/Maintainers.md
index 9744aa1aa43be9..0b596dfef2e15c 100644
--- a/llvm/Maintainers.md
+++ b/llvm/Maintainers.md
@@ -434,7 +434,7 @@ Others only have a lead maintainer listed here.
 
 [Flang maintainers](https://github.com/llvm/llvm-project/blob/main/flang/Maintainers.txt)
 
-[LLD maintainers](https://github.com/llvm/llvm-project/blob/main/lld/CODE_OWNERS.TXT)
+[LLD maintainers](https://github.com/llvm/llvm-project/blob/main/lld/Maintainers.txt)
 
 [LLDB maintainers](https://github.com/llvm/llvm-project/blob/main/lldb/Maintainers.rst)
 

@MaskRay
Copy link
Member

MaskRay commented Nov 29, 2024

Thanks:) Can you do us a favor and convert the .txt to .md or .rst?

@DavidSpickett DavidSpickett changed the title [lld] Move CODE_OWNERS.txt to Maintainers.txt [lld] Convert CODE_OWNERS.txt to Maintainers.md Dec 2, 2024
@DavidSpickett
Copy link
Collaborator Author

Thanks:) Can you do us a favor and convert the .txt to .md or .rst?

Done.

@DavidSpickett DavidSpickett merged commit 6292327 into llvm:main Dec 3, 2024
8 checks passed
@DavidSpickett DavidSpickett deleted the lld-maintainers branch December 3, 2024 11:44
@llvm-ci
Copy link
Collaborator

llvm-ci commented Dec 3, 2024

LLVM Buildbot has detected a new failure on builder openmp-offload-libc-amdgpu-runtime running on omp-vega20-1 while building lld,llvm at step 6 "test-openmp".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/9509

Here is the relevant piece of the build log for the reference
Step 6 (test-openmp) failure: test (failure)
******************** TEST 'libomp :: tasking/issue-94260-2.c' FAILED ********************
Exit Code: -11

Command Output (stdout):
--
# RUN: at line 1
/home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/./bin/clang -fopenmp   -I /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -I /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/openmp/runtime/test -L /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/openmp/runtime/src  -fno-omit-frame-pointer -I /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/openmp/runtime/test/ompt /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/openmp/runtime/test/tasking/issue-94260-2.c -o /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/openmp/runtime/test/tasking/Output/issue-94260-2.c.tmp -lm -latomic && /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/openmp/runtime/test/tasking/Output/issue-94260-2.c.tmp
# executed command: /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/./bin/clang -fopenmp -I /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -I /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/openmp/runtime/test -L /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/openmp/runtime/src -fno-omit-frame-pointer -I /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/openmp/runtime/test/ompt /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.src/openmp/runtime/test/tasking/issue-94260-2.c -o /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/openmp/runtime/test/tasking/Output/issue-94260-2.c.tmp -lm -latomic
# executed command: /home/ompworker/bbot/openmp-offload-libc-amdgpu-runtime/llvm.build/runtimes/runtimes-bins/openmp/runtime/test/tasking/Output/issue-94260-2.c.tmp
# note: command had no output on stdout or stderr
# error: command failed with exit status: -11

--

********************


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants