Skip to content

[libc++] Remove obsolete CMake variable #118119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

ldionne
Copy link
Member

@ldionne ldionne commented Nov 29, 2024

That variable is not referenced anywhere anymore, so it can be removed.

That variable is not referenced anywhere anymore, so it can be removed.
@ldionne ldionne requested a review from a team as a code owner November 29, 2024 17:57
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Nov 29, 2024
@llvmbot
Copy link
Member

llvmbot commented Nov 29, 2024

@llvm/pr-subscribers-libcxx

Author: Louis Dionne (ldionne)

Changes

That variable is not referenced anywhere anymore, so it can be removed.


Full diff: https://github.com/llvm/llvm-project/pull/118119.diff

1 Files Affected:

  • (modified) libcxx/src/CMakeLists.txt (-2)
diff --git a/libcxx/src/CMakeLists.txt b/libcxx/src/CMakeLists.txt
index 6d60fa11bf1d20..41ab8cad5b7da8 100644
--- a/libcxx/src/CMakeLists.txt
+++ b/libcxx/src/CMakeLists.txt
@@ -1,5 +1,3 @@
-set(LIBCXX_LIB_CMAKEFILES_DIR "${CMAKE_CURRENT_BINARY_DIR}${CMAKE_FILES_DIRECTORY}"  PARENT_SCOPE)
-
 # Get sources
 set(LIBCXX_SOURCES
   algorithm.cpp

@ldionne ldionne merged commit 02eaeec into llvm:main Dec 2, 2024
61 of 64 checks passed
@ldionne ldionne deleted the review/remove-obsolete-cmake-variable branch December 2, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants