Fixes #118231: Corrected spelling mistake in has_acitive_owner function #118266
Conversation
Your org has enabled the Graphite merge queue for merging into mainAdd the label “FP Bundles” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
|
@llvm/pr-subscribers-libc Author: Shankhin (firestrike007) Changes
Full diff: https://github.com/llvm/llvm-project/pull/118266.diff 1 Files Affected:
diff --git a/libc/src/__support/threads/linux/rwlock.h b/libc/src/__support/threads/linux/rwlock.h
index 57fcc7bb67a6a0..f7aeb5b709aa3e 100644
--- a/libc/src/__support/threads/linux/rwlock.h
+++ b/libc/src/__support/threads/linux/rwlock.h
@@ -162,7 +162,7 @@ class RwState {
LIBC_INLINE constexpr bool has_active_reader() const {
return state >= ACTIVE_READER_COUNT_UNIT;
}
- LIBC_INLINE constexpr bool has_acitve_owner() const {
+ LIBC_INLINE constexpr bool has_active_owner() const {
return has_active_reader() || has_active_writer();
}
LIBC_INLINE constexpr bool has_last_reader() const {
@@ -193,7 +193,7 @@ class RwState {
}
__builtin_unreachable();
} else
- return !has_acitve_owner();
+ return !has_active_owner();
}
// This function check if it is possible to grow the reader count without
@@ -548,7 +548,7 @@ class RwLock {
[[nodiscard]]
LIBC_INLINE LockResult check_for_destroy() {
RwState old = RwState::load(state, cpp::MemoryOrder::RELAXED);
- if (old.has_acitve_owner())
+ if (old.has_active_owner())
return LockResult::Busy;
return LockResult::Success;
}
|
|
@firestrike007 Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR. Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues. How to do this, and the rest of the post-merge process, is covered in detail here. If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again. If you don't get any reports, no action is required from you. Your changes are working as expected, well done! |
|
Thx, LGTM. |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/171/builds/11371 Here is the relevant piece of the build log for the reference |
|
Thanks for the fix. Nevermind the above CI report. We had some code land over the Thanksgiving holidays that made our CI flaky. |
Fixes #118231
has_active_ownerinllvm-project/libc/src/__support/threads/linux/rwlock.hcheck-llvm-unitcheck-all