Skip to content

[AVR] Simplify eocoding of load/store instructions #118279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

benshi001
Copy link
Member

Fixes #113774

@benshi001 benshi001 requested a review from aykevl December 2, 2024 09:51
Copy link

graphite-app bot commented Dec 2, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “FP Bundles” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@benshi001 benshi001 requested a review from jacquesguan December 2, 2024 09:53
@benshi001
Copy link
Member Author

benshi001 commented Dec 2, 2024

@Patryk27 Could you please also have a look? I can not add you to the reviewers. You are appreciated to add by yourself.

Copy link
Contributor

@jacquesguan jacquesguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Patryk27
Copy link
Contributor

Patryk27 commented Dec 4, 2024

@Patryk27 Could you please also have a look? I can not add you to the reviewers. You are appreciated to add by yourself.

Sure, will do later! I can't add myself to the reviewers neither, though 🤔

@benshi001 benshi001 merged commit dba0861 into llvm:main Dec 5, 2024
9 checks passed
@benshi001 benshi001 deleted the avr-asm branch December 5, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[AVR] AsmParser doesn't reject bad asm, again
3 participants