[libclc] Add Maintainers.md for libclc #118309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
libc++
DavidSpickett
requested review from
nikic,
ldionne and
tstellar
and removed request for
a team
|
@llvm/pr-subscribers-libcxx Author: David Spickett (DavidSpickett) ChangesThis adds Maintainers.md files to the sub-projects mentioned here, so that someone going directly to that sub-project will find them more easily. Recently I needed to find a libclc maintainer and I had no idea there was one listed here instead of in libclc/. Full diff: https://github.com/llvm/llvm-project/pull/118309.diff 5 Files Affected:
diff --git a/libclc/Maintainers.md b/libclc/Maintainers.md
new file mode 100644
index 00000000000000..314b139b81aaff
--- /dev/null
+++ b/libclc/Maintainers.md
@@ -0,0 +1,10 @@
+# libclc Maintainers
+
+This file is a list of the
+[maintainers](https://llvm.org/docs/DeveloperPolicy.html#maintainers) for
+libclc.
+
+# Lead maintainer
+
+Tom Stellard \
+[email protected] (email), [tstellar](https://github.com/tstellar) (GitHub)
\ No newline at end of file
diff --git a/libcxx/Maintainers.md b/libcxx/Maintainers.md
new file mode 100644
index 00000000000000..2630ed9001119b
--- /dev/null
+++ b/libcxx/Maintainers.md
@@ -0,0 +1,10 @@
+# libc++ Maintainers
+
+This file is a list of the
+[maintainers](https://llvm.org/docs/DeveloperPolicy.html#maintainers) for
+libc++.
+
+# Lead maintainer
+
+Louis Dionne \
+[email protected] (email), [ldionne](https://github.com/ldionne) (GitHub)
\ No newline at end of file
diff --git a/llvm/Maintainers.md b/llvm/Maintainers.md
index c5f98f76bda312..bb05552461b21c 100644
--- a/llvm/Maintainers.md
+++ b/llvm/Maintainers.md
@@ -422,7 +422,6 @@ [email protected] (email), [gkistanova](https://github.com/gkistanova) (GitHu
### Other subprojects
Some subprojects maintain their own list of per-component maintainers.
-Others only have a lead maintainer listed here.
[Bolt maintainers](https://github.com/llvm/llvm-project/blob/main/bolt/Maintainers.txt)
@@ -434,29 +433,17 @@ Others only have a lead maintainer listed here.
[Flang maintainers](https://github.com/llvm/llvm-project/blob/main/flang/Maintainers.txt)
-[LLD maintainers](https://github.com/llvm/llvm-project/blob/main/lld/CODE_OWNERS.TXT)
-
-[LLDB maintainers](https://github.com/llvm/llvm-project/blob/main/lldb/Maintainers.rst)
-
-#### libc++
-
-Louis Dionne \
-[email protected] (email), [ldionne](https://github.com/ldionne) (GitHub)
+[libc++ maintainers](https://github.com/llvm/llvm-project/blob/main/libcxx/Maintainers.rst)
-#### libclc
+[libclc maintainers](https://github.com/llvm/llvm-project/blob/main/libclc/Maintainers.rst)
-Tom Stellard \
-[email protected] (email), [tstellar](https://github.com/tstellar) (GitHub)
-
-#### OpenMP (runtime library)
+[LLD maintainers](https://github.com/llvm/llvm-project/blob/main/lld/CODE_OWNERS.TXT)
-Andrey Churbanov \
-[email protected] (email), [AndreyChurbanov](https://github.com/AndreyChurbanov) (GitHub)
+[LLDB maintainers](https://github.com/llvm/llvm-project/blob/main/lldb/Maintainers.rst)
-#### Polly
+[LLVM OpenMP Library maintainers](https://github.com/llvm/llvm-project/blob/main/openmp/Maintainers.rst)
-Tobias Grosser \
-[email protected] (email), [tobiasgrosser](https://github.com/tobiasgrosser) (GitHub)
+[Polly maintainers](https://github.com/llvm/llvm-project/blob/main/polly/Maintainers.rst)
## Inactive Maintainers
diff --git a/openmp/Maintainers.md b/openmp/Maintainers.md
new file mode 100644
index 00000000000000..fc49c9e35928b9
--- /dev/null
+++ b/openmp/Maintainers.md
@@ -0,0 +1,10 @@
+# LLVM OpenMP Library Maintainers
+
+This file is a list of the
+[maintainers](https://llvm.org/docs/DeveloperPolicy.html#maintainers) for
+the LLVM OpenMP library.
+
+# Lead maintainer
+
+Andrey Churbanov \
+[email protected] (email), [AndreyChurbanov](https://github.com/AndreyChurbanov) (GitHub)
\ No newline at end of file
diff --git a/polly/Maintainers.md b/polly/Maintainers.md
new file mode 100644
index 00000000000000..6c0ecef0f281a9
--- /dev/null
+++ b/polly/Maintainers.md
@@ -0,0 +1,10 @@
+# Polly Maintainers
+
+This file is a list of the
+[maintainers](https://llvm.org/docs/DeveloperPolicy.html#maintainers) for
+Polly.
+
+# Lead maintainer
+
+Tobias Grosser \
+[email protected] (email), [tobiasgrosser](https://github.com/tobiasgrosser) (GitHub)
\ No newline at end of file
|
|
(because for some reason I can't add you as a reviewer directly) |
nikic
reviewed
Dec 2, 2024
There was a problem hiding this comment.
Looks reasonable to me.
We might want to use this chance to also get the information up to date...
I think for polly this should probably be @tobiasgrosser -> @Meinersbur.
For libclc maybe @tstellar -> @frasercrmck (or maybe both).
|
For openmp I'm not really sure, maybe @jdoerfert or @jpeyton52 can advise. |
I'm not opposed to this if people think it suitable. But having someone from Red Hat or AMD as co-maintainer(s) makes sense to me, as it's a project used (downstream) by several different groups. |
|
It already landed, I'll rebase this PR. |
|
OpenMP part pushed directly: 2137ded |
DavidSpickett
force-pushed
the
maintainers-files
branch
from
5912070 to
fe59fcd
Compare
ldionne
approved these changes
Dec 6, 2024
DavidSpickett
force-pushed
the
maintainers-files
branch
from
fe59fcd to
8398d47
Compare
|
Libcxx part pushed as 1bdb0a4. |
ldionne
removed
the
libc++
DavidSpickett
added
polly
libclc
|
Sure, this works for me. Thank you @Meinersbur for all your work here. I am happy to help out if this is useful. |
|
@tobiasgrosser and me already had talked about this at an LLVM conference. I didn't push the maintainer change yet because I am myself somewhat slow with reviews, but I think it makes sense. |
DavidSpickett
force-pushed
the
maintainers-files
branch
from
8398d47 to
64bfb1c
Compare
DavidSpickett
changed the title
|
Polly pushed in 788d5a5. Only libclc remains. |
DavidSpickett
force-pushed
the
maintainers-files
branch
from
64bfb1c to
4056e18
Compare
|
Updated to list @frasercrmck and @tstellar for libclc. Tell me if that works for now, perhaps you can sort out any additions later. |
|
This looks fine. |
tstellar
approved these changes
Jan 3, 2025
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/198/builds/865 Here is the relevant piece of the build log for the reference |
paulhuggett
pushed a commit
to paulhuggett/llvm-project
that referenced
this pull request
Jan 7, 2025
This adds a Maintainers.md files to libclc. Recently I needed to find a libclc maintainer and I had no idea there was one listed in llvm/ instead of in libclc/.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a Maintainers.md files to libclc. Recently I needed to find a libclc maintainer and I had no idea there was one listed in llvm/ instead of in libclc/.