Skip to content

[MLIR][TOSA] Update CustomOp input and output names #118408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

Jerry-Ge
Copy link
Member

@Jerry-Ge Jerry-Ge commented Dec 2, 2024

Update input name from input to input_list
Update output name from outputs to output_list

To match specification: https://www.mlplatform.org/tosa/tosa_spec.html#_custom

@llvmbot
Copy link
Member

llvmbot commented Dec 2, 2024

@llvm/pr-subscribers-mlir-tosa

@llvm/pr-subscribers-mlir

Author: Jerry-Ge (Jerry-Ge)

Changes

Update input name from input to input_list
Update output name from outputs to output_list

To match specification: https://www.mlplatform.org/tosa/tosa_spec.html#_custom


Full diff: https://github.com/llvm/llvm-project/pull/118408.diff

1 Files Affected:

  • (modified) mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td (+2-2)
diff --git a/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td b/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td
index 9f57efff5d1fd2..1c4dac521a7a22 100644
--- a/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td
+++ b/mlir/include/mlir/Dialect/Tosa/IR/TosaOps.td
@@ -2010,11 +2010,11 @@ def Tosa_CustomOp : Tosa_Op<"custom"> {
     StrAttr:$operator_name,
     StrAttr:$domain_name,
     StrAttr:$implementation_attrs,
-    Variadic<Tosa_Tensor>:$inputs
+    Variadic<Tosa_Tensor>:$input_list
   );
 
   let results = (outs
-    Variadic<Tosa_Tensor>:$outputs
+    Variadic<Tosa_Tensor>:$output_list
   );
 
   let assemblyFormat = "operands attr-dict `:` functional-type(operands, results)";

@joker-eph joker-eph changed the title Update CustomOp's dialect input and output names [MLIR][TOSA] Update CustomOp input and output names Dec 3, 2024
@CoTinker CoTinker requested a review from eric-k256 December 3, 2024 06:54
Copy link
Contributor

@CoTinker CoTinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

little comment.

@GeorgeARM
Copy link
Contributor

LGTM, will approve and merge once @CoTinker's comment has been addressed.

Update input name from input to input_list
Update output name from outputs to output_list

Signed-off-by: Jerry Ge <[email protected]>
Copy link
Contributor

@CoTinker CoTinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@GeorgeARM GeorgeARM merged commit 03aae4f into llvm:main Dec 4, 2024
8 checks passed
@Jerry-Ge Jerry-Ge deleted the OpCustom branch February 19, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants