Skip to content

[lldb][NFC] Remove unused field Platform::m_remote_url #118411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

bulbazord
Copy link
Member

@bulbazord bulbazord commented Dec 2, 2024

@llvmbot
Copy link
Member

llvmbot commented Dec 2, 2024

@llvm/pr-subscribers-lldb

Author: Alex Langford (bulbazord)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/118411.diff

1 Files Affected:

  • (modified) lldb/include/lldb/Target/Platform.h (-3)
diff --git a/lldb/include/lldb/Target/Platform.h b/lldb/include/lldb/Target/Platform.h
index 920f80bc733174..f8a2cbf0d5d049 100644
--- a/lldb/include/lldb/Target/Platform.h
+++ b/lldb/include/lldb/Target/Platform.h
@@ -473,8 +473,6 @@ class Platform : public PluginInterface {
                       LLVM_PRETTY_FUNCTION, GetName()));
   }
 
-  const std::string &GetRemoteURL() const { return m_remote_url; }
-
   bool IsHost() const {
     return m_is_host; // Is this the default host platform?
   }
@@ -977,7 +975,6 @@ class Platform : public PluginInterface {
   std::string m_sdk_build;
   FileSpec m_working_dir; // The working directory which is used when installing
                           // modules that have no install path set
-  std::string m_remote_url;
   std::string m_hostname;
   llvm::VersionTuple m_os_version;
   ArchSpec

Copy link
Member

@medismailben medismailben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to be used anywhere. LGTM!

Copy link
Member

@JDevlieghere JDevlieghere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@bulbazord bulbazord merged commit 0ca8a59 into llvm:main Dec 3, 2024
9 checks passed
@bulbazord bulbazord deleted the platform-remote-url-unused branch December 3, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants