FunctionDecl::getFunctionTypeLoc: ignore function type attributes #118420
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
v01dXYZ
force-pushed
the
clang-func-decl-get-func-type-loc-when-func-attributes
branch
from
c7e93d1 to
b6f0130
Compare
AaronBallman
reviewed
Dec 3, 2024
clang/lib/AST/Decl.cpp
Outdated
|
|
||
| TypeLoc TL = TSI->getTypeLoc().IgnoreParens(); | ||
|
|
||
| // ignore function type attributes |
There was a problem hiding this comment.
Are there other sugars we need to ignore? e.g., a ParenType via:
void (foo)(int f) {}
There was a problem hiding this comment.
I don't know. But to implement it in its updated form, I mimicked getAsAdjusted. So currently, it supports ParenType and AttributedType. I think I should add MacroQualifiedType for example.
erichkeane
reviewed
Dec 3, 2024
clang/lib/AST/Decl.cpp
Outdated
|
|
||
| // ignore function type attributes | ||
| while (auto ATL = TL.getAs<AttributedTypeLoc>()) | ||
| TL = ATL.getModifiedLoc(); |
There was a problem hiding this comment.
I don't THINK we want this? We want to keep around the 'type' as modified by the attributed type (so if it is no_return, we want to make sure we have a noreturn function type for example). So I would think we would want the Equivalent type here?
There was a problem hiding this comment.
Glad I've made this error. I'll start by adding your example as a test.
erichkeane
reviewed
Dec 3, 2024
erichkeane
approved these changes
Dec 9, 2024
added 2 commits
December 11, 2024 14:32
|
I've got to squash and reword the commits. Also, I'll add a line to the release stating now FunctionDecl getFunctionTypeLoc/getReturrnLoc now supports AnnotatedTypes. |
added 2 commits
December 13, 2024 01:35
llvmbot
added
clang
|
@llvm/pr-subscribers-clang Author: Robert Dazi (v01dXYZ) ChangesRelated to #118290. Full diff: https://github.com/llvm/llvm-project/pull/118420.diff 3 Files Affected:
diff --git a/clang-tools-extra/clangd/unittests/InlayHintTests.cpp b/clang-tools-extra/clangd/unittests/InlayHintTests.cpp
index 77d78b8777fe30..030e4995777060 100644
--- a/clang-tools-extra/clangd/unittests/InlayHintTests.cpp
+++ b/clang-tools-extra/clangd/unittests/InlayHintTests.cpp
@@ -1577,19 +1577,21 @@ TEST(TypeHints, Aliased) {
}
TEST(TypeHints, CallingConvention) {
- // Check that we don't crash for lambdas without a FunctionTypeLoc
+ // Check that we don't crash for lambdas with an annotation
// https://github.com/clangd/clangd/issues/2223
- std::string Code = R"cpp(
+ Annotations Source(R"cpp(
void test() {
- []() __cdecl {};
+ []($lambda[[)]]__cdecl {};
}
- )cpp";
- TestTU TU = TestTU::withCode(Code);
+ )cpp");
+ TestTU TU = TestTU::withCode(Source.code());
TU.ExtraArgs.push_back("--target=x86_64-w64-mingw32");
TU.PredefineMacros = true; // for the __cdecl
auto AST = TU.build();
- EXPECT_THAT(hintsOfKind(AST, InlayHintKind::Type), IsEmpty());
+ EXPECT_THAT(
+ hintsOfKind(AST, InlayHintKind::Type),
+ ElementsAre(HintMatcher(ExpectedHint{"-> void", "lambda"}, Source)));
}
TEST(TypeHints, Decltype) {
diff --git a/clang/lib/AST/Decl.cpp b/clang/lib/AST/Decl.cpp
index 741e908cf9bc56..dcc2240c599b9c 100644
--- a/clang/lib/AST/Decl.cpp
+++ b/clang/lib/AST/Decl.cpp
@@ -3876,8 +3876,25 @@ bool FunctionDecl::doesDeclarationForceExternallyVisibleDefinition() const {
FunctionTypeLoc FunctionDecl::getFunctionTypeLoc() const {
const TypeSourceInfo *TSI = getTypeSourceInfo();
- return TSI ? TSI->getTypeLoc().IgnoreParens().getAs<FunctionTypeLoc>()
- : FunctionTypeLoc();
+
+ if (!TSI)
+ return FunctionTypeLoc();
+
+ TypeLoc TL = TSI->getTypeLoc();
+ FunctionTypeLoc FTL;
+
+ while (!(FTL = TL.getAs<FunctionTypeLoc>())) {
+ if (const auto PTL = TL.getAs<ParenTypeLoc>())
+ TL = PTL.getInnerLoc();
+ else if (const auto ATL = TL.getAs<AttributedTypeLoc>())
+ TL = ATL.getEquivalentTypeLoc();
+ else if (const auto MQTL = TL.getAs<MacroQualifiedTypeLoc>())
+ TL = MQTL.getInnerLoc();
+ else
+ break;
+ }
+
+ return FTL;
}
SourceRange FunctionDecl::getReturnTypeSourceRange() const {
diff --git a/clang/unittests/AST/AttrTest.cpp b/clang/unittests/AST/AttrTest.cpp
index 46c3f5729021ec..3be362895b77e8 100644
--- a/clang/unittests/AST/AttrTest.cpp
+++ b/clang/unittests/AST/AttrTest.cpp
@@ -86,6 +86,23 @@ TEST(Attr, AnnotateType) {
struct S { int mem; };
int [[clang::annotate_type("int")]]
S::* [[clang::annotate_type("ptr_to_mem")]] ptr_to_member = &S::mem;
+
+ // Function Type Attributes
+ __attribute__((noreturn)) int f_noreturn();
+ __attribute__((preserve_most)) int f_cc_preserve_most();
+
+ #define PRESERVE_MOST __attribute__((preserve_most))
+ PRESERVE_MOST int f_macro_attribue();
+
+ int (__attribute__((preserve_most)) f_paren_attribute)();
+
+ int (
+ PRESERVE_MOST
+ (
+ __attribute__((warn_unused_result))
+ (f_w_paren_and_attr)
+ )
+ ) ();
)cpp");
{
@@ -153,6 +170,67 @@ TEST(Attr, AnnotateType) {
EXPECT_EQ(IntTL.getType(), AST->getASTContext().IntTy);
}
+ {
+ const FunctionDecl *Func = getFunctionNode(AST.get(), "f_noreturn");
+ const FunctionTypeLoc FTL = Func->getFunctionTypeLoc();
+ const FunctionType *FT = FTL.getTypePtr();
+
+ EXPECT_TRUE(FT->getNoReturnAttr());
+ }
+
+ {
+ const FunctionDecl *Func = getFunctionNode(AST.get(), "f_cc_preserve_most");
+ const FunctionTypeLoc FTL = Func->getFunctionTypeLoc();
+ const FunctionType *FT = FTL.getTypePtr();
+
+ EXPECT_TRUE(FT->getCallConv() == CC_PreserveMost);
+ }
+
+ {
+ for (auto should_have_func_type_loc : {
+ "f_macro_attribue",
+ "f_paren_attribute",
+ "f_w_paren_and_attr",
+ }) {
+ llvm::errs() << "O: " << should_have_func_type_loc << "\n";
+ const FunctionDecl *Func =
+ getFunctionNode(AST.get(), should_have_func_type_loc);
+
+ EXPECT_TRUE(Func->getFunctionTypeLoc());
+ }
+ }
+
+ // The following test verifies getFunctionTypeLoc returns a type
+ // which takes into account the attribute (instead of only the nake
+ // type).
+ //
+ // This is hard to do with C/C++ because it seems using a function
+ // type attribute with a C/C++ function declaration only results
+ // with either:
+ //
+ // 1. It does NOT produce any AttributedType (for example it only
+ // sets one flag of the FunctionType's ExtInfo, e.g. NoReturn).
+ // 2. It produces an AttributedType with modified type and
+ // equivalent type that are equal (for example, that's what
+ // happens with Calling Convention attributes).
+ //
+ // Fortunately, ObjC has one specific function type attribute that
+ // creates an AttributedType with different modified type and
+ // equivalent type.
+ auto AST_ObjC = buildASTFromCodeWithArgs(
+ R"objc(
+ __attribute__((ns_returns_retained)) id f();
+ )objc",
+ {"-fobjc-arc", "-fsyntax-only", "-fobjc-runtime=macosx-10.7"},
+ "input.mm");
+ {
+ const FunctionDecl *f = getFunctionNode(AST_ObjC.get(), "f");
+ const FunctionTypeLoc FTL = f->getFunctionTypeLoc();
+
+ const FunctionType *FT = FTL.getTypePtr();
+ EXPECT_TRUE(FT->getExtInfo().getProducesResult());
+ }
+
// Test type annotation on an `__auto_type` type in C mode.
AST = buildASTFromCodeWithArgs(R"c(
__auto_type [[clang::annotate_type("auto")]] auto_var = 1;
|
|
@llvm/pr-subscribers-clang-tools-extra Author: Robert Dazi (v01dXYZ) ChangesRelated to #118290. Full diff: https://github.com/llvm/llvm-project/pull/118420.diff 3 Files Affected:
diff --git a/clang-tools-extra/clangd/unittests/InlayHintTests.cpp b/clang-tools-extra/clangd/unittests/InlayHintTests.cpp
index 77d78b8777fe30..030e4995777060 100644
--- a/clang-tools-extra/clangd/unittests/InlayHintTests.cpp
+++ b/clang-tools-extra/clangd/unittests/InlayHintTests.cpp
@@ -1577,19 +1577,21 @@ TEST(TypeHints, Aliased) {
}
TEST(TypeHints, CallingConvention) {
- // Check that we don't crash for lambdas without a FunctionTypeLoc
+ // Check that we don't crash for lambdas with an annotation
// https://github.com/clangd/clangd/issues/2223
- std::string Code = R"cpp(
+ Annotations Source(R"cpp(
void test() {
- []() __cdecl {};
+ []($lambda[[)]]__cdecl {};
}
- )cpp";
- TestTU TU = TestTU::withCode(Code);
+ )cpp");
+ TestTU TU = TestTU::withCode(Source.code());
TU.ExtraArgs.push_back("--target=x86_64-w64-mingw32");
TU.PredefineMacros = true; // for the __cdecl
auto AST = TU.build();
- EXPECT_THAT(hintsOfKind(AST, InlayHintKind::Type), IsEmpty());
+ EXPECT_THAT(
+ hintsOfKind(AST, InlayHintKind::Type),
+ ElementsAre(HintMatcher(ExpectedHint{"-> void", "lambda"}, Source)));
}
TEST(TypeHints, Decltype) {
diff --git a/clang/lib/AST/Decl.cpp b/clang/lib/AST/Decl.cpp
index 741e908cf9bc56..dcc2240c599b9c 100644
--- a/clang/lib/AST/Decl.cpp
+++ b/clang/lib/AST/Decl.cpp
@@ -3876,8 +3876,25 @@ bool FunctionDecl::doesDeclarationForceExternallyVisibleDefinition() const {
FunctionTypeLoc FunctionDecl::getFunctionTypeLoc() const {
const TypeSourceInfo *TSI = getTypeSourceInfo();
- return TSI ? TSI->getTypeLoc().IgnoreParens().getAs<FunctionTypeLoc>()
- : FunctionTypeLoc();
+
+ if (!TSI)
+ return FunctionTypeLoc();
+
+ TypeLoc TL = TSI->getTypeLoc();
+ FunctionTypeLoc FTL;
+
+ while (!(FTL = TL.getAs<FunctionTypeLoc>())) {
+ if (const auto PTL = TL.getAs<ParenTypeLoc>())
+ TL = PTL.getInnerLoc();
+ else if (const auto ATL = TL.getAs<AttributedTypeLoc>())
+ TL = ATL.getEquivalentTypeLoc();
+ else if (const auto MQTL = TL.getAs<MacroQualifiedTypeLoc>())
+ TL = MQTL.getInnerLoc();
+ else
+ break;
+ }
+
+ return FTL;
}
SourceRange FunctionDecl::getReturnTypeSourceRange() const {
diff --git a/clang/unittests/AST/AttrTest.cpp b/clang/unittests/AST/AttrTest.cpp
index 46c3f5729021ec..3be362895b77e8 100644
--- a/clang/unittests/AST/AttrTest.cpp
+++ b/clang/unittests/AST/AttrTest.cpp
@@ -86,6 +86,23 @@ TEST(Attr, AnnotateType) {
struct S { int mem; };
int [[clang::annotate_type("int")]]
S::* [[clang::annotate_type("ptr_to_mem")]] ptr_to_member = &S::mem;
+
+ // Function Type Attributes
+ __attribute__((noreturn)) int f_noreturn();
+ __attribute__((preserve_most)) int f_cc_preserve_most();
+
+ #define PRESERVE_MOST __attribute__((preserve_most))
+ PRESERVE_MOST int f_macro_attribue();
+
+ int (__attribute__((preserve_most)) f_paren_attribute)();
+
+ int (
+ PRESERVE_MOST
+ (
+ __attribute__((warn_unused_result))
+ (f_w_paren_and_attr)
+ )
+ ) ();
)cpp");
{
@@ -153,6 +170,67 @@ TEST(Attr, AnnotateType) {
EXPECT_EQ(IntTL.getType(), AST->getASTContext().IntTy);
}
+ {
+ const FunctionDecl *Func = getFunctionNode(AST.get(), "f_noreturn");
+ const FunctionTypeLoc FTL = Func->getFunctionTypeLoc();
+ const FunctionType *FT = FTL.getTypePtr();
+
+ EXPECT_TRUE(FT->getNoReturnAttr());
+ }
+
+ {
+ const FunctionDecl *Func = getFunctionNode(AST.get(), "f_cc_preserve_most");
+ const FunctionTypeLoc FTL = Func->getFunctionTypeLoc();
+ const FunctionType *FT = FTL.getTypePtr();
+
+ EXPECT_TRUE(FT->getCallConv() == CC_PreserveMost);
+ }
+
+ {
+ for (auto should_have_func_type_loc : {
+ "f_macro_attribue",
+ "f_paren_attribute",
+ "f_w_paren_and_attr",
+ }) {
+ llvm::errs() << "O: " << should_have_func_type_loc << "\n";
+ const FunctionDecl *Func =
+ getFunctionNode(AST.get(), should_have_func_type_loc);
+
+ EXPECT_TRUE(Func->getFunctionTypeLoc());
+ }
+ }
+
+ // The following test verifies getFunctionTypeLoc returns a type
+ // which takes into account the attribute (instead of only the nake
+ // type).
+ //
+ // This is hard to do with C/C++ because it seems using a function
+ // type attribute with a C/C++ function declaration only results
+ // with either:
+ //
+ // 1. It does NOT produce any AttributedType (for example it only
+ // sets one flag of the FunctionType's ExtInfo, e.g. NoReturn).
+ // 2. It produces an AttributedType with modified type and
+ // equivalent type that are equal (for example, that's what
+ // happens with Calling Convention attributes).
+ //
+ // Fortunately, ObjC has one specific function type attribute that
+ // creates an AttributedType with different modified type and
+ // equivalent type.
+ auto AST_ObjC = buildASTFromCodeWithArgs(
+ R"objc(
+ __attribute__((ns_returns_retained)) id f();
+ )objc",
+ {"-fobjc-arc", "-fsyntax-only", "-fobjc-runtime=macosx-10.7"},
+ "input.mm");
+ {
+ const FunctionDecl *f = getFunctionNode(AST_ObjC.get(), "f");
+ const FunctionTypeLoc FTL = f->getFunctionTypeLoc();
+
+ const FunctionType *FT = FTL.getTypePtr();
+ EXPECT_TRUE(FT->getExtInfo().getProducesResult());
+ }
+
// Test type annotation on an `__auto_type` type in C mode.
AST = buildASTFromCodeWithArgs(R"c(
__auto_type [[clang::annotate_type("auto")]] auto_var = 1;
|
|
@llvm/pr-subscribers-clangd Author: Robert Dazi (v01dXYZ) ChangesRelated to #118290. Full diff: https://github.com/llvm/llvm-project/pull/118420.diff 3 Files Affected:
diff --git a/clang-tools-extra/clangd/unittests/InlayHintTests.cpp b/clang-tools-extra/clangd/unittests/InlayHintTests.cpp
index 77d78b8777fe30..030e4995777060 100644
--- a/clang-tools-extra/clangd/unittests/InlayHintTests.cpp
+++ b/clang-tools-extra/clangd/unittests/InlayHintTests.cpp
@@ -1577,19 +1577,21 @@ TEST(TypeHints, Aliased) {
}
TEST(TypeHints, CallingConvention) {
- // Check that we don't crash for lambdas without a FunctionTypeLoc
+ // Check that we don't crash for lambdas with an annotation
// https://github.com/clangd/clangd/issues/2223
- std::string Code = R"cpp(
+ Annotations Source(R"cpp(
void test() {
- []() __cdecl {};
+ []($lambda[[)]]__cdecl {};
}
- )cpp";
- TestTU TU = TestTU::withCode(Code);
+ )cpp");
+ TestTU TU = TestTU::withCode(Source.code());
TU.ExtraArgs.push_back("--target=x86_64-w64-mingw32");
TU.PredefineMacros = true; // for the __cdecl
auto AST = TU.build();
- EXPECT_THAT(hintsOfKind(AST, InlayHintKind::Type), IsEmpty());
+ EXPECT_THAT(
+ hintsOfKind(AST, InlayHintKind::Type),
+ ElementsAre(HintMatcher(ExpectedHint{"-> void", "lambda"}, Source)));
}
TEST(TypeHints, Decltype) {
diff --git a/clang/lib/AST/Decl.cpp b/clang/lib/AST/Decl.cpp
index 741e908cf9bc56..dcc2240c599b9c 100644
--- a/clang/lib/AST/Decl.cpp
+++ b/clang/lib/AST/Decl.cpp
@@ -3876,8 +3876,25 @@ bool FunctionDecl::doesDeclarationForceExternallyVisibleDefinition() const {
FunctionTypeLoc FunctionDecl::getFunctionTypeLoc() const {
const TypeSourceInfo *TSI = getTypeSourceInfo();
- return TSI ? TSI->getTypeLoc().IgnoreParens().getAs<FunctionTypeLoc>()
- : FunctionTypeLoc();
+
+ if (!TSI)
+ return FunctionTypeLoc();
+
+ TypeLoc TL = TSI->getTypeLoc();
+ FunctionTypeLoc FTL;
+
+ while (!(FTL = TL.getAs<FunctionTypeLoc>())) {
+ if (const auto PTL = TL.getAs<ParenTypeLoc>())
+ TL = PTL.getInnerLoc();
+ else if (const auto ATL = TL.getAs<AttributedTypeLoc>())
+ TL = ATL.getEquivalentTypeLoc();
+ else if (const auto MQTL = TL.getAs<MacroQualifiedTypeLoc>())
+ TL = MQTL.getInnerLoc();
+ else
+ break;
+ }
+
+ return FTL;
}
SourceRange FunctionDecl::getReturnTypeSourceRange() const {
diff --git a/clang/unittests/AST/AttrTest.cpp b/clang/unittests/AST/AttrTest.cpp
index 46c3f5729021ec..3be362895b77e8 100644
--- a/clang/unittests/AST/AttrTest.cpp
+++ b/clang/unittests/AST/AttrTest.cpp
@@ -86,6 +86,23 @@ TEST(Attr, AnnotateType) {
struct S { int mem; };
int [[clang::annotate_type("int")]]
S::* [[clang::annotate_type("ptr_to_mem")]] ptr_to_member = &S::mem;
+
+ // Function Type Attributes
+ __attribute__((noreturn)) int f_noreturn();
+ __attribute__((preserve_most)) int f_cc_preserve_most();
+
+ #define PRESERVE_MOST __attribute__((preserve_most))
+ PRESERVE_MOST int f_macro_attribue();
+
+ int (__attribute__((preserve_most)) f_paren_attribute)();
+
+ int (
+ PRESERVE_MOST
+ (
+ __attribute__((warn_unused_result))
+ (f_w_paren_and_attr)
+ )
+ ) ();
)cpp");
{
@@ -153,6 +170,67 @@ TEST(Attr, AnnotateType) {
EXPECT_EQ(IntTL.getType(), AST->getASTContext().IntTy);
}
+ {
+ const FunctionDecl *Func = getFunctionNode(AST.get(), "f_noreturn");
+ const FunctionTypeLoc FTL = Func->getFunctionTypeLoc();
+ const FunctionType *FT = FTL.getTypePtr();
+
+ EXPECT_TRUE(FT->getNoReturnAttr());
+ }
+
+ {
+ const FunctionDecl *Func = getFunctionNode(AST.get(), "f_cc_preserve_most");
+ const FunctionTypeLoc FTL = Func->getFunctionTypeLoc();
+ const FunctionType *FT = FTL.getTypePtr();
+
+ EXPECT_TRUE(FT->getCallConv() == CC_PreserveMost);
+ }
+
+ {
+ for (auto should_have_func_type_loc : {
+ "f_macro_attribue",
+ "f_paren_attribute",
+ "f_w_paren_and_attr",
+ }) {
+ llvm::errs() << "O: " << should_have_func_type_loc << "\n";
+ const FunctionDecl *Func =
+ getFunctionNode(AST.get(), should_have_func_type_loc);
+
+ EXPECT_TRUE(Func->getFunctionTypeLoc());
+ }
+ }
+
+ // The following test verifies getFunctionTypeLoc returns a type
+ // which takes into account the attribute (instead of only the nake
+ // type).
+ //
+ // This is hard to do with C/C++ because it seems using a function
+ // type attribute with a C/C++ function declaration only results
+ // with either:
+ //
+ // 1. It does NOT produce any AttributedType (for example it only
+ // sets one flag of the FunctionType's ExtInfo, e.g. NoReturn).
+ // 2. It produces an AttributedType with modified type and
+ // equivalent type that are equal (for example, that's what
+ // happens with Calling Convention attributes).
+ //
+ // Fortunately, ObjC has one specific function type attribute that
+ // creates an AttributedType with different modified type and
+ // equivalent type.
+ auto AST_ObjC = buildASTFromCodeWithArgs(
+ R"objc(
+ __attribute__((ns_returns_retained)) id f();
+ )objc",
+ {"-fobjc-arc", "-fsyntax-only", "-fobjc-runtime=macosx-10.7"},
+ "input.mm");
+ {
+ const FunctionDecl *f = getFunctionNode(AST_ObjC.get(), "f");
+ const FunctionTypeLoc FTL = f->getFunctionTypeLoc();
+
+ const FunctionType *FT = FTL.getTypePtr();
+ EXPECT_TRUE(FT->getExtInfo().getProducesResult());
+ }
+
// Test type annotation on an `__auto_type` type in C mode.
AST = buildASTFromCodeWithArgs(R"c(
__auto_type [[clang::annotate_type("auto")]] auto_var = 1;
|
|
Clangd changes LGTM |
|
The comment doesn't seem to need any modifications (actually this patch makes the function behaves closer to the comment). |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/2/builds/22043 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/154/builds/15066 Here is the relevant piece of the build log for the reference |
|
Reverted as the test fails on non-x86 targets. Will fix and re-PR. |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/95/builds/12222 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/168/builds/11058 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/76/builds/8880 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/145/builds/6465 Here is the relevant piece of the build log for the reference |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/39/builds/5722 Here is the relevant piece of the build log for the reference |
resistor
added a commit
that referenced
this pull request
Apr 21, 2025
…pe attributes (#118420)" (#136484) Avoid using PreservesMost in the testcase as it is not supported on all targets. Original PR #118290. Co-authored-by: Robert Dazi <[email protected]> Co-authored-by: v01dxyz <[email protected]>
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…vm#118420) Related to llvm#118290. --------- Co-authored-by: v01dxyz <[email protected]> Co-authored-by: Owen Anderson <[email protected]>
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…utes (llvm#118420)" This reverts commit 19c708c because it caused test failures on non-x86 targets.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…pe attributes (llvm#118420)" (llvm#136484) Avoid using PreservesMost in the testcase as it is not supported on all targets. Original PR llvm#118290. Co-authored-by: Robert Dazi <[email protected]> Co-authored-by: v01dxyz <[email protected]>
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…vm#118420) Related to llvm#118290. --------- Co-authored-by: v01dxyz <[email protected]> Co-authored-by: Owen Anderson <[email protected]>
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…utes (llvm#118420)" This reverts commit 19c708c because it caused test failures on non-x86 targets.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…pe attributes (llvm#118420)" (llvm#136484) Avoid using PreservesMost in the testcase as it is not supported on all targets. Original PR llvm#118290. Co-authored-by: Robert Dazi <[email protected]> Co-authored-by: v01dxyz <[email protected]>
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…vm#118420) Related to llvm#118290. --------- Co-authored-by: v01dxyz <[email protected]> Co-authored-by: Owen Anderson <[email protected]>
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…utes (llvm#118420)" This reverts commit 19c708c because it caused test failures on non-x86 targets.
IanWood1
pushed a commit
to IanWood1/llvm-project
that referenced
this pull request
May 6, 2025
…pe attributes (llvm#118420)" (llvm#136484) Avoid using PreservesMost in the testcase as it is not supported on all targets. Original PR llvm#118290. Co-authored-by: Robert Dazi <[email protected]> Co-authored-by: v01dxyz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #118290.