Skip to content

Make the CHECK lines here resistent to chandlerc #118736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

chandlerc
Copy link
Member

Specifically, usernames containing handle, such as chandlerc, often end up in paths, including the path of this test file which contains the word overflow. Combined, they create a match for handle.*overflow in the filename on my system (but likely not many others), leading this test to mysteriously fail for unfortunate usernames like mine. =D

No discussion of the amount of time I spent debugging this please. =[

Specifically, usernames containing `handle`, such as `chandlerc`, often
end up in paths, including the path of this test file which contains the
word `overflow`. Combined, they create a match for `handle.*overflow` in
the filename on my system (but likely not many others), leading this
test to mysteriously fail for unfortunate usernames like mine. =D

No discussion of the amount of time I spent debugging this please. =[
@llvmbot llvmbot added the clang Clang issues not falling into any other category label Dec 5, 2024
@llvmbot
Copy link
Member

llvmbot commented Dec 5, 2024

@llvm/pr-subscribers-clang

Author: Chandler Carruth (chandlerc)

Changes

Specifically, usernames containing handle, such as chandlerc, often end up in paths, including the path of this test file which contains the word overflow. Combined, they create a match for handle.*overflow in the filename on my system (but likely not many others), leading this test to mysteriously fail for unfortunate usernames like mine. =D

No discussion of the amount of time I spent debugging this please. =[


Full diff: https://github.com/llvm/llvm-project/pull/118736.diff

1 Files Affected:

  • (modified) clang/test/CodeGen/ignore-overflow-pattern.c (+3)
diff --git a/clang/test/CodeGen/ignore-overflow-pattern.c b/clang/test/CodeGen/ignore-overflow-pattern.c
index c4a9d07b07aaac..4e5ed82d7967ec 100644
--- a/clang/test/CodeGen/ignore-overflow-pattern.c
+++ b/clang/test/CodeGen/ignore-overflow-pattern.c
@@ -21,7 +21,10 @@
 // unsigned negation, for example:
 // unsigned long A = -1UL;
 
+// Skip over parts of the IR containing this file's name.
+// CHECK: source_filename = {{.*}}
 
+// Ensure we don't see anything about handling overflow before the tests below.
 // CHECK-NOT: handle{{.*}}overflow
 
 extern unsigned a, b, c;

@chandlerc chandlerc merged commit 1e5c1a3 into llvm:main Dec 5, 2024
10 checks passed
@chandlerc chandlerc deleted the fix-test-for-me branch December 5, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants