Skip to content

[lldb] Add synthetic formatter for llvm::Expected #118758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2024
Merged

[lldb] Add synthetic formatter for llvm::Expected #118758

merged 1 commit into from
Dec 6, 2024

Conversation

kastiglione
Copy link
Contributor

@kastiglione kastiglione commented Dec 5, 2024 •
edited
Loading

Adds a synthetic formatter for llvm::Expected<T>. The synthetic value will have a single child, either value or error.

jimingham
jimingham approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@jimingham jimingham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This will look natural in printing, and programmatically checking the child name to see if you have a value or an error is straightforward.

@kastiglione kastiglione merged commit 398f3b3 into llvm:main Dec 6, 2024
9 checks passed
@kastiglione kastiglione deleted the lldb-Add-synthetic-formatter-for-llvm-Expected branch December 6, 2024 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimingham jimingham jimingham approved these changes

@JDevlieghere JDevlieghere Awaiting requested review from JDevlieghere

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kastiglione @jimingham