[CodeGen][PM] Initialize analyses with isAnalysis=true #118779

optimisan · 2024-12-05T10:09:12Z

Analyses should be marked as analyses.

Otherwise they are prone to get ignored by the legacy analysis cache mechanism and get scheduled redundantly.

optimisan · 2024-12-05T10:09:24Z

[CodeGen][PM] Initialize analyses with isAnalysis=true #118779 👈 (View in Graphite)
[CodeGen][NewPM] Port LiveStacks analysis to NPM #118778
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

llvmbot · 2024-12-05T10:19:46Z

@llvm/pr-subscribers-llvm-regalloc
@llvm/pr-subscribers-llvm-transforms

@llvm/pr-subscribers-debuginfo

Author: Akshat Oke (optimisan)

Changes

Analyses should be marked as analyses.

Otherwise they are prone to get ignored by the legacy analysis cache mechanism and get scheduled redundantly.

Full diff: https://github.com/llvm/llvm-project/pull/118779.diff

8 Files Affected:

(modified) llvm/lib/CodeGen/GCMetadata.cpp (+1-1)
(modified) llvm/lib/CodeGen/LiveDebugVariables.cpp (+1-1)
(modified) llvm/lib/CodeGen/LiveIntervals.cpp (+1-1)
(modified) llvm/lib/CodeGen/LiveRegMatrix.cpp (+1-1)
(modified) llvm/lib/CodeGen/LiveStacks.cpp (+1-1)
(modified) llvm/lib/CodeGen/SlotIndexes.cpp (+1-1)
(modified) llvm/lib/CodeGen/VirtRegMap.cpp (+1-1)
(modified) llvm/lib/Transforms/Utils/LoopSimplify.cpp (+2-2)

diff --git a/llvm/lib/CodeGen/GCMetadata.cpp b/llvm/lib/CodeGen/GCMetadata.cpp
index 6d1cc1a58e27df..f33008c9e0f232 100644
--- a/llvm/lib/CodeGen/GCMetadata.cpp
+++ b/llvm/lib/CodeGen/GCMetadata.cpp
@@ -66,7 +66,7 @@ GCFunctionAnalysis::run(Function &F, FunctionAnalysisManager &FAM) {
 }
 
 INITIALIZE_PASS(GCModuleInfo, "collector-metadata",
-                "Create Garbage Collector Module Metadata", false, false)
+                "Create Garbage Collector Module Metadata", false, true)
 
 // -----------------------------------------------------------------------------
 
diff --git a/llvm/lib/CodeGen/LiveDebugVariables.cpp b/llvm/lib/CodeGen/LiveDebugVariables.cpp
index 317d3401f000a4..79085e587ebc45 100644
--- a/llvm/lib/CodeGen/LiveDebugVariables.cpp
+++ b/llvm/lib/CodeGen/LiveDebugVariables.cpp
@@ -82,7 +82,7 @@ INITIALIZE_PASS_BEGIN(LiveDebugVariablesWrapperLegacy, DEBUG_TYPE,
 INITIALIZE_PASS_DEPENDENCY(MachineDominatorTreeWrapperPass)
 INITIALIZE_PASS_DEPENDENCY(LiveIntervalsWrapperPass)
 INITIALIZE_PASS_END(LiveDebugVariablesWrapperLegacy, DEBUG_TYPE,
-                    "Debug Variable Analysis", false, false)
+                    "Debug Variable Analysis", false, true)
 
 void LiveDebugVariablesWrapperLegacy::getAnalysisUsage(
     AnalysisUsage &AU) const {
diff --git a/llvm/lib/CodeGen/LiveIntervals.cpp b/llvm/lib/CodeGen/LiveIntervals.cpp
index f9ee6e4563f8d6..f38527a3ce6a31 100644
--- a/llvm/lib/CodeGen/LiveIntervals.cpp
+++ b/llvm/lib/CodeGen/LiveIntervals.cpp
@@ -83,7 +83,7 @@ INITIALIZE_PASS_BEGIN(LiveIntervalsWrapperPass, "liveintervals",
 INITIALIZE_PASS_DEPENDENCY(MachineDominatorTreeWrapperPass)
 INITIALIZE_PASS_DEPENDENCY(SlotIndexesWrapperPass)
 INITIALIZE_PASS_END(LiveIntervalsWrapperPass, "liveintervals",
-                    "Live Interval Analysis", false, false)
+                    "Live Interval Analysis", false, true)
 
 bool LiveIntervalsWrapperPass::runOnMachineFunction(MachineFunction &MF) {
   LIS.Indexes = &getAnalysis<SlotIndexesWrapperPass>().getSI();
diff --git a/llvm/lib/CodeGen/LiveRegMatrix.cpp b/llvm/lib/CodeGen/LiveRegMatrix.cpp
index bc8c59381a40e1..9744c47d5a8510 100644
--- a/llvm/lib/CodeGen/LiveRegMatrix.cpp
+++ b/llvm/lib/CodeGen/LiveRegMatrix.cpp
@@ -41,7 +41,7 @@ INITIALIZE_PASS_BEGIN(LiveRegMatrixWrapperLegacy, "liveregmatrix",
 INITIALIZE_PASS_DEPENDENCY(LiveIntervalsWrapperPass)
 INITIALIZE_PASS_DEPENDENCY(VirtRegMapWrapperLegacy)
 INITIALIZE_PASS_END(LiveRegMatrixWrapperLegacy, "liveregmatrix",
-                    "Live Register Matrix", false, false)
+                    "Live Register Matrix", false, true)
 
 void LiveRegMatrixWrapperLegacy::getAnalysisUsage(AnalysisUsage &AU) const {
   AU.setPreservesAll();
diff --git a/llvm/lib/CodeGen/LiveStacks.cpp b/llvm/lib/CodeGen/LiveStacks.cpp
index 49fe5d6b23452e..e5d2b90578d829 100644
--- a/llvm/lib/CodeGen/LiveStacks.cpp
+++ b/llvm/lib/CodeGen/LiveStacks.cpp
@@ -24,7 +24,7 @@ INITIALIZE_PASS_BEGIN(LiveStacksWrapperLegacy, DEBUG_TYPE,
                       "Live Stack Slot Analysis", false, false)
 INITIALIZE_PASS_DEPENDENCY(SlotIndexesWrapperPass)
 INITIALIZE_PASS_END(LiveStacksWrapperLegacy, DEBUG_TYPE,
-                    "Live Stack Slot Analysis", false, false)
+                    "Live Stack Slot Analysis", false, true)
 
 char &llvm::LiveStacksID = LiveStacksWrapperLegacy::ID;
 
diff --git a/llvm/lib/CodeGen/SlotIndexes.cpp b/llvm/lib/CodeGen/SlotIndexes.cpp
index 1b92a5aa59d18c..8d2832b3fdd56e 100644
--- a/llvm/lib/CodeGen/SlotIndexes.cpp
+++ b/llvm/lib/CodeGen/SlotIndexes.cpp
@@ -45,7 +45,7 @@ SlotIndexes::~SlotIndexes() {
 }
 
 INITIALIZE_PASS(SlotIndexesWrapperPass, DEBUG_TYPE, "Slot index numbering",
-                false, false)
+                false, true)
 
 STATISTIC(NumLocalRenum,  "Number of local renumberings");
 
diff --git a/llvm/lib/CodeGen/VirtRegMap.cpp b/llvm/lib/CodeGen/VirtRegMap.cpp
index 1352102a93d01b..b28c74600e7a29 100644
--- a/llvm/lib/CodeGen/VirtRegMap.cpp
+++ b/llvm/lib/CodeGen/VirtRegMap.cpp
@@ -60,7 +60,7 @@ STATISTIC(NumIdCopies,   "Number of identity moves eliminated after rewriting");
 char VirtRegMapWrapperLegacy::ID = 0;
 
 INITIALIZE_PASS(VirtRegMapWrapperLegacy, "virtregmap", "Virtual Register Map",
-                false, false)
+                false, true)
 
 void VirtRegMap::init(MachineFunction &mf) {
   MRI = &mf.getRegInfo();
diff --git a/llvm/lib/Transforms/Utils/LoopSimplify.cpp b/llvm/lib/Transforms/Utils/LoopSimplify.cpp
index 44fdfe530178a9..d8298646e18d7e 100644
--- a/llvm/lib/Transforms/Utils/LoopSimplify.cpp
+++ b/llvm/lib/Transforms/Utils/LoopSimplify.cpp
@@ -777,8 +777,8 @@ INITIALIZE_PASS_BEGIN(LoopSimplify, "loop-simplify",
 INITIALIZE_PASS_DEPENDENCY(AssumptionCacheTracker)
 INITIALIZE_PASS_DEPENDENCY(DominatorTreeWrapperPass)
 INITIALIZE_PASS_DEPENDENCY(LoopInfoWrapperPass)
-INITIALIZE_PASS_END(LoopSimplify, "loop-simplify",
-                "Canonicalize natural loops", false, false)
+INITIALIZE_PASS_END(LoopSimplify, "loop-simplify", "Canonicalize natural loops",
+                    false, true)
 
 // Publicly exposed interface to pass...
 char &llvm::LoopSimplifyID = LoopSimplify::ID;

optimisan · 2024-12-06T09:43:11Z

Merge activity

Dec 6, 4:43 AM EST: A user started a stack merge that includes this pull request via Graphite.
Dec 6, 4:47 AM EST: Graphite rebased this pull request as part of a merge.
Dec 6, 4:50 AM EST: Graphite rebased this pull request as part of a merge.
Dec 6, 4:53 AM EST: Graphite rebased this pull request as part of a merge.
Dec 6, 4:55 AM EST: A user merged this pull request with Graphite.

Analyses should be marked as analyses else they are prone to be ignored by the legacy analysis cache mechanism and get scheduled redundantly.

aeubanks · 2024-12-09T18:03:38Z

llvm/lib/Transforms/Utils/LoopSimplify.cpp

@@ -777,8 +777,8 @@ INITIALIZE_PASS_BEGIN(LoopSimplify, "loop-simplify",
 INITIALIZE_PASS_DEPENDENCY(AssumptionCacheTracker)
 INITIALIZE_PASS_DEPENDENCY(DominatorTreeWrapperPass)
 INITIALIZE_PASS_DEPENDENCY(LoopInfoWrapperPass)
-INITIALIZE_PASS_END(LoopSimplify, "loop-simplify",


I think loop-simplify is a transformation pass, not an analysis?

Oh yes it's not an analysis. I had naively logged a list of passes being addRequired that weren't marked as analyses.
Reverting this line.

Fixed in #121433

This reverts part of the changes in #118779

This was referenced Dec 5, 2024

[CodeGen][NewPM] Port RegAllocEvictionAdvisor analysis to NPM #117309

Merged

[CodeGen][NewPM] Port RegAllocPriorityAdvisor analysis to NPM #118462

Merged

optimisan mentioned this pull request Dec 5, 2024

[CodeGen][NewPM] Port LiveStacks analysis to NPM #118778

Merged

optimisan force-pushed the users/Akshat-Oke/12-05-_codegen_newpm_port_livestacks_analysis_to_npm branch from 949e14d to 7e6d9ff Compare December 5, 2024 10:11

optimisan force-pushed the users/Akshat-Oke/12-05-_codegen_pm_initialize_analyses_with_isanalysis_true branch from d9e5fac to 13da564 Compare December 5, 2024 10:17

optimisan requested review from aeubanks, paperchalice and cdevadas December 5, 2024 10:19

optimisan marked this pull request as ready for review December 5, 2024 10:19

llvmbot added llvm:regalloc debuginfo llvm:transforms labels Dec 5, 2024

optimisan force-pushed the users/Akshat-Oke/12-05-_codegen_pm_initialize_analyses_with_isanalysis_true branch from 13da564 to 7ee8621 Compare December 5, 2024 10:32

arsenm approved these changes Dec 5, 2024

View reviewed changes

optimisan force-pushed the users/Akshat-Oke/12-05-_codegen_newpm_port_livestacks_analysis_to_npm branch from 4493f30 to 765ac4b Compare December 6, 2024 05:17

optimisan force-pushed the users/Akshat-Oke/12-05-_codegen_pm_initialize_analyses_with_isanalysis_true branch 2 times, most recently from eeca6f9 to 1efd223 Compare December 6, 2024 09:29

optimisan force-pushed the users/Akshat-Oke/12-05-_codegen_newpm_port_livestacks_analysis_to_npm branch from 765ac4b to 3da7b77 Compare December 6, 2024 09:44

Base automatically changed from users/Akshat-Oke/12-05-_codegen_newpm_port_livestacks_analysis_to_npm to main December 6, 2024 09:46

optimisan force-pushed the users/Akshat-Oke/12-05-_codegen_pm_initialize_analyses_with_isanalysis_true branch 2 times, most recently from 41aff66 to 6cf8e8d Compare December 6, 2024 09:50

optimisan added 2 commits December 6, 2024 09:53

[CodeGen][PM] Initialize analyses with isAnalysis=true

90280d0

Analyses should be marked as analyses else they are prone to be ignored by the legacy analysis cache mechanism and get scheduled redundantly.

keep slot indexes as pass

df18a2e

optimisan force-pushed the users/Akshat-Oke/12-05-_codegen_pm_initialize_analyses_with_isanalysis_true branch from 6cf8e8d to df18a2e Compare December 6, 2024 09:53

optimisan merged commit 49abcd2 into main Dec 6, 2024
5 of 8 checks passed

optimisan deleted the users/Akshat-Oke/12-05-_codegen_pm_initialize_analyses_with_isanalysis_true branch December 6, 2024 09:55

aeubanks reviewed Dec 9, 2024

View reviewed changes

optimisan mentioned this pull request Jan 1, 2025

[PM] Remove is_analysis label for LoopSimplify #121433

Merged

optimisan added a commit that referenced this pull request Jan 9, 2025

[PM] Remove is_analysis label for LoopSimplify (#121433)

f6c76d5

This reverts part of the changes in #118779

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[CodeGen][PM] Initialize analyses with isAnalysis=true #118779

[CodeGen][PM] Initialize analyses with isAnalysis=true #118779

Uh oh!

optimisan commented Dec 5, 2024 •

edited

Loading

Uh oh!

optimisan commented Dec 5, 2024 •

edited

Loading

Uh oh!

llvmbot commented Dec 5, 2024 •

edited

Loading

Uh oh!

optimisan commented Dec 6, 2024 •

edited

Loading

Uh oh!

Uh oh!

aeubanks Dec 9, 2024

Uh oh!

optimisan Dec 10, 2024

Uh oh!

optimisan Jan 1, 2025

Uh oh!

Uh oh!

[CodeGen][PM] Initialize analyses with isAnalysis=true #118779

[CodeGen][PM] Initialize analyses with isAnalysis=true #118779

Uh oh!

Conversation

optimisan commented Dec 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

optimisan commented Dec 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

llvmbot commented Dec 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

optimisan commented Dec 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

aeubanks Dec 9, 2024

Choose a reason for hiding this comment

Uh oh!

optimisan Dec 10, 2024

Choose a reason for hiding this comment

Uh oh!

optimisan Jan 1, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

optimisan commented Dec 5, 2024 •

edited

Loading

optimisan commented Dec 5, 2024 •

edited

Loading

llvmbot commented Dec 5, 2024 •

edited

Loading

optimisan commented Dec 6, 2024 •

edited

Loading