Skip to content

Disable test broken by #117624 #118858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

vitalybuka
Copy link
Collaborator

@vitalybuka vitalybuka commented Dec 5, 2024

Created using spr 1.3.4
@llvmbot
Copy link
Member

llvmbot commented Dec 5, 2024

@llvm/pr-subscribers-compiler-rt-sanitizer

Author: Vitaly Buka (vitalybuka)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/118858.diff

1 Files Affected:

  • (modified) compiler-rt/test/asan/TestCases/Linux/global-overflow-bfd.cpp (+2)
diff --git a/compiler-rt/test/asan/TestCases/Linux/global-overflow-bfd.cpp b/compiler-rt/test/asan/TestCases/Linux/global-overflow-bfd.cpp
index bf82a517df37e9..aa9df949262d85 100644
--- a/compiler-rt/test/asan/TestCases/Linux/global-overflow-bfd.cpp
+++ b/compiler-rt/test/asan/TestCases/Linux/global-overflow-bfd.cpp
@@ -2,6 +2,8 @@
 // false negatives with the BFD linker.
 // RUN: %clangxx_asan -fuse-ld=bfd -Wl,-gc-sections -ffunction-sections -fdata-sections -O0 %s -o %t && not %run %t 2>&1 | FileCheck %s
 
+// UNSUPPORTED: android
+
 #include <string.h>
 int main(int argc, char **argv) {
   static char XXX[10];

@vitalybuka
Copy link
Collaborator Author

Please confirm that this is appropriate, or we need to revert #117624.

@vitalybuka vitalybuka merged commit 0550480 into main Dec 5, 2024
5 of 6 checks passed
@vitalybuka vitalybuka deleted the users/vitalybuka/spr/disable-test-broken-by-117624 branch December 5, 2024 20:33
Copy link
Contributor

@enh-google enh-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(thanks for fixing the breakage!)

@enh-google
Copy link
Contributor

Please confirm that this is appropriate, or we need to revert #117624.

this is appropriate --- Android doesn't use or support bfd any more (for several years now).

vitalybuka added a commit that referenced this pull request Dec 5, 2024
@hiraditya
Copy link
Collaborator

Thanks for fixing it quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants