[libc] Include CheckCXXCompilerFlag when checking compiler features #118862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-libc Author: Tristan Ross (RossComputerGuy) ChangesIncludes Full diff: https://github.com/llvm/llvm-project/pull/118862.diff 1 Files Affected:
diff --git a/libc/cmake/modules/CheckCompilerFeatures.cmake b/libc/cmake/modules/CheckCompilerFeatures.cmake
index 862c7ecbd7fdf4..85e1cabd1483e3 100644
--- a/libc/cmake/modules/CheckCompilerFeatures.cmake
+++ b/libc/cmake/modules/CheckCompilerFeatures.cmake
@@ -1,3 +1,5 @@
+include(CheckCXXCompilerFlag)
+
# ------------------------------------------------------------------------------
# Compiler features definition and flags
# ------------------------------------------------------------------------------
|
jhuber6
reviewed
Dec 5, 2024
Comment on lines
1
to
2
| include(CheckCXXCompilerFlag) | ||
|
|
There was a problem hiding this comment.
Move below the header comments.
jhuber6
requested changes
Dec 5, 2024
There was a problem hiding this comment.
This should probably just go at the top level since it's used here
startup/linux/CMakeLists.txt
77:check_cxx_compiler_flag("-r" LIBC_LINKER_SUPPORTS_RELOCATABLE)
cmake/modules/CheckCompilerFeatures.cmake
136:check_cxx_compiler_flag("-ftrivial-auto-var-init=pattern" LIBC_CC_SUPPORTS_PATTERN_INIT)
139:check_cxx_compiler_flag("-nostdlib++" LIBC_CC_SUPPORTS_NOSTDLIBPP)
142:check_cxx_compiler_flag("-nostdlibinc" LIBC_CC_SUPPORTS_NOSTDLIBINC)
cmake/modules/prepare_libc_gpu_build.cmake
44: check_cxx_compiler_flag(-mcpu=native PLATFORM_HAS_GPU)
46: check_cxx_compiler_flag(-march=native PLATFORM_HAS_GPU)
RossComputerGuy
force-pushed
the
feat/llvm-libc-standalone
branch
from
33ec79a to
0984c89
Compare
Oh, alright. I grepped and had found that it was common to include in |
RossComputerGuy
force-pushed
the
feat/llvm-libc-standalone
branch
from
0984c89 to
84e0dde
Compare
|
I've moved it to the top level for libc. |
jhuber6
approved these changes
Dec 5, 2024
RossComputerGuy
force-pushed
the
feat/llvm-libc-standalone
branch
from
84e0dde to
989c7db
Compare
|
T'is done, thank you for the quick review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes
CheckCXXCompilerFlagso when building LLVM libc is built standalone, it actually works and doesn't complain aboutcheck_cxx_compiler_flagnot being defined.