Skip to content

[polly] Skip instructions of different function in isHoistableLoad. #118963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion polly/lib/Support/ScopHelper.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -604,7 +604,8 @@ bool polly::isHoistableLoad(LoadInst *LInst, Region &R, LoopInfo &LI,

for (auto *User : Ptr->users()) {
auto *UserI = dyn_cast<Instruction>(User);
if (!UserI || !R.contains(UserI))
if (!UserI || UserI->getFunction() != LInst->getFunction() ||
!R.contains(UserI))
continue;
if (!UserI->mayWriteToMemory())
continue;
Expand Down
31 changes: 31 additions & 0 deletions polly/test/ScopDetect/dom-tree-crash.ll
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
; RUN: opt %loadNPMPolly '-passes=print<polly-detect>' -disable-output < %s 2>&1 | FileCheck %s

; CHECK: Detected Scops in Function foo

; This unit test case is to check if the following IR does not crash in isHoistableLoad function during Scop Detection.

target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i8:8:32-i16:16:32-i64:64-i128:128-n32:64-S128-Fn32"
target triple = "aarch64-unknown-linux-gnueabi"

define void @foo(ptr %block) {
entry:
br label %for.body

for.cond1.preheader: ; preds = %for.body
%0 = load ptr, ptr null, align 8
%1 = load i16, ptr %block, align 2
%2 = load i16, ptr %0, align 2
br label %foo.exit

for.body: ; preds = %for.body, %entry
br i1 false, label %for.cond1.preheader, label %for.body

foo.exit: ; preds = %for.cond1.preheader
ret void
}

define void @init_foo() {
entry:
store ptr null, ptr null, align 8
ret void
}
Loading