[offload] Support LIBOMPTARGET_DEVICE_ARCHITECTURES={amdgpu|nvptx} #119070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add two more special values for LIBOMPTARGET_DEVICE_ARCHITECTURES: `amdgpu` and `nvptx`, to support building for all AMDGPU and NVPTX targets respectively. This can be used in place of `all` when offload is built with one of the GPU plugins only.
|
@llvm/pr-subscribers-offload Author: Michał Górny (mgorny) ChangesAdd two more special values for LIBOMPTARGET_DEVICE_ARCHITECTURES: Full diff: https://github.com/llvm/llvm-project/pull/119070.diff 1 Files Affected:
diff --git a/offload/DeviceRTL/CMakeLists.txt b/offload/DeviceRTL/CMakeLists.txt
index 32a7510be980d8..1bf3eb9da38aa1 100644
--- a/offload/DeviceRTL/CMakeLists.txt
+++ b/offload/DeviceRTL/CMakeLists.txt
@@ -57,6 +57,10 @@ set(LIBOMPTARGET_DEVICE_ARCHITECTURES "all" CACHE STRING
if(LIBOMPTARGET_DEVICE_ARCHITECTURES STREQUAL "all")
set(LIBOMPTARGET_DEVICE_ARCHITECTURES ${all_gpu_architectures})
+elseif(LIBOMPTARGET_DEVICE_ARCHITECTURES STREQUAL "amdgpu")
+ set(LIBOMPTARGET_DEVICE_ARCHITECTURES ${all_amdgpu_architectures})
+elseif(LIBOMPTARGET_DEVICE_ARCHITECTURES STREQUAL "nvptx")
+ set(LIBOMPTARGET_DEVICE_ARCHITECTURES ${all_nvptx_architectures})
elseif(LIBOMPTARGET_DEVICE_ARCHITECTURES STREQUAL "auto" OR
LIBOMPTARGET_DEVICE_ARCHITECTURES STREQUAL "native")
if(NOT LIBOMPTARGET_NVPTX_ARCH AND NOT LIBOMPTARGET_AMDGPU_ARCH)
|
jhuber6
approved these changes
Dec 7, 2024
thesamesam
approved these changes
Dec 7, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two more special values for LIBOMPTARGET_DEVICE_ARCHITECTURES:
amdgpuandnvptx, to support building for all AMDGPU and NVPTX targets respectively. This can be used in place ofallwhen offload is built with one of the GPU plugins only.