Skip to content

[libc][NFC] modularize malloc #119259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SchrodingerZhu
Copy link
Contributor

@SchrodingerZhu SchrodingerZhu commented Dec 9, 2024

modularize malloc implementations.

@SchrodingerZhu SchrodingerZhu requested a review from lntue December 9, 2024 20:07
Copy link
Contributor

@lntue lntue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you need to introduce an adhoc way to fix target name. Since you already refactoring all the choices to their own folder, in the allocator's cmake, you can add_subdirectory and alias libc.src.stdlib.* to libc.src.stdlib.allocator.<option>.* based on the option.

@SchrodingerZhu
Copy link
Contributor Author

@lntue ideally that is the correct thing to do. however, I failed to alias an external object.

  • It is rejected by explicit checking
  • After relaxing the check, the generator expression is unhappy

@lntue
Copy link
Contributor

lntue commented Dec 10, 2024

@lntue ideally that is the correct thing to do. however, I failed to alias an external object.

  • It is rejected by explicit checking
  • After relaxing the check, the generator expression is unhappy

Do you mind making a draft using alias that I can try and take a look at the errors?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants