Skip to content

[libc][complex] check that cfloat128 is not defined as _Complex long double #119324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

Sh0g0-1758
Copy link
Member

Fix buildbot errors in #118671

@llvmbot llvmbot added the libc label Dec 10, 2024
@Sh0g0-1758
Copy link
Member Author

cc: @lntue

@llvmbot
Copy link
Member

llvmbot commented Dec 10, 2024

@llvm/pr-subscribers-libc

Author: Shourya Goel (Sh0g0-1758)

Changes

Fix buildbot errors in #118671


Full diff: https://github.com/llvm/llvm-project/pull/119324.diff

1 Files Affected:

  • (modified) libc/src/__support/complex_type.h (+4)
diff --git a/libc/src/__support/complex_type.h b/libc/src/__support/complex_type.h
index 4c861b05bc752c..7d9f21229fa94e 100644
--- a/libc/src/__support/complex_type.h
+++ b/libc/src/__support/complex_type.h
@@ -37,10 +37,12 @@ template <> struct make_complex<float16> {
 };
 #endif
 #if defined(LIBC_TYPES_HAS_CFLOAT128)
+#if (LDBL_MANT_DIG != 113)
 template <> struct make_complex<float128> {
   using type = cfloat128;
 };
 #endif
+#endif
 
 template <typename T> using make_complex_t = typename make_complex<T>::type;
 
@@ -62,10 +64,12 @@ template <> struct make_real<cfloat16> {
 };
 #endif
 #if defined(LIBC_TYPES_HAS_CFLOAT128)
+#if (LDBL_MANT_DIG != 113)
 template <> struct make_real<cfloat128> {
   using type = float128;
 };
 #endif
+#endif
 
 template <typename T> using make_real_t = typename make_real<T>::type;
 

@Sh0g0-1758 Sh0g0-1758 self-assigned this Dec 10, 2024
@Sh0g0-1758 Sh0g0-1758 requested a review from lntue December 10, 2024 05:09
@Sh0g0-1758 Sh0g0-1758 merged commit 52da2db into llvm:main Dec 10, 2024
9 of 10 checks passed
@Sh0g0-1758 Sh0g0-1758 mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants