Skip to content

[compiler-rt][AArch64] Rewrite SME routines to all use __aarch64_cpu_features. #119414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sdesmalen-arm
Copy link
Collaborator

When #92921 added the __arm_get_current_vg functionality, it used the FMV feature bits mechanism rather than the mechanism that was previously added for SME which called getauxval on Linux platforms or __aarch64_sme_accessible required for baremetal libraries. It is better to always use __aarch64_cpu_features.

For baremetal we still need to rely on __arm_sme_accessible to initialise the struct.

Copy link

github-actions bot commented Dec 10, 2024

✅ With the latest revision this PR passed the C/C++ code formatter.

@sdesmalen-arm sdesmalen-arm force-pushed the compiler-rt-unify-sme-feature-detection branch from 8db75c0 to ff0bbab Compare December 10, 2024 16:59
When llvm#92921 added the `__arm_get_current_vg` functionality, it used
the FMV feature bits mechanism rather than the existing mechanism that was
previously added for SME that called `getauxval` (on Linux platforms)
or `__aarch64_sme_accessible` (required for baremetal libraries).

It seems simpler to always use the FMV feature bits mechanism, but
for baremetal targets we still need to rely on `__arm_sme_accessible`.
@sdesmalen-arm sdesmalen-arm force-pushed the compiler-rt-unify-sme-feature-detection branch from ff0bbab to 450ed8a Compare December 10, 2024 17:07
@DanielKristofKiss
Copy link
Member

Maybe the compiler-rt/lib/builtins/cpu_model/aarch64/fmv/baremetal_sme.inc could drop the SME from the filename and the macro name as it could do more later.

LGTM otherwise.

@jroelofs jroelofs requested a review from aemerson December 10, 2024 18:22
@jroelofs
Copy link
Contributor

I'm not sure we want this on Darwin and maybe Fuchsia platforms, since it would require calling __init_cpu_features_resolver to initialize __aarch64_cpu_features. On some platforms that happens automatically via an __attribute__((constructor)) function, but Darwin and Fuchsia don't, and instead rely on an FMV resolver triggering it.

cc @aemerson

@jroelofs jroelofs requested a review from petrhosek December 10, 2024 18:29
@aemerson
Copy link
Contributor

I'm not sure we want this on Darwin and maybe Fuchsia platforms, since it would require calling __init_cpu_features_resolver to initialize __aarch64_cpu_features. On some platforms that happens automatically via an __attribute__((constructor)) function, but Darwin and Fuchsia don't, and instead rely on an FMV resolver triggering it.

cc @aemerson

There's no immediate concern for Darwin because we have our own parallel implementations of the SME runtime routines.

@sdesmalen-arm
Copy link
Collaborator Author

On some platforms that happens automatically via an __attribute__((constructor)) function, but Darwin and Fuchsia don't, and instead rely on an FMV resolver triggering it.

Is there a technical reason for that or is this just an implementation choice?

@sdesmalen-arm sdesmalen-arm merged commit cb4f4a8 into llvm:main Dec 11, 2024
7 checks passed
@jroelofs
Copy link
Contributor

On some platforms that happens automatically via an __attribute__((constructor)) function, but Darwin and Fuchsia don't, and instead rely on an FMV resolver triggering it.

Is there a technical reason for that or is this just an implementation choice?

All the existing uses of it on Darwin platforms are lazy, and thus you don't pay for what you don't use. And in general, we try really hard to avoid global ctors/dtors as they tend to dirty pages, increase launch times, etc.

@jroelofs
Copy link
Contributor

There's no immediate concern for Darwin because we have our own parallel implementations of the SME runtime routines.

Well, we have a downstream one. I think we should avoid making the upstream one incorrect and/or slower than it needs to be.

sdesmalen-arm added a commit to sdesmalen-arm/llvm-project that referenced this pull request Dec 12, 2024
…nitialised.

According to the conversation
[here](llvm#119414 (comment)),
some platforms don't enable `__arm_cpu_features` with a global constructor,
but rather do so lazily when called from the FMV resolver.

PR llvm#119414 removed the CMake guard to check to see if the targetted
platform is baremetal or supports sys/auxv. Without this check, the
routines rely on `__arm_cpu_features` being initialised when they
may not be, depending on the platform.

This PR simply avoids building the SME routines for those platforms for now.
sdesmalen-arm added a commit that referenced this pull request Dec 12, 2024
…nitialised. (#119703)

According to the conversation

[here](#119414 (comment)),
some platforms don't enable `__arm_cpu_features` with a global
constructor, but rather do so lazily when called from the FMV resolver.

PR #119414 removed the CMake guard to check to see if the targetted
platform is baremetal or supports sys/auxv. Without this check, the
routines rely on `__arm_cpu_features` being initialised when they may
not be, depending on the platform.

This PR simply avoids building the SME routines for those platforms for
now.
aarongable pushed a commit to chromium/chromium that referenced this pull request Dec 21, 2024
…6062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1

https://chromium.googlesource.com/external/github.com/llvm/llvm-project/+log/8cb44859..091448e3

https://chromium.googlesource.com/external/github.com/rust-lang/rust/+log/a522d7859841..8a1f8039a7de

Ran: ./tools/clang/scripts/upload_revision.py 091448e3c17bc8e7812dd7b571c852576d648977

Additionally:
* Ran tools/rust/gnrt_stdlib.py
* Updated //chrome/android/static_initializers.gni because it referred
  to a static initializer in sme-abi-init.c, a file in compiler-rt that
  was removed in llvm/llvm-project#119414.

Bug: 382540640
Disable-Rts: True
Change-Id: I4fd6f81827ed519770048adb74430e8ec1fd849d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6111009
Auto-Submit: Alan Zhao <[email protected]>
Commit-Queue: Zequan Wu <[email protected]>
Commit-Queue: Alan Zhao <[email protected]>
Reviewed-by: Zequan Wu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1399472}
aarongable pushed a commit to chromium/chromium that referenced this pull request Dec 21, 2024
…0-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1"

This reverts commit 32fd5de.

Reason for revert: tree-closing compilation failures:
https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-arm-rel/10744
https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-arm64-rel/11108
https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-x64-rel/6736
with the error:
chromecast/browser/cast_web_contents_impl.h:182:26: error: private field 'parent_cast_web_contents_' is not used [-Werror,-Wunused-private-field]
  182 |   CastWebContents* const parent_cast_web_contents_ = nullptr;

Original change's description:
> Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1
>
> https://chromium.googlesource.com/external/github.com/llvm/llvm-project/+log/8cb44859..091448e3
>
> https://chromium.googlesource.com/external/github.com/rust-lang/rust/+log/a522d7859841..8a1f8039a7de
>
> Ran: ./tools/clang/scripts/upload_revision.py 091448e3c17bc8e7812dd7b571c852576d648977
>
> Additionally:
> * Ran tools/rust/gnrt_stdlib.py
> * Updated //chrome/android/static_initializers.gni because it referred
>   to a static initializer in sme-abi-init.c, a file in compiler-rt that
>   was removed in llvm/llvm-project#119414.
>
> Bug: 382540640
> Disable-Rts: True
> Change-Id: I4fd6f81827ed519770048adb74430e8ec1fd849d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6111009
> Auto-Submit: Alan Zhao <[email protected]>
> Commit-Queue: Zequan Wu <[email protected]>
> Commit-Queue: Alan Zhao <[email protected]>
> Reviewed-by: Zequan Wu <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1399472}

Bug: 382540640
Change-Id: Ib8d123e61472090b0643b5617aa7a259abd8ff58
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6108066
Owners-Override: David Baron <[email protected]>
Auto-Submit: David Baron <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1399476}
aarongable pushed a commit to chromium/chromium that referenced this pull request Dec 21, 2024
…0-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1"

This reverts commit dca6856.

Reason for revert: already fixed

Original change's description:
> Revert "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1"
>
> This reverts commit 32fd5de.
>
> Reason for revert: tree-closing compilation failures:
> https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-arm-rel/10744
> https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-arm64-rel/11108
> https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-x64-rel/6736
> with the error:
> chromecast/browser/cast_web_contents_impl.h:182:26: error: private field 'parent_cast_web_contents_' is not used [-Werror,-Wunused-private-field]
>   182 |   CastWebContents* const parent_cast_web_contents_ = nullptr;
>
> Original change's description:
> > Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1
> >
> > https://chromium.googlesource.com/external/github.com/llvm/llvm-project/+log/8cb44859..091448e3
> >
> > https://chromium.googlesource.com/external/github.com/rust-lang/rust/+log/a522d7859841..8a1f8039a7de
> >
> > Ran: ./tools/clang/scripts/upload_revision.py 091448e3c17bc8e7812dd7b571c852576d648977
> >
> > Additionally:
> > * Ran tools/rust/gnrt_stdlib.py
> > * Updated //chrome/android/static_initializers.gni because it referred
> >   to a static initializer in sme-abi-init.c, a file in compiler-rt that
> >   was removed in llvm/llvm-project#119414.
> >
> > Bug: 382540640
> > Disable-Rts: True
> > Change-Id: I4fd6f81827ed519770048adb74430e8ec1fd849d
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6111009
> > Auto-Submit: Alan Zhao <[email protected]>
> > Commit-Queue: Zequan Wu <[email protected]>
> > Commit-Queue: Alan Zhao <[email protected]>
> > Reviewed-by: Zequan Wu <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1399472}
>
> Bug: 382540640
> Change-Id: Ib8d123e61472090b0643b5617aa7a259abd8ff58
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6108066
> Owners-Override: David Baron <[email protected]>
> Auto-Submit: David Baron <[email protected]>
> Commit-Queue: Rubber Stamper <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1399476}

Bug: 382540640
Change-Id: I0c6504bd82a38b6a8fddb27b080af3b639e4acc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6111305
Commit-Queue: Alan Zhao <[email protected]>
Reviewed-by: Alan Zhao <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1399482}
aarongable pushed a commit to chromium/chromium that referenced this pull request Dec 21, 2024
…lvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1""

This reverts commit cb59cac.

Reason for revert:
LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8727971662145799313

Sample failed build: https://ci.chromium.org/b/8727971662145799313

If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6111305&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8727971662145799313&type=BUG

Original change's description:
> Reland "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1"
>
> This reverts commit dca6856.
>
> Reason for revert: already fixed
>
> Original change's description:
> > Revert "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1"
> >
> > This reverts commit 32fd5de.
> >
> > Reason for revert: tree-closing compilation failures:
> > https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-arm-rel/10744
> > https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-arm64-rel/11108
> > https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-x64-rel/6736
> > with the error:
> > chromecast/browser/cast_web_contents_impl.h:182:26: error: private field 'parent_cast_web_contents_' is not used [-Werror,-Wunused-private-field]
> >   182 |   CastWebContents* const parent_cast_web_contents_ = nullptr;
> >
> > Original change's description:
> > > Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1
> > >
> > > https://chromium.googlesource.com/external/github.com/llvm/llvm-project/+log/8cb44859..091448e3
> > >
> > > https://chromium.googlesource.com/external/github.com/rust-lang/rust/+log/a522d7859841..8a1f8039a7de
> > >
> > > Ran: ./tools/clang/scripts/upload_revision.py 091448e3c17bc8e7812dd7b571c852576d648977
> > >
> > > Additionally:
> > > * Ran tools/rust/gnrt_stdlib.py
> > > * Updated //chrome/android/static_initializers.gni because it referred
> > >   to a static initializer in sme-abi-init.c, a file in compiler-rt that
> > >   was removed in llvm/llvm-project#119414.
> > >
> > > Bug: 382540640
> > > Disable-Rts: True
> > > Change-Id: I4fd6f81827ed519770048adb74430e8ec1fd849d
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6111009
> > > Auto-Submit: Alan Zhao <[email protected]>
> > > Commit-Queue: Zequan Wu <[email protected]>
> > > Commit-Queue: Alan Zhao <[email protected]>
> > > Reviewed-by: Zequan Wu <[email protected]>
> > > Cr-Commit-Position: refs/heads/main@{#1399472}
> >
> > Bug: 382540640
> > Change-Id: Ib8d123e61472090b0643b5617aa7a259abd8ff58
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6108066
> > Owners-Override: David Baron <[email protected]>
> > Auto-Submit: David Baron <[email protected]>
> > Commit-Queue: Rubber Stamper <[email protected]>
> > Bot-Commit: Rubber Stamper <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1399476}
>
> Bug: 382540640
> Change-Id: I0c6504bd82a38b6a8fddb27b080af3b639e4acc6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6111305
> Commit-Queue: Alan Zhao <[email protected]>
> Reviewed-by: Alan Zhao <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Commit-Queue: Nico Weber <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1399482}
>

Bug: 382540640
Change-Id: Ic3fc3671ab942245b89aaa461cf8e5c5331d96d2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6116109
Bot-Commit: [email protected] <[email protected]>
Owners-Override: [email protected] <[email protected]>
Commit-Queue: [email protected] <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1399490}
aarongable pushed a commit to chromium/chromium that referenced this pull request Dec 23, 2024
…59-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1"""

This reverts commit 5886a73.

Reason for revert: bisect suggests this commit is making
"Linux UBSan Tests"'s blink_unittests fail due to
third_party/libaom/source/libaom/av1/.
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20UBSan%20Tests/2001/overview



Original change's description:
> Reland "Reland "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1""
>
> This reverts commit b198121.
>
> Reason for revert: should be better after
> https://chromium-review.googlesource.com/c/chromium/src/+/6115847
>
> Original change's description:
> > Revert "Reland "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1""
> >
> > This reverts commit cb59cac.
> >
> > Reason for revert:
> > LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8727971662145799313
> >
> > Sample failed build: https://ci.chromium.org/b/8727971662145799313
> >
> > If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6111305&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8727971662145799313&type=BUG
> >
> > Original change's description:
> > > Reland "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1"
> > >
> > > This reverts commit dca6856.
> > >
> > > Reason for revert: already fixed
> > >
> > > Original change's description:
> > > > Revert "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1"
> > > >
> > > > This reverts commit 32fd5de.
> > > >
> > > > Reason for revert: tree-closing compilation failures:
> > > > https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-arm-rel/10744
> > > > https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-arm64-rel/11108
> > > > https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-x64-rel/6736
> > > > with the error:
> > > > chromecast/browser/cast_web_contents_impl.h:182:26: error: private field 'parent_cast_web_contents_' is not used [-Werror,-Wunused-private-field]
> > > >   182 |   CastWebContents* const parent_cast_web_contents_ = nullptr;
> > > >
> > > > Original change's description:
> > > > > Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1
> > > > >
> > > > > https://chromium.googlesource.com/external/github.com/llvm/llvm-project/+log/8cb44859..091448e3
> > > > >
> > > > > https://chromium.googlesource.com/external/github.com/rust-lang/rust/+log/a522d7859841..8a1f8039a7de
> > > > >
> > > > > Ran: ./tools/clang/scripts/upload_revision.py 091448e3c17bc8e7812dd7b571c852576d648977
> > > > >
> > > > > Additionally:
> > > > > * Ran tools/rust/gnrt_stdlib.py
> > > > > * Updated //chrome/android/static_initializers.gni because it referred
> > > > >   to a static initializer in sme-abi-init.c, a file in compiler-rt that
> > > > >   was removed in llvm/llvm-project#119414.
> > > > >
> > > > > Bug: 382540640
> > > > > Disable-Rts: True
> > > > > Change-Id: I4fd6f81827ed519770048adb74430e8ec1fd849d
> > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6111009
> > > > > Auto-Submit: Alan Zhao <[email protected]>
> > > > > Commit-Queue: Zequan Wu <[email protected]>
> > > > > Commit-Queue: Alan Zhao <[email protected]>
> > > > > Reviewed-by: Zequan Wu <[email protected]>
> > > > > Cr-Commit-Position: refs/heads/main@{#1399472}
> > > >
> > > > Bug: 382540640
> > > > Change-Id: Ib8d123e61472090b0643b5617aa7a259abd8ff58
> > > > No-Presubmit: true
> > > > No-Tree-Checks: true
> > > > No-Try: true
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6108066
> > > > Owners-Override: David Baron <[email protected]>
> > > > Auto-Submit: David Baron <[email protected]>
> > > > Commit-Queue: Rubber Stamper <[email protected]>
> > > > Bot-Commit: Rubber Stamper <[email protected]>
> > > > Cr-Commit-Position: refs/heads/main@{#1399476}
> > >
> > > Bug: 382540640
> > > Change-Id: I0c6504bd82a38b6a8fddb27b080af3b639e4acc6
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6111305
> > > Commit-Queue: Alan Zhao <[email protected]>
> > > Reviewed-by: Alan Zhao <[email protected]>
> > > Bot-Commit: Rubber Stamper <[email protected]>
> > > Commit-Queue: Nico Weber <[email protected]>
> > > Cr-Commit-Position: refs/heads/main@{#1399482}
> > >
> >
> > Bug: 382540640
> > Change-Id: Ic3fc3671ab942245b89aaa461cf8e5c5331d96d2
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6116109
> > Bot-Commit: [email protected] <[email protected]>
> > Owners-Override: [email protected] <[email protected]>
> > Commit-Queue: [email protected] <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1399490}
>
> Bug: 382540640
> Change-Id: I0e783f8acad96b4bf57d715f33fef50c8af9b4a4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6114634
> Commit-Queue: Nico Weber <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Auto-Submit: Nico Weber <[email protected]>
> Commit-Queue: Rubber Stamper <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1399535}

Bug: 382540640
Change-Id: I468132e0b79883372f0b3487577b942b2e212629
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6108528
Auto-Submit: Lingqi Chi <[email protected]>
Commit-Queue: Lingqi Chi <[email protected]>
Owners-Override: Lingqi Chi <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1399706}
aarongable pushed a commit to chromium/chromium that referenced this pull request Jan 2, 2025
…-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1"

This reverts commit e009087.

Reason for revert: Passes last revert reason now, see crbug.com/385545752

Original change's description:
> Revert "Reland "Reland "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1"""
>
> This reverts commit 5886a73.
>
> Reason for revert: bisect suggests this commit is making
> "Linux UBSan Tests"'s blink_unittests fail due to
> third_party/libaom/source/libaom/av1/.
> https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20UBSan%20Tests/2001/overview
>
>
>
> Original change's description:
> > Reland "Reland "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1""
> >
> > This reverts commit b198121.
> >
> > Reason for revert: should be better after
> > https://chromium-review.googlesource.com/c/chromium/src/+/6115847
> >
> > Original change's description:
> > > Revert "Reland "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1""
> > >
> > > This reverts commit cb59cac.
> > >
> > > Reason for revert:
> > > LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8727971662145799313
> > >
> > > Sample failed build: https://ci.chromium.org/b/8727971662145799313
> > >
> > > If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6111305&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8727971662145799313&type=BUG
> > >
> > > Original change's description:
> > > > Reland "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1"
> > > >
> > > > This reverts commit dca6856.
> > > >
> > > > Reason for revert: already fixed
> > > >
> > > > Original change's description:
> > > > > Revert "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1"
> > > > >
> > > > > This reverts commit 32fd5de.
> > > > >
> > > > > Reason for revert: tree-closing compilation failures:
> > > > > https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-arm-rel/10744
> > > > > https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-arm64-rel/11108
> > > > > https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-x64-rel/6736
> > > > > with the error:
> > > > > chromecast/browser/cast_web_contents_impl.h:182:26: error: private field 'parent_cast_web_contents_' is not used [-Werror,-Wunused-private-field]
> > > > >   182 |   CastWebContents* const parent_cast_web_contents_ = nullptr;
> > > > >
> > > > > Original change's description:
> > > > > > Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1
> > > > > >
> > > > > > https://chromium.googlesource.com/external/github.com/llvm/llvm-project/+log/8cb44859..091448e3
> > > > > >
> > > > > > https://chromium.googlesource.com/external/github.com/rust-lang/rust/+log/a522d7859841..8a1f8039a7de
> > > > > >
> > > > > > Ran: ./tools/clang/scripts/upload_revision.py 091448e3c17bc8e7812dd7b571c852576d648977
> > > > > >
> > > > > > Additionally:
> > > > > > * Ran tools/rust/gnrt_stdlib.py
> > > > > > * Updated //chrome/android/static_initializers.gni because it referred
> > > > > >   to a static initializer in sme-abi-init.c, a file in compiler-rt that
> > > > > >   was removed in llvm/llvm-project#119414.
> > > > > >
> > > > > > Bug: 382540640
> > > > > > Disable-Rts: True
> > > > > > Change-Id: I4fd6f81827ed519770048adb74430e8ec1fd849d
> > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6111009
> > > > > > Auto-Submit: Alan Zhao <[email protected]>
> > > > > > Commit-Queue: Zequan Wu <[email protected]>
> > > > > > Commit-Queue: Alan Zhao <[email protected]>
> > > > > > Reviewed-by: Zequan Wu <[email protected]>
> > > > > > Cr-Commit-Position: refs/heads/main@{#1399472}
> > > > >
> > > > > Bug: 382540640
> > > > > Change-Id: Ib8d123e61472090b0643b5617aa7a259abd8ff58
> > > > > No-Presubmit: true
> > > > > No-Tree-Checks: true
> > > > > No-Try: true
> > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6108066
> > > > > Owners-Override: David Baron <[email protected]>
> > > > > Auto-Submit: David Baron <[email protected]>
> > > > > Commit-Queue: Rubber Stamper <[email protected]>
> > > > > Bot-Commit: Rubber Stamper <[email protected]>
> > > > > Cr-Commit-Position: refs/heads/main@{#1399476}
> > > >
> > > > Bug: 382540640
> > > > Change-Id: I0c6504bd82a38b6a8fddb27b080af3b639e4acc6
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6111305
> > > > Commit-Queue: Alan Zhao <[email protected]>
> > > > Reviewed-by: Alan Zhao <[email protected]>
> > > > Bot-Commit: Rubber Stamper <[email protected]>
> > > > Commit-Queue: Nico Weber <[email protected]>
> > > > Cr-Commit-Position: refs/heads/main@{#1399482}
> > > >
> > >
> > > Bug: 382540640
> > > Change-Id: Ic3fc3671ab942245b89aaa461cf8e5c5331d96d2
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6116109
> > > Bot-Commit: [email protected] <[email protected]>
> > > Owners-Override: [email protected] <[email protected]>
> > > Commit-Queue: [email protected] <[email protected]>
> > > Cr-Commit-Position: refs/heads/main@{#1399490}
> >
> > Bug: 382540640
> > Change-Id: I0e783f8acad96b4bf57d715f33fef50c8af9b4a4
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6114634
> > Commit-Queue: Nico Weber <[email protected]>
> > Bot-Commit: Rubber Stamper <[email protected]>
> > Auto-Submit: Nico Weber <[email protected]>
> > Commit-Queue: Rubber Stamper <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1399535}
>
> Bug: 382540640
> Change-Id: I468132e0b79883372f0b3487577b942b2e212629
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6108528
> Auto-Submit: Lingqi Chi <[email protected]>
> Commit-Queue: Lingqi Chi <[email protected]>
> Owners-Override: Lingqi Chi <[email protected]>
> Commit-Queue: Rubber Stamper <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1399706}

Bug: 382540640,385545752
Change-Id: I748d35167b0a05a9f01976226d311f387e1d193e
Cq-Include-Trybots: luci.chromium.try:linux_chromium_ubsan_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6133672
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1401445}
ogsts pushed a commit to ubiquiti/ubnt_libjingle_component_src_build that referenced this pull request Jan 12, 2025
…6062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1

https://chromium.googlesource.com/external/github.com/llvm/llvm-project/+log/8cb44859..091448e3

https://chromium.googlesource.com/external/github.com/rust-lang/rust/+log/a522d7859841..8a1f8039a7de

Ran: ./tools/clang/scripts/upload_revision.py 091448e3c17bc8e7812dd7b571c852576d648977

Additionally:
* Ran tools/rust/gnrt_stdlib.py
* Updated //chrome/android/static_initializers.gni because it referred
  to a static initializer in sme-abi-init.c, a file in compiler-rt that
  was removed in llvm/llvm-project#119414.

Bug: 382540640
Disable-Rts: True
Change-Id: I4fd6f81827ed519770048adb74430e8ec1fd849d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6111009
Auto-Submit: Alan Zhao <[email protected]>
Commit-Queue: Zequan Wu <[email protected]>
Commit-Queue: Alan Zhao <[email protected]>
Reviewed-by: Zequan Wu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1399472}
NOKEYCHECK=True
GitOrigin-RevId: 32fd5de30ad9dcb9d47816e97161de85b36b63c6
ogsts pushed a commit to ubiquiti/ubnt_libjingle_component_src_build that referenced this pull request Jan 12, 2025
…0-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1"

This reverts commit 32fd5de30ad9dcb9d47816e97161de85b36b63c6.

Reason for revert: tree-closing compilation failures:
https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-arm-rel/10744
https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-arm64-rel/11108
https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-x64-rel/6736
with the error:
chromecast/browser/cast_web_contents_impl.h:182:26: error: private field 'parent_cast_web_contents_' is not used [-Werror,-Wunused-private-field]
  182 |   CastWebContents* const parent_cast_web_contents_ = nullptr;

Original change's description:
> Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1
>
> https://chromium.googlesource.com/external/github.com/llvm/llvm-project/+log/8cb44859..091448e3
>
> https://chromium.googlesource.com/external/github.com/rust-lang/rust/+log/a522d7859841..8a1f8039a7de
>
> Ran: ./tools/clang/scripts/upload_revision.py 091448e3c17bc8e7812dd7b571c852576d648977
>
> Additionally:
> * Ran tools/rust/gnrt_stdlib.py
> * Updated //chrome/android/static_initializers.gni because it referred
>   to a static initializer in sme-abi-init.c, a file in compiler-rt that
>   was removed in llvm/llvm-project#119414.
>
> Bug: 382540640
> Disable-Rts: True
> Change-Id: I4fd6f81827ed519770048adb74430e8ec1fd849d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6111009
> Auto-Submit: Alan Zhao <[email protected]>
> Commit-Queue: Zequan Wu <[email protected]>
> Commit-Queue: Alan Zhao <[email protected]>
> Reviewed-by: Zequan Wu <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1399472}

Bug: 382540640
Change-Id: Ib8d123e61472090b0643b5617aa7a259abd8ff58
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6108066
Owners-Override: David Baron <[email protected]>
Auto-Submit: David Baron <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1399476}
NOKEYCHECK=True
GitOrigin-RevId: dca68566e7efca3368542b8329cad45e875ba0ae
ogsts pushed a commit to ubiquiti/ubnt_libjingle_component_src_build that referenced this pull request Jan 12, 2025
…0-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1"

This reverts commit dca68566e7efca3368542b8329cad45e875ba0ae.

Reason for revert: already fixed

Original change's description:
> Revert "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1"
>
> This reverts commit 32fd5de30ad9dcb9d47816e97161de85b36b63c6.
>
> Reason for revert: tree-closing compilation failures:
> https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-arm-rel/10744
> https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-arm64-rel/11108
> https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-x64-rel/6736
> with the error:
> chromecast/browser/cast_web_contents_impl.h:182:26: error: private field 'parent_cast_web_contents_' is not used [-Werror,-Wunused-private-field]
>   182 |   CastWebContents* const parent_cast_web_contents_ = nullptr;
>
> Original change's description:
> > Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1
> >
> > https://chromium.googlesource.com/external/github.com/llvm/llvm-project/+log/8cb44859..091448e3
> >
> > https://chromium.googlesource.com/external/github.com/rust-lang/rust/+log/a522d7859841..8a1f8039a7de
> >
> > Ran: ./tools/clang/scripts/upload_revision.py 091448e3c17bc8e7812dd7b571c852576d648977
> >
> > Additionally:
> > * Ran tools/rust/gnrt_stdlib.py
> > * Updated //chrome/android/static_initializers.gni because it referred
> >   to a static initializer in sme-abi-init.c, a file in compiler-rt that
> >   was removed in llvm/llvm-project#119414.
> >
> > Bug: 382540640
> > Disable-Rts: True
> > Change-Id: I4fd6f81827ed519770048adb74430e8ec1fd849d
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6111009
> > Auto-Submit: Alan Zhao <[email protected]>
> > Commit-Queue: Zequan Wu <[email protected]>
> > Commit-Queue: Alan Zhao <[email protected]>
> > Reviewed-by: Zequan Wu <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1399472}
>
> Bug: 382540640
> Change-Id: Ib8d123e61472090b0643b5617aa7a259abd8ff58
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6108066
> Owners-Override: David Baron <[email protected]>
> Auto-Submit: David Baron <[email protected]>
> Commit-Queue: Rubber Stamper <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1399476}

Bug: 382540640
Change-Id: I0c6504bd82a38b6a8fddb27b080af3b639e4acc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6111305
Commit-Queue: Alan Zhao <[email protected]>
Reviewed-by: Alan Zhao <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1399482}
NOKEYCHECK=True
GitOrigin-RevId: cb59cac5a03953631e731b8dcd145399437a1a49
ogsts pushed a commit to ubiquiti/ubnt_libjingle_component_src_build that referenced this pull request Jan 12, 2025
…lvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1""

This reverts commit cb59cac5a03953631e731b8dcd145399437a1a49.

Reason for revert:
LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8727971662145799313

Sample failed build: https://ci.chromium.org/b/8727971662145799313

If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6111305&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8727971662145799313&type=BUG

Original change's description:
> Reland "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1"
>
> This reverts commit dca68566e7efca3368542b8329cad45e875ba0ae.
>
> Reason for revert: already fixed
>
> Original change's description:
> > Revert "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1"
> >
> > This reverts commit 32fd5de30ad9dcb9d47816e97161de85b36b63c6.
> >
> > Reason for revert: tree-closing compilation failures:
> > https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-arm-rel/10744
> > https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-arm64-rel/11108
> > https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-x64-rel/6736
> > with the error:
> > chromecast/browser/cast_web_contents_impl.h:182:26: error: private field 'parent_cast_web_contents_' is not used [-Werror,-Wunused-private-field]
> >   182 |   CastWebContents* const parent_cast_web_contents_ = nullptr;
> >
> > Original change's description:
> > > Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1
> > >
> > > https://chromium.googlesource.com/external/github.com/llvm/llvm-project/+log/8cb44859..091448e3
> > >
> > > https://chromium.googlesource.com/external/github.com/rust-lang/rust/+log/a522d7859841..8a1f8039a7de
> > >
> > > Ran: ./tools/clang/scripts/upload_revision.py 091448e3c17bc8e7812dd7b571c852576d648977
> > >
> > > Additionally:
> > > * Ran tools/rust/gnrt_stdlib.py
> > > * Updated //chrome/android/static_initializers.gni because it referred
> > >   to a static initializer in sme-abi-init.c, a file in compiler-rt that
> > >   was removed in llvm/llvm-project#119414.
> > >
> > > Bug: 382540640
> > > Disable-Rts: True
> > > Change-Id: I4fd6f81827ed519770048adb74430e8ec1fd849d
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6111009
> > > Auto-Submit: Alan Zhao <[email protected]>
> > > Commit-Queue: Zequan Wu <[email protected]>
> > > Commit-Queue: Alan Zhao <[email protected]>
> > > Reviewed-by: Zequan Wu <[email protected]>
> > > Cr-Commit-Position: refs/heads/main@{#1399472}
> >
> > Bug: 382540640
> > Change-Id: Ib8d123e61472090b0643b5617aa7a259abd8ff58
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6108066
> > Owners-Override: David Baron <[email protected]>
> > Auto-Submit: David Baron <[email protected]>
> > Commit-Queue: Rubber Stamper <[email protected]>
> > Bot-Commit: Rubber Stamper <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1399476}
>
> Bug: 382540640
> Change-Id: I0c6504bd82a38b6a8fddb27b080af3b639e4acc6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6111305
> Commit-Queue: Alan Zhao <[email protected]>
> Reviewed-by: Alan Zhao <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Commit-Queue: Nico Weber <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1399482}
>

Bug: 382540640
Change-Id: Ic3fc3671ab942245b89aaa461cf8e5c5331d96d2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6116109
Bot-Commit: [email protected] <[email protected]>
Owners-Override: [email protected] <[email protected]>
Commit-Queue: [email protected] <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1399490}
NOKEYCHECK=True
GitOrigin-RevId: b198121decca6f38503409af96a539b7ba98feed
ogsts pushed a commit to ubiquiti/ubnt_libjingle_component_src_build that referenced this pull request Jan 12, 2025
…lvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1""

This reverts commit b198121decca6f38503409af96a539b7ba98feed.

Reason for revert: should be better after
https://chromium-review.googlesource.com/c/chromium/src/+/6115847

Original change's description:
> Revert "Reland "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1""
>
> This reverts commit cb59cac5a03953631e731b8dcd145399437a1a49.
>
> Reason for revert:
> LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8727971662145799313
>
> Sample failed build: https://ci.chromium.org/b/8727971662145799313
>
> If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6111305&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8727971662145799313&type=BUG
>
> Original change's description:
> > Reland "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1"
> >
> > This reverts commit dca68566e7efca3368542b8329cad45e875ba0ae.
> >
> > Reason for revert: already fixed
> >
> > Original change's description:
> > > Revert "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1"
> > >
> > > This reverts commit 32fd5de30ad9dcb9d47816e97161de85b36b63c6.
> > >
> > > Reason for revert: tree-closing compilation failures:
> > > https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-arm-rel/10744
> > > https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-arm64-rel/11108
> > > https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-x64-rel/6736
> > > with the error:
> > > chromecast/browser/cast_web_contents_impl.h:182:26: error: private field 'parent_cast_web_contents_' is not used [-Werror,-Wunused-private-field]
> > >   182 |   CastWebContents* const parent_cast_web_contents_ = nullptr;
> > >
> > > Original change's description:
> > > > Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1
> > > >
> > > > https://chromium.googlesource.com/external/github.com/llvm/llvm-project/+log/8cb44859..091448e3
> > > >
> > > > https://chromium.googlesource.com/external/github.com/rust-lang/rust/+log/a522d7859841..8a1f8039a7de
> > > >
> > > > Ran: ./tools/clang/scripts/upload_revision.py 091448e3c17bc8e7812dd7b571c852576d648977
> > > >
> > > > Additionally:
> > > > * Ran tools/rust/gnrt_stdlib.py
> > > > * Updated //chrome/android/static_initializers.gni because it referred
> > > >   to a static initializer in sme-abi-init.c, a file in compiler-rt that
> > > >   was removed in llvm/llvm-project#119414.
> > > >
> > > > Bug: 382540640
> > > > Disable-Rts: True
> > > > Change-Id: I4fd6f81827ed519770048adb74430e8ec1fd849d
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6111009
> > > > Auto-Submit: Alan Zhao <[email protected]>
> > > > Commit-Queue: Zequan Wu <[email protected]>
> > > > Commit-Queue: Alan Zhao <[email protected]>
> > > > Reviewed-by: Zequan Wu <[email protected]>
> > > > Cr-Commit-Position: refs/heads/main@{#1399472}
> > >
> > > Bug: 382540640
> > > Change-Id: Ib8d123e61472090b0643b5617aa7a259abd8ff58
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6108066
> > > Owners-Override: David Baron <[email protected]>
> > > Auto-Submit: David Baron <[email protected]>
> > > Commit-Queue: Rubber Stamper <[email protected]>
> > > Bot-Commit: Rubber Stamper <[email protected]>
> > > Cr-Commit-Position: refs/heads/main@{#1399476}
> >
> > Bug: 382540640
> > Change-Id: I0c6504bd82a38b6a8fddb27b080af3b639e4acc6
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6111305
> > Commit-Queue: Alan Zhao <[email protected]>
> > Reviewed-by: Alan Zhao <[email protected]>
> > Bot-Commit: Rubber Stamper <[email protected]>
> > Commit-Queue: Nico Weber <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1399482}
> >
>
> Bug: 382540640
> Change-Id: Ic3fc3671ab942245b89aaa461cf8e5c5331d96d2
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6116109
> Bot-Commit: [email protected] <[email protected]>
> Owners-Override: [email protected] <[email protected]>
> Commit-Queue: [email protected] <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1399490}

Bug: 382540640
Change-Id: I0e783f8acad96b4bf57d715f33fef50c8af9b4a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6114634
Commit-Queue: Nico Weber <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Nico Weber <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1399535}
NOKEYCHECK=True
GitOrigin-RevId: 5886a73c34efc73f7260bffbd5e864f906e329ad
ogsts pushed a commit to ubiquiti/ubnt_libjingle_component_src_build that referenced this pull request Jan 12, 2025
…59-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1"""

This reverts commit 5886a73c34efc73f7260bffbd5e864f906e329ad.

Reason for revert: bisect suggests this commit is making
"Linux UBSan Tests"'s blink_unittests fail due to
third_party/libaom/source/libaom/av1/.
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20UBSan%20Tests/2001/overview

Original change's description:
> Reland "Reland "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1""
>
> This reverts commit b198121decca6f38503409af96a539b7ba98feed.
>
> Reason for revert: should be better after
> https://chromium-review.googlesource.com/c/chromium/src/+/6115847
>
> Original change's description:
> > Revert "Reland "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1""
> >
> > This reverts commit cb59cac5a03953631e731b8dcd145399437a1a49.
> >
> > Reason for revert:
> > LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8727971662145799313
> >
> > Sample failed build: https://ci.chromium.org/b/8727971662145799313
> >
> > If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6111305&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8727971662145799313&type=BUG
> >
> > Original change's description:
> > > Reland "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1"
> > >
> > > This reverts commit dca68566e7efca3368542b8329cad45e875ba0ae.
> > >
> > > Reason for revert: already fixed
> > >
> > > Original change's description:
> > > > Revert "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1"
> > > >
> > > > This reverts commit 32fd5de30ad9dcb9d47816e97161de85b36b63c6.
> > > >
> > > > Reason for revert: tree-closing compilation failures:
> > > > https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-arm-rel/10744
> > > > https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-arm64-rel/11108
> > > > https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-x64-rel/6736
> > > > with the error:
> > > > chromecast/browser/cast_web_contents_impl.h:182:26: error: private field 'parent_cast_web_contents_' is not used [-Werror,-Wunused-private-field]
> > > >   182 |   CastWebContents* const parent_cast_web_contents_ = nullptr;
> > > >
> > > > Original change's description:
> > > > > Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1
> > > > >
> > > > > https://chromium.googlesource.com/external/github.com/llvm/llvm-project/+log/8cb44859..091448e3
> > > > >
> > > > > https://chromium.googlesource.com/external/github.com/rust-lang/rust/+log/a522d7859841..8a1f8039a7de
> > > > >
> > > > > Ran: ./tools/clang/scripts/upload_revision.py 091448e3c17bc8e7812dd7b571c852576d648977
> > > > >
> > > > > Additionally:
> > > > > * Ran tools/rust/gnrt_stdlib.py
> > > > > * Updated //chrome/android/static_initializers.gni because it referred
> > > > >   to a static initializer in sme-abi-init.c, a file in compiler-rt that
> > > > >   was removed in llvm/llvm-project#119414.
> > > > >
> > > > > Bug: 382540640
> > > > > Disable-Rts: True
> > > > > Change-Id: I4fd6f81827ed519770048adb74430e8ec1fd849d
> > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6111009
> > > > > Auto-Submit: Alan Zhao <[email protected]>
> > > > > Commit-Queue: Zequan Wu <[email protected]>
> > > > > Commit-Queue: Alan Zhao <[email protected]>
> > > > > Reviewed-by: Zequan Wu <[email protected]>
> > > > > Cr-Commit-Position: refs/heads/main@{#1399472}
> > > >
> > > > Bug: 382540640
> > > > Change-Id: Ib8d123e61472090b0643b5617aa7a259abd8ff58
> > > > No-Presubmit: true
> > > > No-Tree-Checks: true
> > > > No-Try: true
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6108066
> > > > Owners-Override: David Baron <[email protected]>
> > > > Auto-Submit: David Baron <[email protected]>
> > > > Commit-Queue: Rubber Stamper <[email protected]>
> > > > Bot-Commit: Rubber Stamper <[email protected]>
> > > > Cr-Commit-Position: refs/heads/main@{#1399476}
> > >
> > > Bug: 382540640
> > > Change-Id: I0c6504bd82a38b6a8fddb27b080af3b639e4acc6
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6111305
> > > Commit-Queue: Alan Zhao <[email protected]>
> > > Reviewed-by: Alan Zhao <[email protected]>
> > > Bot-Commit: Rubber Stamper <[email protected]>
> > > Commit-Queue: Nico Weber <[email protected]>
> > > Cr-Commit-Position: refs/heads/main@{#1399482}
> > >
> >
> > Bug: 382540640
> > Change-Id: Ic3fc3671ab942245b89aaa461cf8e5c5331d96d2
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6116109
> > Bot-Commit: [email protected] <[email protected]>
> > Owners-Override: [email protected] <[email protected]>
> > Commit-Queue: [email protected] <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1399490}
>
> Bug: 382540640
> Change-Id: I0e783f8acad96b4bf57d715f33fef50c8af9b4a4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6114634
> Commit-Queue: Nico Weber <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Auto-Submit: Nico Weber <[email protected]>
> Commit-Queue: Rubber Stamper <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1399535}

Bug: 382540640
Change-Id: I468132e0b79883372f0b3487577b942b2e212629
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6108528
Auto-Submit: Lingqi Chi <[email protected]>
Commit-Queue: Lingqi Chi <[email protected]>
Owners-Override: Lingqi Chi <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1399706}
NOKEYCHECK=True
GitOrigin-RevId: e00908739e3a254b4a35e3ac5a61f53f7a69a75e
ogsts pushed a commit to ubiquiti/ubnt_libjingle_component_src_build that referenced this pull request Jan 12, 2025
…-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1"

This reverts commit e00908739e3a254b4a35e3ac5a61f53f7a69a75e.

Reason for revert: Passes last revert reason now, see crbug.com/385545752

Original change's description:
> Revert "Reland "Reland "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1"""
>
> This reverts commit 5886a73c34efc73f7260bffbd5e864f906e329ad.
>
> Reason for revert: bisect suggests this commit is making
> "Linux UBSan Tests"'s blink_unittests fail due to
> third_party/libaom/source/libaom/av1/.
> https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20UBSan%20Tests/2001/overview
>
>
>
> Original change's description:
> > Reland "Reland "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1""
> >
> > This reverts commit b198121decca6f38503409af96a539b7ba98feed.
> >
> > Reason for revert: should be better after
> > https://chromium-review.googlesource.com/c/chromium/src/+/6115847
> >
> > Original change's description:
> > > Revert "Reland "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1""
> > >
> > > This reverts commit cb59cac5a03953631e731b8dcd145399437a1a49.
> > >
> > > Reason for revert:
> > > LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8727971662145799313
> > >
> > > Sample failed build: https://ci.chromium.org/b/8727971662145799313
> > >
> > > If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6111305&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8727971662145799313&type=BUG
> > >
> > > Original change's description:
> > > > Reland "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1"
> > > >
> > > > This reverts commit dca68566e7efca3368542b8329cad45e875ba0ae.
> > > >
> > > > Reason for revert: already fixed
> > > >
> > > > Original change's description:
> > > > > Revert "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1"
> > > > >
> > > > > This reverts commit 32fd5de30ad9dcb9d47816e97161de85b36b63c6.
> > > > >
> > > > > Reason for revert: tree-closing compilation failures:
> > > > > https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-arm-rel/10744
> > > > > https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-arm64-rel/11108
> > > > > https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-x64-rel/6736
> > > > > with the error:
> > > > > chromecast/browser/cast_web_contents_impl.h:182:26: error: private field 'parent_cast_web_contents_' is not used [-Werror,-Wunused-private-field]
> > > > >   182 |   CastWebContents* const parent_cast_web_contents_ = nullptr;
> > > > >
> > > > > Original change's description:
> > > > > > Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1
> > > > > >
> > > > > > https://chromium.googlesource.com/external/github.com/llvm/llvm-project/+log/8cb44859..091448e3
> > > > > >
> > > > > > https://chromium.googlesource.com/external/github.com/rust-lang/rust/+log/a522d7859841..8a1f8039a7de
> > > > > >
> > > > > > Ran: ./tools/clang/scripts/upload_revision.py 091448e3c17bc8e7812dd7b571c852576d648977
> > > > > >
> > > > > > Additionally:
> > > > > > * Ran tools/rust/gnrt_stdlib.py
> > > > > > * Updated //chrome/android/static_initializers.gni because it referred
> > > > > >   to a static initializer in sme-abi-init.c, a file in compiler-rt that
> > > > > >   was removed in llvm/llvm-project#119414.
> > > > > >
> > > > > > Bug: 382540640
> > > > > > Disable-Rts: True
> > > > > > Change-Id: I4fd6f81827ed519770048adb74430e8ec1fd849d
> > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6111009
> > > > > > Auto-Submit: Alan Zhao <[email protected]>
> > > > > > Commit-Queue: Zequan Wu <[email protected]>
> > > > > > Commit-Queue: Alan Zhao <[email protected]>
> > > > > > Reviewed-by: Zequan Wu <[email protected]>
> > > > > > Cr-Commit-Position: refs/heads/main@{#1399472}
> > > > >
> > > > > Bug: 382540640
> > > > > Change-Id: Ib8d123e61472090b0643b5617aa7a259abd8ff58
> > > > > No-Presubmit: true
> > > > > No-Tree-Checks: true
> > > > > No-Try: true
> > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6108066
> > > > > Owners-Override: David Baron <[email protected]>
> > > > > Auto-Submit: David Baron <[email protected]>
> > > > > Commit-Queue: Rubber Stamper <[email protected]>
> > > > > Bot-Commit: Rubber Stamper <[email protected]>
> > > > > Cr-Commit-Position: refs/heads/main@{#1399476}
> > > >
> > > > Bug: 382540640
> > > > Change-Id: I0c6504bd82a38b6a8fddb27b080af3b639e4acc6
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6111305
> > > > Commit-Queue: Alan Zhao <[email protected]>
> > > > Reviewed-by: Alan Zhao <[email protected]>
> > > > Bot-Commit: Rubber Stamper <[email protected]>
> > > > Commit-Queue: Nico Weber <[email protected]>
> > > > Cr-Commit-Position: refs/heads/main@{#1399482}
> > > >
> > >
> > > Bug: 382540640
> > > Change-Id: Ic3fc3671ab942245b89aaa461cf8e5c5331d96d2
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6116109
> > > Bot-Commit: [email protected] <[email protected]>
> > > Owners-Override: [email protected] <[email protected]>
> > > Commit-Queue: [email protected] <[email protected]>
> > > Cr-Commit-Position: refs/heads/main@{#1399490}
> >
> > Bug: 382540640
> > Change-Id: I0e783f8acad96b4bf57d715f33fef50c8af9b4a4
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6114634
> > Commit-Queue: Nico Weber <[email protected]>
> > Bot-Commit: Rubber Stamper <[email protected]>
> > Auto-Submit: Nico Weber <[email protected]>
> > Commit-Queue: Rubber Stamper <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1399535}
>
> Bug: 382540640
> Change-Id: I468132e0b79883372f0b3487577b942b2e212629
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6108528
> Auto-Submit: Lingqi Chi <[email protected]>
> Commit-Queue: Lingqi Chi <[email protected]>
> Owners-Override: Lingqi Chi <[email protected]>
> Commit-Queue: Rubber Stamper <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1399706}

Bug: 382540640,385545752
Change-Id: I748d35167b0a05a9f01976226d311f387e1d193e
Cq-Include-Trybots: luci.chromium.try:linux_chromium_ubsan_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6133672
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1401445}
NOKEYCHECK=True
GitOrigin-RevId: 165d16321d1ff98f997d633844c9ce7252d8ad99
oneseer pushed a commit to oneseer/rust that referenced this pull request May 24, 2025
…6062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1

https://chromium.googlesource.com/external/github.com/llvm/llvm-project/+log/8cb44859..091448e3

https://chromium.googlesource.com/external/github.com/rust-lang/rust/+log/a522d7859841..8a1f8039a7de

Ran: ./tools/clang/scripts/upload_revision.py 091448e3c17bc8e7812dd7b571c852576d648977

Additionally:
* Ran tools/rust/gnrt_stdlib.py
* Updated //chrome/android/static_initializers.gni because it referred
  to a static initializer in sme-abi-init.c, a file in compiler-rt that
  was removed in llvm/llvm-project#119414.

Bug: 382540640
Disable-Rts: True
Change-Id: I4fd6f81827ed519770048adb74430e8ec1fd849d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6111009
Auto-Submit: Alan Zhao <[email protected]>
Commit-Queue: Zequan Wu <[email protected]>
Commit-Queue: Alan Zhao <[email protected]>
Reviewed-by: Zequan Wu <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1399472}
NOKEYCHECK=True
GitOrigin-RevId: 32fd5de30ad9dcb9d47816e97161de85b36b63c6
oneseer pushed a commit to oneseer/rust that referenced this pull request May 24, 2025
…0-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1"

This reverts commit 32fd5de30ad9dcb9d47816e97161de85b36b63c6.

Reason for revert: tree-closing compilation failures:
https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-arm-rel/10744
https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-arm64-rel/11108
https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-x64-rel/6736
with the error:
chromecast/browser/cast_web_contents_impl.h:182:26: error: private field 'parent_cast_web_contents_' is not used [-Werror,-Wunused-private-field]
  182 |   CastWebContents* const parent_cast_web_contents_ = nullptr;

Original change's description:
> Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1
>
> https://chromium.googlesource.com/external/github.com/llvm/llvm-project/+log/8cb44859..091448e3
>
> https://chromium.googlesource.com/external/github.com/rust-lang/rust/+log/a522d7859841..8a1f8039a7de
>
> Ran: ./tools/clang/scripts/upload_revision.py 091448e3c17bc8e7812dd7b571c852576d648977
>
> Additionally:
> * Ran tools/rust/gnrt_stdlib.py
> * Updated //chrome/android/static_initializers.gni because it referred
>   to a static initializer in sme-abi-init.c, a file in compiler-rt that
>   was removed in llvm/llvm-project#119414.
>
> Bug: 382540640
> Disable-Rts: True
> Change-Id: I4fd6f81827ed519770048adb74430e8ec1fd849d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6111009
> Auto-Submit: Alan Zhao <[email protected]>
> Commit-Queue: Zequan Wu <[email protected]>
> Commit-Queue: Alan Zhao <[email protected]>
> Reviewed-by: Zequan Wu <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1399472}

Bug: 382540640
Change-Id: Ib8d123e61472090b0643b5617aa7a259abd8ff58
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6108066
Owners-Override: David Baron <[email protected]>
Auto-Submit: David Baron <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1399476}
NOKEYCHECK=True
GitOrigin-RevId: dca68566e7efca3368542b8329cad45e875ba0ae
oneseer pushed a commit to oneseer/rust that referenced this pull request May 24, 2025
…0-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1"

This reverts commit dca68566e7efca3368542b8329cad45e875ba0ae.

Reason for revert: already fixed

Original change's description:
> Revert "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1"
>
> This reverts commit 32fd5de30ad9dcb9d47816e97161de85b36b63c6.
>
> Reason for revert: tree-closing compilation failures:
> https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-arm-rel/10744
> https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-arm64-rel/11108
> https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-x64-rel/6736
> with the error:
> chromecast/browser/cast_web_contents_impl.h:182:26: error: private field 'parent_cast_web_contents_' is not used [-Werror,-Wunused-private-field]
>   182 |   CastWebContents* const parent_cast_web_contents_ = nullptr;
>
> Original change's description:
> > Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1
> >
> > https://chromium.googlesource.com/external/github.com/llvm/llvm-project/+log/8cb44859..091448e3
> >
> > https://chromium.googlesource.com/external/github.com/rust-lang/rust/+log/a522d7859841..8a1f8039a7de
> >
> > Ran: ./tools/clang/scripts/upload_revision.py 091448e3c17bc8e7812dd7b571c852576d648977
> >
> > Additionally:
> > * Ran tools/rust/gnrt_stdlib.py
> > * Updated //chrome/android/static_initializers.gni because it referred
> >   to a static initializer in sme-abi-init.c, a file in compiler-rt that
> >   was removed in llvm/llvm-project#119414.
> >
> > Bug: 382540640
> > Disable-Rts: True
> > Change-Id: I4fd6f81827ed519770048adb74430e8ec1fd849d
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6111009
> > Auto-Submit: Alan Zhao <[email protected]>
> > Commit-Queue: Zequan Wu <[email protected]>
> > Commit-Queue: Alan Zhao <[email protected]>
> > Reviewed-by: Zequan Wu <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1399472}
>
> Bug: 382540640
> Change-Id: Ib8d123e61472090b0643b5617aa7a259abd8ff58
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6108066
> Owners-Override: David Baron <[email protected]>
> Auto-Submit: David Baron <[email protected]>
> Commit-Queue: Rubber Stamper <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1399476}

Bug: 382540640
Change-Id: I0c6504bd82a38b6a8fddb27b080af3b639e4acc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6111305
Commit-Queue: Alan Zhao <[email protected]>
Reviewed-by: Alan Zhao <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1399482}
NOKEYCHECK=True
GitOrigin-RevId: cb59cac5a03953631e731b8dcd145399437a1a49
oneseer pushed a commit to oneseer/rust that referenced this pull request May 24, 2025
…lvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1""

This reverts commit cb59cac5a03953631e731b8dcd145399437a1a49.

Reason for revert:
LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8727971662145799313

Sample failed build: https://ci.chromium.org/b/8727971662145799313

If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6111305&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8727971662145799313&type=BUG

Original change's description:
> Reland "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1"
>
> This reverts commit dca68566e7efca3368542b8329cad45e875ba0ae.
>
> Reason for revert: already fixed
>
> Original change's description:
> > Revert "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1"
> >
> > This reverts commit 32fd5de30ad9dcb9d47816e97161de85b36b63c6.
> >
> > Reason for revert: tree-closing compilation failures:
> > https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-arm-rel/10744
> > https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-arm64-rel/11108
> > https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-x64-rel/6736
> > with the error:
> > chromecast/browser/cast_web_contents_impl.h:182:26: error: private field 'parent_cast_web_contents_' is not used [-Werror,-Wunused-private-field]
> >   182 |   CastWebContents* const parent_cast_web_contents_ = nullptr;
> >
> > Original change's description:
> > > Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1
> > >
> > > https://chromium.googlesource.com/external/github.com/llvm/llvm-project/+log/8cb44859..091448e3
> > >
> > > https://chromium.googlesource.com/external/github.com/rust-lang/rust/+log/a522d7859841..8a1f8039a7de
> > >
> > > Ran: ./tools/clang/scripts/upload_revision.py 091448e3c17bc8e7812dd7b571c852576d648977
> > >
> > > Additionally:
> > > * Ran tools/rust/gnrt_stdlib.py
> > > * Updated //chrome/android/static_initializers.gni because it referred
> > >   to a static initializer in sme-abi-init.c, a file in compiler-rt that
> > >   was removed in llvm/llvm-project#119414.
> > >
> > > Bug: 382540640
> > > Disable-Rts: True
> > > Change-Id: I4fd6f81827ed519770048adb74430e8ec1fd849d
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6111009
> > > Auto-Submit: Alan Zhao <[email protected]>
> > > Commit-Queue: Zequan Wu <[email protected]>
> > > Commit-Queue: Alan Zhao <[email protected]>
> > > Reviewed-by: Zequan Wu <[email protected]>
> > > Cr-Commit-Position: refs/heads/main@{#1399472}
> >
> > Bug: 382540640
> > Change-Id: Ib8d123e61472090b0643b5617aa7a259abd8ff58
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6108066
> > Owners-Override: David Baron <[email protected]>
> > Auto-Submit: David Baron <[email protected]>
> > Commit-Queue: Rubber Stamper <[email protected]>
> > Bot-Commit: Rubber Stamper <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1399476}
>
> Bug: 382540640
> Change-Id: I0c6504bd82a38b6a8fddb27b080af3b639e4acc6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6111305
> Commit-Queue: Alan Zhao <[email protected]>
> Reviewed-by: Alan Zhao <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Commit-Queue: Nico Weber <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1399482}
>

Bug: 382540640
Change-Id: Ic3fc3671ab942245b89aaa461cf8e5c5331d96d2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6116109
Bot-Commit: [email protected] <[email protected]>
Owners-Override: [email protected] <[email protected]>
Commit-Queue: [email protected] <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1399490}
NOKEYCHECK=True
GitOrigin-RevId: b198121decca6f38503409af96a539b7ba98feed
oneseer pushed a commit to oneseer/rust that referenced this pull request May 24, 2025
…lvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1""

This reverts commit b198121decca6f38503409af96a539b7ba98feed.

Reason for revert: should be better after
https://chromium-review.googlesource.com/c/chromium/src/+/6115847

Original change's description:
> Revert "Reland "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1""
>
> This reverts commit cb59cac5a03953631e731b8dcd145399437a1a49.
>
> Reason for revert:
> LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8727971662145799313
>
> Sample failed build: https://ci.chromium.org/b/8727971662145799313
>
> If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6111305&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8727971662145799313&type=BUG
>
> Original change's description:
> > Reland "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1"
> >
> > This reverts commit dca68566e7efca3368542b8329cad45e875ba0ae.
> >
> > Reason for revert: already fixed
> >
> > Original change's description:
> > > Revert "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1"
> > >
> > > This reverts commit 32fd5de30ad9dcb9d47816e97161de85b36b63c6.
> > >
> > > Reason for revert: tree-closing compilation failures:
> > > https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-arm-rel/10744
> > > https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-arm64-rel/11108
> > > https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-x64-rel/6736
> > > with the error:
> > > chromecast/browser/cast_web_contents_impl.h:182:26: error: private field 'parent_cast_web_contents_' is not used [-Werror,-Wunused-private-field]
> > >   182 |   CastWebContents* const parent_cast_web_contents_ = nullptr;
> > >
> > > Original change's description:
> > > > Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1
> > > >
> > > > https://chromium.googlesource.com/external/github.com/llvm/llvm-project/+log/8cb44859..091448e3
> > > >
> > > > https://chromium.googlesource.com/external/github.com/rust-lang/rust/+log/a522d7859841..8a1f8039a7de
> > > >
> > > > Ran: ./tools/clang/scripts/upload_revision.py 091448e3c17bc8e7812dd7b571c852576d648977
> > > >
> > > > Additionally:
> > > > * Ran tools/rust/gnrt_stdlib.py
> > > > * Updated //chrome/android/static_initializers.gni because it referred
> > > >   to a static initializer in sme-abi-init.c, a file in compiler-rt that
> > > >   was removed in llvm/llvm-project#119414.
> > > >
> > > > Bug: 382540640
> > > > Disable-Rts: True
> > > > Change-Id: I4fd6f81827ed519770048adb74430e8ec1fd849d
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6111009
> > > > Auto-Submit: Alan Zhao <[email protected]>
> > > > Commit-Queue: Zequan Wu <[email protected]>
> > > > Commit-Queue: Alan Zhao <[email protected]>
> > > > Reviewed-by: Zequan Wu <[email protected]>
> > > > Cr-Commit-Position: refs/heads/main@{#1399472}
> > >
> > > Bug: 382540640
> > > Change-Id: Ib8d123e61472090b0643b5617aa7a259abd8ff58
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6108066
> > > Owners-Override: David Baron <[email protected]>
> > > Auto-Submit: David Baron <[email protected]>
> > > Commit-Queue: Rubber Stamper <[email protected]>
> > > Bot-Commit: Rubber Stamper <[email protected]>
> > > Cr-Commit-Position: refs/heads/main@{#1399476}
> >
> > Bug: 382540640
> > Change-Id: I0c6504bd82a38b6a8fddb27b080af3b639e4acc6
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6111305
> > Commit-Queue: Alan Zhao <[email protected]>
> > Reviewed-by: Alan Zhao <[email protected]>
> > Bot-Commit: Rubber Stamper <[email protected]>
> > Commit-Queue: Nico Weber <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1399482}
> >
>
> Bug: 382540640
> Change-Id: Ic3fc3671ab942245b89aaa461cf8e5c5331d96d2
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6116109
> Bot-Commit: [email protected] <[email protected]>
> Owners-Override: [email protected] <[email protected]>
> Commit-Queue: [email protected] <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1399490}

Bug: 382540640
Change-Id: I0e783f8acad96b4bf57d715f33fef50c8af9b4a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6114634
Commit-Queue: Nico Weber <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Auto-Submit: Nico Weber <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1399535}
NOKEYCHECK=True
GitOrigin-RevId: 5886a73c34efc73f7260bffbd5e864f906e329ad
oneseer pushed a commit to oneseer/rust that referenced this pull request May 24, 2025
…59-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1"""

This reverts commit 5886a73c34efc73f7260bffbd5e864f906e329ad.

Reason for revert: bisect suggests this commit is making
"Linux UBSan Tests"'s blink_unittests fail due to
third_party/libaom/source/libaom/av1/.
https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20UBSan%20Tests/2001/overview

Original change's description:
> Reland "Reland "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1""
>
> This reverts commit b198121decca6f38503409af96a539b7ba98feed.
>
> Reason for revert: should be better after
> https://chromium-review.googlesource.com/c/chromium/src/+/6115847
>
> Original change's description:
> > Revert "Reland "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1""
> >
> > This reverts commit cb59cac5a03953631e731b8dcd145399437a1a49.
> >
> > Reason for revert:
> > LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8727971662145799313
> >
> > Sample failed build: https://ci.chromium.org/b/8727971662145799313
> >
> > If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6111305&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8727971662145799313&type=BUG
> >
> > Original change's description:
> > > Reland "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1"
> > >
> > > This reverts commit dca68566e7efca3368542b8329cad45e875ba0ae.
> > >
> > > Reason for revert: already fixed
> > >
> > > Original change's description:
> > > > Revert "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1"
> > > >
> > > > This reverts commit 32fd5de30ad9dcb9d47816e97161de85b36b63c6.
> > > >
> > > > Reason for revert: tree-closing compilation failures:
> > > > https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-arm-rel/10744
> > > > https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-arm64-rel/11108
> > > > https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-x64-rel/6736
> > > > with the error:
> > > > chromecast/browser/cast_web_contents_impl.h:182:26: error: private field 'parent_cast_web_contents_' is not used [-Werror,-Wunused-private-field]
> > > >   182 |   CastWebContents* const parent_cast_web_contents_ = nullptr;
> > > >
> > > > Original change's description:
> > > > > Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1
> > > > >
> > > > > https://chromium.googlesource.com/external/github.com/llvm/llvm-project/+log/8cb44859..091448e3
> > > > >
> > > > > https://chromium.googlesource.com/external/github.com/rust-lang/rust/+log/a522d7859841..8a1f8039a7de
> > > > >
> > > > > Ran: ./tools/clang/scripts/upload_revision.py 091448e3c17bc8e7812dd7b571c852576d648977
> > > > >
> > > > > Additionally:
> > > > > * Ran tools/rust/gnrt_stdlib.py
> > > > > * Updated //chrome/android/static_initializers.gni because it referred
> > > > >   to a static initializer in sme-abi-init.c, a file in compiler-rt that
> > > > >   was removed in llvm/llvm-project#119414.
> > > > >
> > > > > Bug: 382540640
> > > > > Disable-Rts: True
> > > > > Change-Id: I4fd6f81827ed519770048adb74430e8ec1fd849d
> > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6111009
> > > > > Auto-Submit: Alan Zhao <[email protected]>
> > > > > Commit-Queue: Zequan Wu <[email protected]>
> > > > > Commit-Queue: Alan Zhao <[email protected]>
> > > > > Reviewed-by: Zequan Wu <[email protected]>
> > > > > Cr-Commit-Position: refs/heads/main@{#1399472}
> > > >
> > > > Bug: 382540640
> > > > Change-Id: Ib8d123e61472090b0643b5617aa7a259abd8ff58
> > > > No-Presubmit: true
> > > > No-Tree-Checks: true
> > > > No-Try: true
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6108066
> > > > Owners-Override: David Baron <[email protected]>
> > > > Auto-Submit: David Baron <[email protected]>
> > > > Commit-Queue: Rubber Stamper <[email protected]>
> > > > Bot-Commit: Rubber Stamper <[email protected]>
> > > > Cr-Commit-Position: refs/heads/main@{#1399476}
> > >
> > > Bug: 382540640
> > > Change-Id: I0c6504bd82a38b6a8fddb27b080af3b639e4acc6
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6111305
> > > Commit-Queue: Alan Zhao <[email protected]>
> > > Reviewed-by: Alan Zhao <[email protected]>
> > > Bot-Commit: Rubber Stamper <[email protected]>
> > > Commit-Queue: Nico Weber <[email protected]>
> > > Cr-Commit-Position: refs/heads/main@{#1399482}
> > >
> >
> > Bug: 382540640
> > Change-Id: Ic3fc3671ab942245b89aaa461cf8e5c5331d96d2
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6116109
> > Bot-Commit: [email protected] <[email protected]>
> > Owners-Override: [email protected] <[email protected]>
> > Commit-Queue: [email protected] <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1399490}
>
> Bug: 382540640
> Change-Id: I0e783f8acad96b4bf57d715f33fef50c8af9b4a4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6114634
> Commit-Queue: Nico Weber <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Auto-Submit: Nico Weber <[email protected]>
> Commit-Queue: Rubber Stamper <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1399535}

Bug: 382540640
Change-Id: I468132e0b79883372f0b3487577b942b2e212629
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6108528
Auto-Submit: Lingqi Chi <[email protected]>
Commit-Queue: Lingqi Chi <[email protected]>
Owners-Override: Lingqi Chi <[email protected]>
Commit-Queue: Rubber Stamper <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1399706}
NOKEYCHECK=True
GitOrigin-RevId: e00908739e3a254b4a35e3ac5a61f53f7a69a75e
oneseer pushed a commit to oneseer/rust that referenced this pull request May 24, 2025
…-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1"

This reverts commit e00908739e3a254b4a35e3ac5a61f53f7a69a75e.

Reason for revert: Passes last revert reason now, see crbug.com/385545752

Original change's description:
> Revert "Reland "Reland "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1"""
>
> This reverts commit 5886a73c34efc73f7260bffbd5e864f906e329ad.
>
> Reason for revert: bisect suggests this commit is making
> "Linux UBSan Tests"'s blink_unittests fail due to
> third_party/libaom/source/libaom/av1/.
> https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20UBSan%20Tests/2001/overview
>
>
>
> Original change's description:
> > Reland "Reland "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1""
> >
> > This reverts commit b198121decca6f38503409af96a539b7ba98feed.
> >
> > Reason for revert: should be better after
> > https://chromium-review.googlesource.com/c/chromium/src/+/6115847
> >
> > Original change's description:
> > > Revert "Reland "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1""
> > >
> > > This reverts commit cb59cac5a03953631e731b8dcd145399437a1a49.
> > >
> > > Reason for revert:
> > > LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8727971662145799313
> > >
> > > Sample failed build: https://ci.chromium.org/b/8727971662145799313
> > >
> > > If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6111305&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8727971662145799313&type=BUG
> > >
> > > Original change's description:
> > > > Reland "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1"
> > > >
> > > > This reverts commit dca68566e7efca3368542b8329cad45e875ba0ae.
> > > >
> > > > Reason for revert: already fixed
> > > >
> > > > Original change's description:
> > > > > Revert "Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1"
> > > > >
> > > > > This reverts commit 32fd5de30ad9dcb9d47816e97161de85b36b63c6.
> > > > >
> > > > > Reason for revert: tree-closing compilation failures:
> > > > > https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-arm-rel/10744
> > > > > https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-arm64-rel/11108
> > > > > https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-x64-rel/6736
> > > > > with the error:
> > > > > chromecast/browser/cast_web_contents_impl.h:182:26: error: private field 'parent_cast_web_contents_' is not used [-Werror,-Wunused-private-field]
> > > > >   182 |   CastWebContents* const parent_cast_web_contents_ = nullptr;
> > > > >
> > > > > Original change's description:
> > > > > > Roll clang+rust llvmorg-20-init-13894-g8cb44859-1 : llvmorg-20-init-16062-g091448e3-1 / a522d78598415cdd614ccc6d961160f192f64b5c-1 : 8a1f8039a7ded79d3d4fe97b110016d89f2b11e2-1
> > > > > >
> > > > > > https://chromium.googlesource.com/external/github.com/llvm/llvm-project/+log/8cb44859..091448e3
> > > > > >
> > > > > > https://chromium.googlesource.com/external/github.com/rust-lang/rust/+log/a522d7859841..8a1f8039a7de
> > > > > >
> > > > > > Ran: ./tools/clang/scripts/upload_revision.py 091448e3c17bc8e7812dd7b571c852576d648977
> > > > > >
> > > > > > Additionally:
> > > > > > * Ran tools/rust/gnrt_stdlib.py
> > > > > > * Updated //chrome/android/static_initializers.gni because it referred
> > > > > >   to a static initializer in sme-abi-init.c, a file in compiler-rt that
> > > > > >   was removed in llvm/llvm-project#119414.
> > > > > >
> > > > > > Bug: 382540640
> > > > > > Disable-Rts: True
> > > > > > Change-Id: I4fd6f81827ed519770048adb74430e8ec1fd849d
> > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6111009
> > > > > > Auto-Submit: Alan Zhao <[email protected]>
> > > > > > Commit-Queue: Zequan Wu <[email protected]>
> > > > > > Commit-Queue: Alan Zhao <[email protected]>
> > > > > > Reviewed-by: Zequan Wu <[email protected]>
> > > > > > Cr-Commit-Position: refs/heads/main@{#1399472}
> > > > >
> > > > > Bug: 382540640
> > > > > Change-Id: Ib8d123e61472090b0643b5617aa7a259abd8ff58
> > > > > No-Presubmit: true
> > > > > No-Tree-Checks: true
> > > > > No-Try: true
> > > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6108066
> > > > > Owners-Override: David Baron <[email protected]>
> > > > > Auto-Submit: David Baron <[email protected]>
> > > > > Commit-Queue: Rubber Stamper <[email protected]>
> > > > > Bot-Commit: Rubber Stamper <[email protected]>
> > > > > Cr-Commit-Position: refs/heads/main@{#1399476}
> > > >
> > > > Bug: 382540640
> > > > Change-Id: I0c6504bd82a38b6a8fddb27b080af3b639e4acc6
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6111305
> > > > Commit-Queue: Alan Zhao <[email protected]>
> > > > Reviewed-by: Alan Zhao <[email protected]>
> > > > Bot-Commit: Rubber Stamper <[email protected]>
> > > > Commit-Queue: Nico Weber <[email protected]>
> > > > Cr-Commit-Position: refs/heads/main@{#1399482}
> > > >
> > >
> > > Bug: 382540640
> > > Change-Id: Ic3fc3671ab942245b89aaa461cf8e5c5331d96d2
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6116109
> > > Bot-Commit: [email protected] <[email protected]>
> > > Owners-Override: [email protected] <[email protected]>
> > > Commit-Queue: [email protected] <[email protected]>
> > > Cr-Commit-Position: refs/heads/main@{#1399490}
> >
> > Bug: 382540640
> > Change-Id: I0e783f8acad96b4bf57d715f33fef50c8af9b4a4
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6114634
> > Commit-Queue: Nico Weber <[email protected]>
> > Bot-Commit: Rubber Stamper <[email protected]>
> > Auto-Submit: Nico Weber <[email protected]>
> > Commit-Queue: Rubber Stamper <[email protected]>
> > Cr-Commit-Position: refs/heads/main@{#1399535}
>
> Bug: 382540640
> Change-Id: I468132e0b79883372f0b3487577b942b2e212629
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6108528
> Auto-Submit: Lingqi Chi <[email protected]>
> Commit-Queue: Lingqi Chi <[email protected]>
> Owners-Override: Lingqi Chi <[email protected]>
> Commit-Queue: Rubber Stamper <[email protected]>
> Bot-Commit: Rubber Stamper <[email protected]>
> Cr-Commit-Position: refs/heads/main@{#1399706}

Bug: 382540640,385545752
Change-Id: I748d35167b0a05a9f01976226d311f387e1d193e
Cq-Include-Trybots: luci.chromium.try:linux_chromium_ubsan_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6133672
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Nico Weber <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1401445}
NOKEYCHECK=True
GitOrigin-RevId: 165d16321d1ff98f997d633844c9ce7252d8ad99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants