DiagnosticPrinter: Use printAsOperand to handle anonymous values

[arsenm]

To avoid changing the behavior in the general case, only do this
for anonymous functions. Otherwise, we'll end up with a leading
'@' on the name, which may not be meaningful to end users.

[arsenm]

• RegAlloc: Fix verifier error after failed allocation #119690
• AMDGPU: Delete spills of undef values #119684
• [Statepoint] Treat undef operands less specially #119682
• RegAlloc: Fix failure on undef use when all registers are reserved #119647
• RegAlloc: Do not fatal error if there are no registers in the alloc order #119640
• RegAlloc: Use DiagnosticInfo to report register allocation failures #119492
• DiagnosticPrinter: Use printAsOperand to handle anonymous values #119491 👈 (View in Graphite)
• DiagnosticInfo: Clean up usage of DiagnosticInfoInlineAsm #119485
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[llvmbot]

@llvm/pr-subscribers-backend-arm
@llvm/pr-subscribers-backend-amdgpu
@llvm/pr-subscribers-llvm-selectiondag

@llvm/pr-subscribers-llvm-ir

Author: Matt Arsenault (arsenm)

Changes

To avoid changing the behavior in the general case, only do this
for anonymous functions. Otherwise, we'll end up with a leading
'@' on the name, which may not be meaningful to end users.

---

Full diff: https://github.com/llvm/llvm-project/pull/119491.diff

1 Files Affected:

• (modified) llvm/lib/IR/DiagnosticPrinter.cpp (+6-1)

diff --git a/llvm/lib/IR/DiagnosticPrinter.cpp b/llvm/lib/IR/DiagnosticPrinter.cpp
index 49b8bbae53be9e..5ded23403b41e6 100644
--- a/llvm/lib/IR/DiagnosticPrinter.cpp
+++ b/llvm/lib/IR/DiagnosticPrinter.cpp
@@ -97,7 +97,12 @@ DiagnosticPrinter &DiagnosticPrinterRawOStream::operator<<(const Twine &Str) {
 
 // IR related types.
 DiagnosticPrinter &DiagnosticPrinterRawOStream::operator<<(const Value &V) {
-  Stream << V.getName();
+  // Avoid printing '@' prefix for named functions.
+  if (V.hasName())
+    Stream << V.getName();
+  else
+    V.printAsOperand(Stream, /*PrintType=*/false);
+
   return *this;
 }
 

[aeubanks]

can you add a test?

[arsenm]

can you add a test?

See next up the stack

[arsenm]

Merge activity

• Dec 11, 3:11 AM EST: A user started a stack merge that includes this pull request via Graphite.
• Dec 11, 3:16 AM EST: Graphite rebased this pull request as part of a merge.
• Dec 11, 3:19 AM EST: A user merged this pull request with Graphite.