Skip to content

[RISCV] Refactor helper in isDesirableToCommuteWithShift. NFC #119526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2024
Merged

[RISCV] Refactor helper in isDesirableToCommuteWithShift. NFC #119526

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 10 additions & 30 deletions llvm/lib/Target/RISCV/RISCVISelLowering.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18237,41 +18237,21 @@ bool RISCVTargetLowering::isDesirableToCommuteWithShift(
// LD/ST will optimize constant Offset extraction, so when AddNode is used by
// LD/ST, it can still complete the folding optimization operation performed
// above.
auto isUsedByLdSt = [&]() {
bool CanOptAlways = false;
if (N0->getOpcode() == ISD::ADD && !N0->hasOneUse()) {
for (SDNode *Use : N0->uses()) {
// This use is the one we're on right now. Skip it
if (Use == N || Use->getOpcode() == ISD::SELECT)
continue;
if (!isa<StoreSDNode>(Use) && !isa<LoadSDNode>(Use)) {
CanOptAlways = false;
break;
}
CanOptAlways = true;
}
}

if (N0->getOpcode() == ISD::SIGN_EXTEND &&
!N0->getOperand(0)->hasOneUse()) {
for (SDNode *Use : N0->getOperand(0)->uses()) {
// This use is the one we're on right now. Skip it
if (Use == N0.getNode() || Use->getOpcode() == ISD::SELECT)
continue;
if (!isa<StoreSDNode>(Use) && !isa<LoadSDNode>(Use)) {
CanOptAlways = false;
break;
}
CanOptAlways = true;
}
auto isUsedByLdSt = [](const SDNode *X, const SDNode *User) {
for (SDNode *Use : X->uses()) {
// This use is the one we're on right now. Skip it
if (Use == User || Use->getOpcode() == ISD::SELECT)
continue;
if (!isa<StoreSDNode>(Use) && !isa<LoadSDNode>(Use))
return false;
}
return CanOptAlways;
return true;
};

if (Ty.isScalarInteger() &&
(N0.getOpcode() == ISD::ADD || N0.getOpcode() == ISD::OR)) {
if (N0.getOpcode() == ISD::ADD && !N0->hasOneUse())
return isUsedByLdSt();
return isUsedByLdSt(N0.getNode(), N);

auto *C1 = dyn_cast<ConstantSDNode>(N0->getOperand(1));
auto *C2 = dyn_cast<ConstantSDNode>(N->getOperand(1));
Expand Down Expand Up @@ -18314,7 +18294,7 @@ bool RISCVTargetLowering::isDesirableToCommuteWithShift(
if (N0->getOpcode() == ISD::SIGN_EXTEND &&
N0->getOperand(0)->getOpcode() == ISD::ADD &&
!N0->getOperand(0)->hasOneUse())
return isUsedByLdSt();
return isUsedByLdSt(N0->getOperand(0).getNode(), N0.getNode());

return true;
}
Expand Down
Loading