Skip to content

[CI] Refactor common functionality into separate script #119530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

boomanaiden154
Copy link
Contributor

This patch refactors some common functionality present in the CI scripts to a separate shell script. This is mainly intended to make it easier to reuse this functionality inside of a Github Actions pipeline as we make the switch.

This patch refactors some common functionality present in the CI scripts
to a separate shell script. This is mainly intended to make it easier to
reuse this functionality inside of a Github Actions pipeline as we make
the switch.
@boomanaiden154 boomanaiden154 force-pushed the users/boomanaiden154/refactor-buildkite-shell-scripts branch 2 times, most recently from cad1870 to 1c020bb Compare December 11, 2024 23:05
@boomanaiden154
Copy link
Contributor Author

This is mainly to enable setting up Github Actions Workflows using the existing CI scripts (like #119635).

@boomanaiden154 boomanaiden154 marked this pull request as ready for review December 13, 2024 03:56
Copy link
Collaborator

@DavidSpickett DavidSpickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a simple move, nothing controversial.

Any big changes to the code are best done when the new system is stable anyway.

Copy link
Contributor

@Endilll Endilll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish those scripts were written in Python. But alas, not in the scope of this PR.

@boomanaiden154
Copy link
Contributor Author

Any big changes to the code are best done when the new system is stable anyway.

Agreed. I'm trying to bring up the new system with minimal changes to the existing setup and then we can iterate from there once that is stable and we deprecate the old system.

I wish those scripts were written in Python. But alas, not in the scope of this PR.

Yeah, I'm not the biggest fan of bash scripts. Something easier to write unit/regression tests against would be particularly nice. We'll have to make some decently big changes once the new system is stable to better take advantage of Github Actions, so I expect some migration to take place with that work.

@boomanaiden154 boomanaiden154 merged commit d6cc140 into main Dec 13, 2024
6 checks passed
@boomanaiden154 boomanaiden154 deleted the users/boomanaiden154/refactor-buildkite-shell-scripts branch December 13, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants