Skip to content

[flang][unittests] fix test broken when run as root #119604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

tblah
Copy link
Contributor

@tblah tblah commented Dec 11, 2024

It is convenient to run tests as root inside of a docker container.

The test (and the library function it is testing) are already unsupported on Windows so it is safe to use UNIX-isms here.

It is convenient to run tests as root inside of a docker container.

The test (and the library function it is testing) are already
unsupported on Windows so it is safe to use UNIX-isms here.
@llvmbot llvmbot added the flang Flang issues not falling into any other category label Dec 11, 2024
Copy link
Contributor

@pawosm-arm pawosm-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming you're following the encountered coding style.

Copy link
Member

@DavidTruby DavidTruby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Might it be worth adding a #ifdef _WIN32 just in case we do end up supporting the functions that make sense here on Windows (read and write I guess)?
E.g. #ifdef _WIN32 return false;

@tblah tblah merged commit 32403f7 into llvm:main Dec 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flang Flang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants