Skip to content

[flang][rt][device] Use enum-set.h as Fortran.h #119611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

clementval
Copy link
Contributor

The code in flang/include/flang/Common/Fortran-consts.h was taken from flang/include/flang/Common/Fortran.h where we use enum-set.h and not enum-class.h. This was making some of our downstream device build failing.

@llvmbot llvmbot added the flang Flang issues not falling into any other category label Dec 11, 2024
Copy link
Contributor

@vzakhari vzakhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clementval clementval merged commit 151901c into llvm:main Dec 11, 2024
10 checks passed
@clementval clementval deleted the flang_rt_enum branch December 11, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flang Flang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants