[AMDGPU][CodeGen] Do not backtrace invalid -regalloc param #119687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-backend-amdgpu Author: Akshat Oke (optimisan) ChangesNo need to generate a stack trace and a GitHub issue prompt on a wrongly set regalloc option. Full diff: https://github.com/llvm/llvm-project/pull/119687.diff 1 Files Affected:
diff --git a/llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp b/llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
index 34ad99dd980f27..c0dace31393fd7 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
+++ b/llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
@@ -1549,7 +1549,7 @@ static const char RegAllocOptNotSupportedMessage[] =
bool GCNPassConfig::addRegAssignAndRewriteFast() {
if (!usingDefaultRegAlloc())
- report_fatal_error(RegAllocOptNotSupportedMessage);
+ report_fatal_error(RegAllocOptNotSupportedMessage, /*GenCrashDiag=*/false);
addPass(&GCNPreRALongBranchRegID);
@@ -1575,7 +1575,7 @@ bool GCNPassConfig::addRegAssignAndRewriteFast() {
bool GCNPassConfig::addRegAssignAndRewriteOptimized() {
if (!usingDefaultRegAlloc())
- report_fatal_error(RegAllocOptNotSupportedMessage);
+ report_fatal_error(RegAllocOptNotSupportedMessage, /*GenCrashDiag=*/false);
addPass(&GCNPreRALongBranchRegID);
|
arsenm
approved these changes
Dec 12, 2024
|
Thanks, I'll look into that. |
|
Something is broken here https://lab.llvm.org/buildbot/#/builders/55/builds/4246 |
kstoimenov
added a commit
that referenced
this pull request
Dec 14, 2024
…119687)" Causes bot failure: https://lab.llvm.org/buildbot/#/builders/55/builds/4246/steps/11/logs/stdio This reverts commit 7a64855.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to generate a stack trace and a GitHub issue prompt on a wrongly set regalloc option.