[BOLT] Require non root user for unreadable-profile.test #119816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a requirement for a non root user in unreadable-profile.test. This test fails if run as a root user (like in a container without explicitly changing the user), which can lead to some CI test failures.
boomanaiden154
requested review from
aaupov,
maksfb,
rafaelauler,
ayermolo and
dcci
as code owners
|
@llvm/pr-subscribers-bolt Author: Aiden Grossman (boomanaiden154) ChangesThis patch adds a requirement for a non root user in unreadable-profile.test. This test fails if run as a root user (like in a container without explicitly changing the user), which can lead to some CI test failures. Full diff: https://github.com/llvm/llvm-project/pull/119816.diff 1 Files Affected:
diff --git a/bolt/test/unreadable-profile.test b/bolt/test/unreadable-profile.test
index fe1ca93f3221e8..4c1cd8af0a62c1 100644
--- a/bolt/test/unreadable-profile.test
+++ b/bolt/test/unreadable-profile.test
@@ -1,4 +1,4 @@
-REQUIRES: system-linux
+REQUIRES: system-linux, non-root-user
RUN: touch %t.profile && chmod 000 %t.profile
RUN: %clang %S/Inputs/hello.c -o %t
|
boomanaiden154
deleted the
bolt-non-root-user-unreadable-profile-test
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a requirement for a non root user in unreadable-profile.test. This test fails if run as a root user (like in a container without explicitly changing the user), which can lead to some CI test failures.