Skip to content

[AsmParser] Allow comparing ValIDs with different kinds #119834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

dtcxzyw
Copy link
Member

@dtcxzyw dtcxzyw commented Dec 13, 2024

This patch allows comparing t_[Local|Global]ID with t_[Local|Global]Name.
Closes #119818.

@dtcxzyw dtcxzyw requested a review from nikic December 13, 2024 07:45
@dtcxzyw dtcxzyw changed the title [LLParser] Allow comparing ValIDs with different kinds [AsmParser] Allow comparing ValIDs with different kinds Dec 13, 2024
Copy link
Contributor

@nikic nikic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dtcxzyw dtcxzyw merged commit a25b2ba into llvm:main Dec 13, 2024
8 checks passed
@dtcxzyw dtcxzyw deleted the fix-blockaddress-irparser branch December 13, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[LLParser] Constant blockaddress with non-number block id is not supported
2 participants