Skip to content

[compiler-rt][AArch64] Allow platform-specific mangling of SME routines. #119864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 16, 2024
Merged

[compiler-rt][AArch64] Allow platform-specific mangling of SME routines. #119864

merged 1 commit into from
Dec 16, 2024

Conversation

sdesmalen-arm
Copy link
Collaborator

Support platform-specific mangling to avoid the compiler emitting a call to a function that is mangled differently than the definition in the runtime library.

@sdesmalen-arm
[compiler-rt][AArch64] Allow platform-specific mangling of SME routines.
83152b3 
Support platform-specific mangling to avoid the compiler emitting
a call to a function that is mangled differently than the definition
in the runtime library.
DanielKristofKiss
DanielKristofKiss approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@DanielKristofKiss DanielKristofKiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdesmalen-arm sdesmalen-arm merged commit e0fb3ac into llvm:main Dec 16, 2024
10 checks passed
@JDevlieghere
Copy link
Member

This appears to break building compiler-rt on Apple Silicon: https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/17192/console

/var/folders/nx/xsvw01q14kg11tbhjx5vgmr00000gn/T/sme-libc-mem-routines-b63f23.s:21:9: error: conditional branch requires assembler-local label. '.Lcopy_long' is external.
        b.hi .Lcopy_long
        ^
/var/folders/nx/xsvw01q14kg11tbhjx5vgmr00000gn/T/sme-libc-mem-routines-b63f23.s:23:9: error: conditional branch requires assembler-local label. '.Lcopy32_128' is external.
        b.hi .Lcopy32_128
        ^
/var/folders/nx/xsvw01q14kg11tbhjx5vgmr00000gn/T/sme-libc-mem-routines-b63f23.s:27:9: error: conditional branch requires assembler-local label. '.Lcopy16' is external.
        b.lo .Lcopy16
        ^
/var/folders/nx/xsvw01q14kg11tbhjx5vgmr00000gn/T/sme-libc-mem-routines-b63f23.s:36:9: error: Invalid relocation on conditional branch!
        tbz x2, 3, .Lcopy8
        ^
/var/folders/nx/xsvw01q14kg11tbhjx5vgmr00000gn/T/sme-libc-mem-routines-b63f23.s:46:9: error: Invalid relocation on conditional branch!

Can you please take a look and/or revert while this is being investigated?

sdesmalen-arm added a commit that referenced this pull request Dec 16, 2024
@sdesmalen-arm
Revert "[compiler-rt][AArch64] Allow platform-specific mangling of SM…
4032ce3 
…E routines. (#119864)"

This reverts commit e0fb3ac.
@sdesmalen-arm
Copy link
Collaborator Author

Thanks for letting me know @JDevlieghere, I've reverted it for now!

sdesmalen-arm added a commit that referenced this pull request Dec 17, 2024
@sdesmalen-arm
Reland "[compiler-rt][AArch64] Allow platform-specific mangling of SM…
1b80990 
…E routines. (#119864)"

Avoid issues caused by `.subsections_via_symbols` directive, by using
numbered labels instead of named labels for the branch locations.

This reverts commit 4032ce3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielKristofKiss DanielKristofKiss DanielKristofKiss approved these changes

@jroelofs jroelofs Awaiting requested review from jroelofs

@kmclaughlin-arm kmclaughlin-arm Awaiting requested review from kmclaughlin-arm

Assignees
No one assigned
Labels
compiler-rt:builtins compiler-rt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sdesmalen-arm @JDevlieghere @DanielKristofKiss @llvmbot