Skip to content

Fix SemaCXX/msvc-pragma-function-no-builtin-attr.cpp test #119873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

VScigolevs
Copy link
Contributor

Fix test failure from 84b0f01

@llvmbot llvmbot added the clang Clang issues not falling into any other category label Dec 13, 2024
@llvmbot
Copy link
Member

llvmbot commented Dec 13, 2024

@llvm/pr-subscribers-clang

Author: None (VScigolevs)

Changes

Fix test failure from 84b0f01


Full diff: https://github.com/llvm/llvm-project/pull/119873.diff

1 Files Affected:

  • (modified) clang/test/SemaCXX/msvc-pragma-function-no-builtin-attr.cpp (+1-1)
diff --git a/clang/test/SemaCXX/msvc-pragma-function-no-builtin-attr.cpp b/clang/test/SemaCXX/msvc-pragma-function-no-builtin-attr.cpp
index cd2ac7d1edbefb..066c66884e33c1 100644
--- a/clang/test/SemaCXX/msvc-pragma-function-no-builtin-attr.cpp
+++ b/clang/test/SemaCXX/msvc-pragma-function-no-builtin-attr.cpp
@@ -1,4 +1,4 @@
-// RUN: %clang_cl -fms-compatibility -Xclang -ast-dump -fsyntax-only %s | FileCheck %s
+// RUN: %clang_cl -fms-compatibility -Xclang -ast-dump -fsyntax-only -- %s | FileCheck %s
 
 extern "C" __inline float __cdecl fabsf(  float _X);
 // CHECK: FunctionDecl {{.*}} fabsf

@pawosm-arm
Copy link
Contributor

I suppose this is the reason check-clang fails today.

@RIscRIpt
Copy link
Member

This should fix https://lab.llvm.org/buildbot/#/builders/190/builds/11300

I am compiling clang locally to verify that there would be no other problems with the test on macOS.

I suppose this is the reason check-clang fails today.

Are there other test failures related to 84b0f01 ?

Copy link
Member

@RIscRIpt RIscRIpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this fixes clang/test/SemaCXX/msvc-pragma-function-no-builtin-attr.cpp on macOS.

@RIscRIpt RIscRIpt merged commit 12a42a6 into llvm:main Dec 13, 2024
7 of 10 checks passed
@pawosm-arm
Copy link
Contributor

pawosm-arm commented Dec 13, 2024

This should fix https://lab.llvm.org/buildbot/#/builders/190/builds/11300

I am compiling clang locally to verify that there would be no other problems with the test on macOS.

I suppose this is the reason check-clang fails today.

Are there other test failures related to 84b0f01 ?

I'm seeing this on Linux:

12:23:53  Testing:  0.. 10.. 20
12:23:53  FAIL: Clang :: SemaCXX/msvc-pragma-function-no-builtin-attr.cpp (18416 of 82158)
12:23:53  ******************** TEST 'Clang :: SemaCXX/msvc-pragma-function-no-builtin-attr.cpp' FAILED ********************
12:23:53  Exit Code: 2
12:23:53  
12:23:53  Command Output (stderr):
12:23:53  --
12:23:53  RUN: at line 1: /workspace/build/stage/bootstrap_compiler/bin/clang --driver-mode=cl -fms-compatibility -Xclang -ast-dump -fsyntax-only /workspace/src/clang/test/SemaCXX/msvc-pragma-function-no-builtin-attr.cpp | /workspace/build/stage/bootstrap_compiler/bin/FileCheck /workspace/src/clang/test/SemaCXX/msvc-pragma-function-no-builtin-attr.cpp
12:23:53  + /workspace/build/stage/bootstrap_compiler/bin/clang --driver-mode=cl -fms-compatibility -Xclang -ast-dump -fsyntax-only /workspace/src/clang/test/SemaCXX/msvc-pragma-function-no-builtin-attr.cpp
12:23:53  + /workspace/build/stage/bootstrap_compiler/bin/FileCheck /workspace/src/clang/test/SemaCXX/msvc-pragma-function-no-builtin-attr.cpp
12:23:53  clang: error: no input files
12:23:53  FileCheck error: '<stdin>' is empty.
12:23:53  FileCheck command line:  /workspace/build/stage/bootstrap_compiler/bin/FileCheck /workspace/src/clang/test/SemaCXX/msvc-pragma-function-no-builtin-attr.cpp
12:23:53  
12:23:53  --
12:23:53  
12:23:53  ********************
12:24:45  Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90.. 
12:24:45  
12:24:45  1 warning(s) in tests
12:24:45  ********************
12:24:45  Failed Tests (1):
12:24:45    Clang :: SemaCXX/msvc-pragma-function-no-builtin-attr.cpp

@RIscRIpt
Copy link
Member

I'm seeing this on Linux: ...

Yes, the same problem. It should be fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants