-
Notifications
You must be signed in to change notification settings - Fork 14.4k
Fix SemaCXX/msvc-pragma-function-no-builtin-attr.cpp test #119873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SemaCXX/msvc-pragma-function-no-builtin-attr.cpp test #119873
Conversation
Fix test failure from 84b0f01
@llvm/pr-subscribers-clang Author: None (VScigolevs) ChangesFix test failure from 84b0f01 Full diff: https://github.com/llvm/llvm-project/pull/119873.diff 1 Files Affected:
diff --git a/clang/test/SemaCXX/msvc-pragma-function-no-builtin-attr.cpp b/clang/test/SemaCXX/msvc-pragma-function-no-builtin-attr.cpp
index cd2ac7d1edbefb..066c66884e33c1 100644
--- a/clang/test/SemaCXX/msvc-pragma-function-no-builtin-attr.cpp
+++ b/clang/test/SemaCXX/msvc-pragma-function-no-builtin-attr.cpp
@@ -1,4 +1,4 @@
-// RUN: %clang_cl -fms-compatibility -Xclang -ast-dump -fsyntax-only %s | FileCheck %s
+// RUN: %clang_cl -fms-compatibility -Xclang -ast-dump -fsyntax-only -- %s | FileCheck %s
extern "C" __inline float __cdecl fabsf( float _X);
// CHECK: FunctionDecl {{.*}} fabsf
|
I suppose this is the reason check-clang fails today. |
This should fix https://lab.llvm.org/buildbot/#/builders/190/builds/11300 I am compiling clang locally to verify that there would be no other problems with the test on macOS.
Are there other test failures related to 84b0f01 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this fixes clang/test/SemaCXX/msvc-pragma-function-no-builtin-attr.cpp
on macOS.
I'm seeing this on Linux:
|
Yes, the same problem. It should be fixed now. |
Fix test failure from 84b0f01