Skip to content

Revert "[NFC] Don't recompute type name" #119907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Revert "[NFC] Don't recompute type name" #119907

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68d7d77
Revert "[NFC] Don't recompute type name (#119631)"
IanWood1 Dec 13, 2024
b858dfc
Fix formatting
IanWood1 Dec 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 11 additions & 18 deletions llvm/include/llvm/Support/TypeName.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,17 @@

namespace llvm {

namespace detail {
template <typename DesiredTypeName> inline StringRef getTypeNameImpl() {
/// We provide a function which tries to compute the (demangled) name of a type
/// statically.
///
/// This routine may fail on some platforms or for particularly unusual types.
/// Do not use it for anything other than logging and debugging aids. It isn't
/// portable or dependendable in any real sense.
///
/// The returned StringRef will point into a static storage duration string.
/// However, it may not be null terminated and may be some strangely aligned
/// inner substring of a larger string.
template <typename DesiredTypeName> inline StringRef getTypeName() {
#if defined(__clang__) || defined(__GNUC__)
StringRef Name = __PRETTY_FUNCTION__;

Expand Down Expand Up @@ -48,22 +57,6 @@ template <typename DesiredTypeName> inline StringRef getTypeNameImpl() {
return "UNKNOWN_TYPE";
#endif
}
} // namespace detail

/// We provide a function which tries to compute the (demangled) name of a type
/// statically.
///
/// This routine may fail on some platforms or for particularly unusual types.
/// Do not use it for anything other than logging and debugging aids. It isn't
/// portable or dependendable in any real sense.
///
/// The returned StringRef will point into a static storage duration string.
/// However, it may not be null terminated and may be some strangely aligned
/// inner substring of a larger string.
template <typename DesiredTypeName> inline StringRef getTypeName() {
static StringRef Name = detail::getTypeNameImpl<DesiredTypeName>();
return Name;
}

} // namespace llvm

Expand Down
Loading