Skip to content

[Support] Fix getTypeNameImpl on msvc #119910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Conversation

IanWood1
Copy link
Contributor

@IanWood1 IanWood1 commented Dec 13, 2024

Updates Key to reflect the new name of the function enclosing __FUNCSIG__. Fixes CI failures #119631 (comment)

@llvmbot
Copy link
Member

llvmbot commented Dec 13, 2024

@llvm/pr-subscribers-llvm-support

Author: Ian Wood (IanWood1)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/119910.diff

1 Files Affected:

  • (modified) llvm/include/llvm/Support/TypeName.h (+1-1)
diff --git a/llvm/include/llvm/Support/TypeName.h b/llvm/include/llvm/Support/TypeName.h
index 61ba09c2163047..baa7a691302e3c 100644
--- a/llvm/include/llvm/Support/TypeName.h
+++ b/llvm/include/llvm/Support/TypeName.h
@@ -28,7 +28,7 @@ template <typename DesiredTypeName> inline StringRef getTypeNameImpl() {
 #elif defined(_MSC_VER)
   StringRef Name = __FUNCSIG__;
 
-  StringRef Key = "getTypeName<";
+  StringRef Key = "getTypeNameImpl<";
   Name = Name.substr(Name.find(Key));
   assert(!Name.empty() && "Unable to find the function name!");
   Name = Name.drop_front(Key.size());

@IanWood1 IanWood1 merged commit 5cac0eb into llvm:main Dec 13, 2024
7 of 9 checks passed
@IanWood1
Copy link
Contributor Author

It looks like this fixed the problem, thank you for the quick review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants