Skip to content

[mlir] Retain original identifier names for debugging v2 #119944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

makslevental
Copy link
Contributor

Based on #79704

Copy link

github-actions bot commented Dec 14, 2024

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:
git-clang-format --diff 60325abeb3226b17c28429dfa6e175f25c171ec0 f77018548f0924c4561664966cc9bd644a7a125b --extensions h,cpp -- mlir/include/mlir/IR/AsmState.h mlir/include/mlir/IR/OperationSupport.h mlir/include/mlir/IR/Value.h mlir/include/mlir/Tools/mlir-opt/MlirOptMain.h mlir/lib/AsmParser/Parser.cpp mlir/lib/IR/AsmPrinter.cpp mlir/lib/IR/Operation.cpp mlir/lib/Tools/mlir-opt/MlirOptMain.cpp
View the diff from clang-format here.
diff --git a/mlir/lib/AsmParser/Parser.cpp b/mlir/lib/AsmParser/Parser.cpp
index d487b0bbdb..3eb743dcdc 100644
--- a/mlir/lib/AsmParser/Parser.cpp
+++ b/mlir/lib/AsmParser/Parser.cpp
@@ -2209,8 +2209,7 @@ OperationParser::parseTrailingLocationSpecifier(OpOrArgument opOrArgument) {
     op->setLoc(directLoc);
     for (auto result : op->getResults())
       result.setLoc(directLoc);
-  }
-  else
+  } else
     opOrArgument.get<BlockArgument>().setLoc(directLoc);
   return success();
 }

@makslevental makslevental force-pushed the makslevental/retain-names-dev-v3 branch 12 times, most recently from feadec5 to d637d02 Compare December 14, 2024 09:19
@makslevental makslevental force-pushed the makslevental/retain-names-dev-v3 branch from d637d02 to f770185 Compare December 14, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant