Skip to content

Revert "[Static analysis] Encodes a filename before inserting it into a URL." #120195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rniwa
Copy link
Contributor

@rniwa rniwa commented Dec 17, 2024

Reverts #120123
Broke some tests.

@llvmbot llvmbot added clang Clang issues not falling into any other category clang:static analyzer labels Dec 17, 2024
@rniwa rniwa merged commit 6db1b20 into main Dec 17, 2024
7 of 9 checks passed
@rniwa rniwa deleted the revert-120123-static-analysis-encode-special-chars-in-filename branch December 17, 2024 07:36
@llvmbot
Copy link
Member

llvmbot commented Dec 17, 2024

@llvm/pr-subscribers-clang-static-analyzer-1

@llvm/pr-subscribers-clang

Author: Ryosuke Niwa (rniwa)

Changes

Reverts llvm/llvm-project#120123
Broke some tests.


Full diff: https://github.com/llvm/llvm-project/pull/120195.diff

1 Files Affected:

  • (modified) clang/tools/scan-build/bin/scan-build (+1-3)
diff --git a/clang/tools/scan-build/bin/scan-build b/clang/tools/scan-build/bin/scan-build
index 1df043ef8b72bd..37241c6d85c5b2 100755
--- a/clang/tools/scan-build/bin/scan-build
+++ b/clang/tools/scan-build/bin/scan-build
@@ -23,7 +23,6 @@ use Term::ANSIColor qw(:constants);
 use Cwd qw/ getcwd abs_path /;
 use Sys::Hostname;
 use Hash::Util qw(lock_keys);
-use URI::Escape;
 
 my $Prog = "scan-build";
 my $BuildName;
@@ -821,8 +820,7 @@ ENDTEXT
       }
 
       # Emit the "View" link.
-      my $EncodedReport = uri_escape($ReportFile, "^A-Za-z0-9\-\._~\/");
-      print OUT "<td><a href=\"$EncodedReport#EndPath\">View Report</a></td>";
+      print OUT "<td><a href=\"$ReportFile#EndPath\">View Report</a></td>";
 
       # Emit REPORTBUG markers.
       print OUT "\n<!-- REPORTBUG id=\"$ReportFile\" -->\n";

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:static analyzer clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants