-
Notifications
You must be signed in to change notification settings - Fork 14.3k
RegAllocGreedy: Fix subrange based instruction split logic #120199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
arsenm
wants to merge
1
commit into
main
Choose a base branch
from
users/arsenm/greedy-fix-subrange-instruction-split-logic
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+486
−461
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59 changes: 59 additions & 0 deletions
59
.../CodeGen/AMDGPU/inflated-reg-class-snippet-copy-inst-reads-lane-subset-use-after-free.mir
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
# XFAIL: * | ||
# RUN: llc -mtriple=amdgcn-amd-amdhsa -mcpu=gfx90a -simplify-mir -start-before=greedy,2 -stress-regalloc=4 -stop-before=virtregrewriter,2 -filetype=null -verify-regalloc %s | ||
|
||
# This test is similar to | ||
# inflated-reg-class-snippet-copy-use-after-free.mir, except it is | ||
# still broken when the use instruction does not read the full set of | ||
# lanes | ||
|
||
--- | | ||
define amdgpu_kernel void @inflated_reg_class_copy_use_after_free_lane_subset() { | ||
ret void | ||
} | ||
... | ||
--- | ||
name: inflated_reg_class_copy_use_after_free_lane_subset | ||
tracksRegLiveness: true | ||
machineFunctionInfo: | ||
explicitKernArgSize: 8 | ||
maxKernArgAlign: 8 | ||
isEntryFunction: true | ||
memoryBound: true | ||
waveLimiter: true | ||
scratchRSrcReg: '$sgpr72_sgpr73_sgpr74_sgpr75' | ||
stackPtrOffsetReg: '$sgpr32' | ||
returnsVoid: true | ||
occupancy: 7 | ||
vgprForAGPRCopy: '$vgpr255' | ||
sgprForEXECCopy: '$sgpr74_sgpr75' | ||
longBranchReservedReg: '' | ||
body: | | ||
bb.0: | ||
liveins: $vgpr0, $sgpr4_sgpr5 | ||
|
||
%0:vgpr_32 = IMPLICIT_DEF | ||
renamable $sgpr0_sgpr1 = S_LOAD_DWORDX2_IMM killed undef renamable $sgpr4_sgpr5, 0, 0 :: (load (s64), addrspace 4) | ||
S_NOP 0, implicit-def undef %1.sub12_sub13_sub14_sub15:vreg_512_align2 | ||
S_NOP 0, implicit-def %1.sub8_sub9_sub10_sub11:vreg_512_align2 | ||
S_NOP 0, implicit-def %1.sub4_sub5_sub6_sub7:vreg_512_align2 | ||
S_NOP 0, implicit-def %1.sub0_sub1_sub2_sub3:vreg_512_align2 | ||
S_NOP 0, implicit-def early-clobber %2:vreg_512_align2, implicit %1.sub0_sub1_sub2_sub3, implicit %1.sub4_sub5_sub6_sub7 | ||
%1.sub2:vreg_512_align2 = COPY %2.sub3 | ||
%1.sub3:vreg_512_align2 = COPY %2.sub2 | ||
%1.sub4:vreg_512_align2 = COPY %2.sub0 | ||
%1.sub5:vreg_512_align2 = V_MOV_B32_e32 0, implicit $exec | ||
%1.sub6:vreg_512_align2 = V_MOV_B32_e32 0, implicit $exec | ||
%1.sub7:vreg_512_align2 = V_MOV_B32_e32 0, implicit $exec | ||
%1.sub8:vreg_512_align2 = V_MOV_B32_e32 0, implicit $exec | ||
%1.sub9:vreg_512_align2 = V_MOV_B32_e32 0, implicit $exec | ||
%1.sub10:vreg_512_align2 = V_MOV_B32_e32 0, implicit $exec | ||
%1.sub11:vreg_512_align2 = V_MOV_B32_e32 0, implicit $exec | ||
%1.sub12:vreg_512_align2 = V_MOV_B32_e32 0, implicit $exec | ||
%1.sub13:vreg_512_align2 = V_MOV_B32_e32 0, implicit $exec | ||
%1.sub14:vreg_512_align2 = V_MOV_B32_e32 0, implicit $exec | ||
%1.sub15:vreg_512_align2 = V_MOV_B32_e32 0, implicit $exec | ||
S_NOP 0, implicit-def %1:vreg_512_align2, implicit %1.sub0_sub1_sub2_sub3, implicit %1.sub4_sub5_sub6_sub7, implicit %1.sub8_sub9_sub10_sub11 | ||
GLOBAL_STORE_DWORDX4_SADDR undef %3:vgpr_32, %1.sub12_sub13_sub14_sub15, undef renamable $sgpr0_sgpr1, 96, 0, implicit $exec :: (store (s128), addrspace 1) | ||
S_ENDPGM 0 | ||
|
||
... |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we read the full virtual register, shouldn't we return
true
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this is checking for a strict subset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah that makes sense. Thanks for updating the comment of the function.