[SDPatternMatch] Add matchers m_ExtractSubvector and m_InsertSubvector #120212

cheezeburglar · 2024-12-17T11:07:07Z

github-actions · 2024-12-17T11:07:30Z

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

RKSimon · 2025-01-03T17:46:09Z

@cheezeburglar Sorry I missed this over the Christmas break

RKSimon

A few minors @mshockwave WDYT?

RKSimon · 2025-01-03T17:47:23Z

llvm/include/llvm/CodeGen/SDPatternMatch.h

@@ -802,6 +808,12 @@ inline BinaryOpc_match<LHS, RHS> m_ExtractElt(const LHS &Vec, const RHS &Idx) {
  return BinaryOpc_match<LHS, RHS>(ISD::EXTRACT_VECTOR_ELT, Vec, Idx);
 }

+template <typename LHS, typename RHS>
+inline BinaryOpc_match<LHS, RHS> m_ExtractSubvector(const LHS &L,
+                                                    const RHS &R) {


(pedantic) replace L and R with Vec and Idx

Done, in subsequent commit

llvm/unittests/CodeGen/SelectionDAGPatternMatchTest.cpp

RKSimon · 2025-01-03T17:48:34Z

llvm/unittests/CodeGen/SelectionDAGPatternMatchTest.cpp

+  EXPECT_TRUE(
+      sd_match(SubVec, m_ExtractSubvector(m_Specific(Vec), m_Specific(Idx0))));
+  EXPECT_TRUE(sd_match(SubVec, m_BinOp(ISD::EXTRACT_SUBVECTOR, m_Specific(Vec),
+                                       m_Specific(Idx0))));


Please can you add true/false tests with a m_SpecificInt() for the index as well

Done, in subsequent commit

llvm/include/llvm/CodeGen/SDPatternMatch.h

mshockwave

Only has a minor comment, otherwise lgtm

mshockwave · 2025-01-03T22:49:56Z

llvm/unittests/CodeGen/SelectionDAGPatternMatchTest.cpp

+  EXPECT_TRUE(
+      sd_match(SubVec, m_BinOp(ISD::EXTRACT_SUBVECTOR, m_Value(), m_Value())));
+  EXPECT_TRUE(
+      sd_match(SubVec, m_ExtractSubvector(m_Specific(Vec), m_Specific(Idx0))));
+  EXPECT_TRUE(sd_match(SubVec, m_BinOp(ISD::EXTRACT_SUBVECTOR, m_Specific(Vec),


I don't think we really need the checks with m_BinOp here. m_ExtractSubvector should suffice.

Done, in subsequent commit

RKSimon

LGTM - cheers

github-actions · 2025-01-09T08:39:17Z

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:

git-clang-format --diff 300deebf41d2da96701fe29c0faa8025b7efa120 f1a7cc99b45f42a5699c0464eabb1ec72cd3f967 --extensions cpp,h -- llvm/include/llvm/CodeGen/SDPatternMatch.h llvm/unittests/CodeGen/SelectionDAGPatternMatchTest.cpp

View the diff from clang-format here.

diff --git a/llvm/unittests/CodeGen/SelectionDAGPatternMatchTest.cpp b/llvm/unittests/CodeGen/SelectionDAGPatternMatchTest.cpp
index 81ba3171c8..31d7414d3e 100644
--- a/llvm/unittests/CodeGen/SelectionDAGPatternMatchTest.cpp
+++ b/llvm/unittests/CodeGen/SelectionDAGPatternMatchTest.cpp
@@ -203,7 +203,6 @@ TEST_F(SelectionDAGPatternMatchTest, matchTernaryOp) {
   EXPECT_FALSE(sd_match(
       InsertSubvector,
       m_InsertSubvector(m_Specific(V2), m_Specific(V3), m_SpecificInt(3))));
-
 }
 
 TEST_F(SelectionDAGPatternMatchTest, matchBinaryOp) {

mshockwave · 2025-01-09T17:21:04Z

llvm/unittests/CodeGen/SelectionDAGPatternMatchTest.cpp

+  EXPECT_FALSE(sd_match(
+      InsertSubvector,
+      m_InsertSubvector(m_Specific(V2), m_Specific(V3), m_SpecificInt(3))));
+


@cheezeburglar could you remove this empty line to make clang-format happy?

Mea culpa - I think the latest commit should make it pass the linter. On my machine

$ git-clang-format --diff 300deebf41d2da96701fe29c0faa8025b7efa120 f1a7cc99b45f42a5699c0464eabb1ec72cd3f967 --extensions cpp,h -- llvm/include/llvm/CodeGen/SDPatternMatch.h llvm/unittests/CodeGen/SelectionDAGPatternMatchTest.cpp

produces no output.

mshockwave

LGTM congrats!

github-actions · 2025-01-09T23:21:07Z

@cheezeburglar Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

llvm#120212) Fixes llvm#118846

Add matchers m_ExtractSubvector and m_InsertSubvector

24329cf

RKSimon requested review from RKSimon and mshockwave January 3, 2025 17:45

RKSimon reviewed Jan 3, 2025

View reviewed changes

mshockwave reviewed Jan 3, 2025

View reviewed changes

All revisions

f1a7cc9

RKSimon approved these changes Jan 9, 2025

View reviewed changes

nikic changed the title ~~Add matchers m_ExtractSubvector and m_InsertSubvector~~ [SDPatternMatch] Add matchers m_ExtractSubvector and m_InsertSubvector Jan 9, 2025

mshockwave reviewed Jan 9, 2025

View reviewed changes

Linting

1d89bf0

mshockwave approved these changes Jan 9, 2025

View reviewed changes

mshockwave merged commit c1c50c7 into llvm:main Jan 9, 2025
4 of 5 checks passed

BaiXilin pushed a commit to BaiXilin/llvm-fix-vnni-instr-types that referenced this pull request Jan 12, 2025

[SDPatternMatch] Add matchers m_ExtractSubvector and m_InsertSubvector (

dff62f2

llvm#120212) Fixes llvm#118846

[SDPatternMatch] Add matchers m_ExtractSubvector and m_InsertSubvector #120212

[SDPatternMatch] Add matchers m_ExtractSubvector and m_InsertSubvector #120212

Uh oh!

Conversation

cheezeburglar commented Dec 17, 2024 • edited by RKSimon Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 17, 2024

Uh oh!

RKSimon commented Jan 3, 2025

Uh oh!

RKSimon left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mshockwave left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RKSimon left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 9, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mshockwave left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Jan 9, 2025

Uh oh!

Uh oh!

cheezeburglar commented Dec 17, 2024 •

edited by RKSimon

Loading