[LLVM] Update debuginfo maintainers #120231
Conversation
|
I thought @dwblaikie and @adrian-prantl were the debug-info owners? Did that not get propagated correctly? |
They are listed as the owners for clang debug info (see https://github.com/llvm/llvm-project/blob/main/clang/Maintainers.rst#debug-information). Should it be the same people for LLVM? |
It's a good rough start. If we wanted to get more specific, I'm probably more suitable as an owner of DWARF type information, or perhaps more generally non-variable information. Some Sony folks have really been investing in the variable information, including @jmorse who I'd happily promote as owner of the variable information. |
Yeah. I agree with Dave here. If you want to keep me in as a "last resort" or tiebreaker then that's fine with me - other than variable information the code is pretty similar and hasn't changed much :) |
nikic
force-pushed
the
debuginfo-maintainers
branch
2 times, most recently
from
962efd5 to
7b3f82b
Compare
|
Okay, I've updated this now to include the clang debuginfo maintainers + @jmorse with some focus areas in parentheses. Do you have any suggestions for the "DWARF Parser" category, or should it maybe be dropped entirely? I'm not entirely sure what part of the codebase exactly this refers to (is it all of https://github.com/llvm/llvm-project/tree/main/llvm/lib/DebugInfo/DWARF or some specific part of it?) |
|
Yeah, it's that. I don't think it covers the similar, but different code in
lldb. The same owners should work there too.
…On Wed, Dec 18, 2024, 4:37 AM Nikita Popov ***@***.***> wrote:
Okay, I've updated this now to include the clang debuginfo maintainers +
@jmorse <https://github.com/jmorse> with some focus areas in parentheses.
Do you have any suggestions for the "DWARF Parser" category, or should it
maybe be dropped entirely? I'm not entirely sure what part of the codebase
exactly this refers to (is it all of
https://github.com/llvm/llvm-project/tree/main/llvm/lib/DebugInfo/DWARF
or some specific part of it?)
—
Reply to this email directly, view it on GitHub
<#120231 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACP5DCQDLIGCRBN3ZU7ZV32GFM7BAVCNFSM6AAAAABTYNQY7CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJRGA4TCNRQGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Yep - the CodeView side of it (llvm/lib/DebugInfo/CodeView) is probably @zmodem or he might be able to point to someone else. |
I would probably just roll that into the general Debug Info category because it's more or less the same group of people. |
|
Done, I've merged this into a "Debug info and DWARF" category now. |
nikic
requested review from
echristo,
jmorse,
adrian-prantl,
dwblaikie and
d0k
|
Since it's rather specialized, It might make sense to list @JDevlieghere for dsymutil/DWARFLinker. |
| @@ -458,6 +459,7 @@ Evan Cheng ([email protected]) -- Parts of code generator not covered by some | |||
| Renato Golin ([email protected], [rengolin](https://github.com/rengolin)) -- ARM backend \ | |||
| James Grosbach ([email protected]) -- MC layer \ | |||
| Anton Korobeynikov ([email protected], [asl](https://github.com/asl)) -- ARM EABI \ | |||
| Benjamin Kramer ([email protected], [d0k](https://github.com/d0k)) -- DWARF Parser \ | |||
There was a problem hiding this comment.
I would move the DWARF parser into the Debug info section, if we list it separately at all
There was a problem hiding this comment.
This entry is part of the former/inactive maintainer list.
add clang debug info maintainers + jmorse Merge DWARF into debug info category
nikic
force-pushed
the
debuginfo-maintainers
branch
from
69f6c7d to
d973ed1
Compare
Done! |
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/30/builds/13269 Here is the relevant piece of the build log for the reference |
We currently list @echristo as maintainer for Debuginfo and @d0k for DWARF Parser. I believe that neither of them are particularly active in these areas anymore, so I'd like to to update the information.
This PR is a stub to start discussion, because I think there are a lot of people who work on various aspects of debug info, so I'm not sure who to put down here. Volunteers welcome :)
I'd expect it would be multiple people, and it might make sense to break down "debug info" into some more specific parts.
@llvm/pr-subscribers-debuginfo @SLTozer @OCHyams