-
Notifications
You must be signed in to change notification settings - Fork 14.3k
[LLVM] Add Intel vendor in Triple #120250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We plan to make use of this in SPIR-V-based OpenMP offloading. Signed-off-by: Sarnie, Nick <[email protected]>
Some of the |
Not everything is properly clang-formatted, we tend to leave it that way to reduce noise in PRs but here it's perfectly understandable. |
Cool thanks (and for reviewing a draft PR :) ) |
Not anymore :^) |
What did I walk myself in to? Usually I wait for CI to pass first, but that's just me :P |
@jhuber6 Do you mind merging for me if we don't need any more reviews? Thx! |
Are the merging rules different now? Figured if you were part of LLVM you could merge. |
I didn't have permission so maybe? If there's some process I can follow or someone to email to get merge feel free to link me. Thx alot for the merge. |
I see, I think they updated that at some point...? I don't know the new qualifications. |
I think I just gotta follow this I'm a relatively new contributor so maybe it's early, but I'll see what they say. |
#120284 lets see |
We plan to make use of this in SPIR-V-based OpenMP offloading, for which there is already an initial patch in review.