Skip to content

[LLVM] Add Intel vendor in Triple #120250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2024
Merged

[LLVM] Add Intel vendor in Triple #120250

merged 1 commit into from
Dec 17, 2024

Conversation

sarnex
Copy link
Member

@sarnex sarnex commented Dec 17, 2024

We plan to make use of this in SPIR-V-based OpenMP offloading, for which there is already an initial patch in review.

We plan to make use of this in SPIR-V-based OpenMP offloading.

Signed-off-by: Sarnie, Nick <[email protected]>
@sarnex
Copy link
Member Author

sarnex commented Dec 17, 2024

Some of the clang-format changes seem strange here, let me know if I should disable clang-format for the switch statements.

@jhuber6
Copy link
Contributor

jhuber6 commented Dec 17, 2024

Some of the clang-format changes seem strange here, let me know if I should disable clang-format for the switch statements.

Not everything is properly clang-formatted, we tend to leave it that way to reduce noise in PRs but here it's perfectly understandable.

@sarnex
Copy link
Member Author

sarnex commented Dec 17, 2024

Cool thanks (and for reviewing a draft PR :) )

@jhuber6 jhuber6 marked this pull request as ready for review December 17, 2024 16:35
@jhuber6
Copy link
Contributor

jhuber6 commented Dec 17, 2024

Cool thanks (and for reviewing a draft PR :) )

Not anymore :^)

@sarnex
Copy link
Member Author

sarnex commented Dec 17, 2024

What did I walk myself in to?

Usually I wait for CI to pass first, but that's just me :P

@sarnex
Copy link
Member Author

sarnex commented Dec 17, 2024

@jhuber6 Do you mind merging for me if we don't need any more reviews? Thx!

@jhuber6
Copy link
Contributor

jhuber6 commented Dec 17, 2024

@jhuber6 Do you mind merging for me if we don't need any more reviews? Thx!

Are the merging rules different now? Figured if you were part of LLVM you could merge.

@jhuber6 jhuber6 merged commit 1c16807 into llvm:main Dec 17, 2024
11 checks passed
@sarnex
Copy link
Member Author

sarnex commented Dec 17, 2024

I didn't have permission so maybe? If there's some process I can follow or someone to email to get merge feel free to link me. Thx alot for the merge.

@jhuber6
Copy link
Contributor

jhuber6 commented Dec 17, 2024

I didn't have permission so maybe? If there's some process I can follow or someone to email to get merge feel free to link me. Thx alot for the merge.

I see, I think they updated that at some point...? I don't know the new qualifications.

@sarnex
Copy link
Member Author

sarnex commented Dec 17, 2024

I think I just gotta follow this

I'm a relatively new contributor so maybe it's early, but I'll see what they say.

@sarnex
Copy link
Member Author

sarnex commented Dec 17, 2024

#120284 lets see

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants